Re: [PATCH 1/2] drm/amdgpu: fix re-program vm invalidate eng address range for gfxhub on resume

From: zhoucm1 <david1.zhou-5C7GfCeVMHo@public.gmane.org>
To: "Huang Rui" <ray.huang-5C7GfCeVMHo@public.gmane.org>,
	amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	"Alex Deucher" <alexander.deucher-5C7GfCeVMHo@public.gmane.org>,
	"Christian König" <christian.koenig-5C7GfCeVMHo@public.gmane.org>
Cc: Ken Wang <Qingqing.Wang-5C7GfCeVMHo@public.gmane.org>,
	Alvin Huan <Alvin.Huan-5C7GfCeVMHo@public.gmane.org>
Subject: Re: [PATCH 1/2] drm/amdgpu: fix re-program vm invalidate eng address range for gfxhub on resume
Date: Wed, 17 May 2017 15:43:47 +0800	[thread overview]
Message-ID: <591BFF33.2010303@amd.com> (raw)
In-Reply-To: <1495006729-17310-1-git-send-email-ray.huang-5C7GfCeVMHo@public.gmane.org>

By this change, I suggest to remove mmhub/gfxhub_v1_0_ip_funcs and their 
IP block, unify them to gmc ip block, this way we cannot lost setting 
when resume back.

Regards,
David Zhou

On 2017年05月17日 15:38, Huang Rui wrote:
> Signed-off-by: Huang Rui <ray.huang@amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/gfxhub_v1_0.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gfxhub_v1_0.c b/drivers/gpu/drm/amd/amdgpu/gfxhub_v1_0.c
> index 005075f..41313514 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gfxhub_v1_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gfxhub_v1_0.c
> @@ -368,7 +368,7 @@ static int gfxhub_v1_0_suspend(void *handle)
>   
>   static int gfxhub_v1_0_resume(void *handle)
>   {
> -	return 0;
> +	return gfxhub_v1_0_hw_init(handle);
>   }
>   
>   static bool gfxhub_v1_0_is_idle(void *handle)

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx