From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S937416AbdEWOdC (ORCPT ); Tue, 23 May 2017 10:33:02 -0400 Received: from mail-wm0-f45.google.com ([74.125.82.45]:37009 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934428AbdEWOc5 (ORCPT ); Tue, 23 May 2017 10:32:57 -0400 Subject: Re: [PATCH] firmware: request_firmware() should propagate -ERESTARTSYS To: Greg Kroah-Hartman References: <20170523131607.28138.12306.stgit@localhost> <20170523133112.GA5059@kroah.com> Cc: "Luis R. Rodriguez" , linux-kernel@vger.kernel.org From: Martin Fuzzey Message-ID: <59244811.7080401@parkeon.com> Date: Tue, 23 May 2017 16:32:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20170523133112.GA5059@kroah.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23/05/17 15:31, Greg Kroah-Hartman wrote: > On Tue, May 23, 2017 at 03:16:07PM +0200, Martin Fuzzey wrote: >> When -ERESTARTSYS is returned by wait_* due to a signal this should >> be returned from request_firmware() so that the syscall may be >> restarted if necessary. >> >> >> Nice find, should this go to the stable kernels as well? Yes I think it should. I have already applied a similar patch to my 4.4 tree. The exact same patch won't apply since the code has changed a bit since. So I was planning on sending for -stable-4.4 once it's in mainline. Regards, Martin