From: Daniel Borkmann <daniel@iogearbox.net>
To: David Miller <davem@davemloft.net>
Cc: ast@fb.com, netdev@vger.kernel.org
Subject: Re: [PATCH net 1/3] bpf: fix incorrect pruning decision when alignment must be tracked
Date: Wed, 24 May 2017 22:17:26 +0200 [thread overview]
Message-ID: <5925EA56.3090404@iogearbox.net> (raw)
In-Reply-To: <20170524.160733.216900339299848648.davem@davemloft.net>
On 05/24/2017 10:07 PM, David Miller wrote:
> From: Daniel Borkmann <daniel@iogearbox.net>
> Date: Tue, 23 May 2017 18:30:41 +0200
>
>> + if (!env->strict_alignment && old->off <= cur->off &&
>
> You can't just test env->strict_alignment by itself, that's just an
> override and doesn't determine the actual "strict" value we use which
> is a combination of env->strict_alignment and
> "!CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS".
>
> So you'll have to update this test.
Argh, good point, true. Will respin with a v2.
next prev parent reply other threads:[~2017-05-24 20:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-23 16:30 [PATCH net 0/3] BPF pruning follow-up Daniel Borkmann
2017-05-23 16:30 ` [PATCH net 1/3] bpf: fix incorrect pruning decision when alignment must be tracked Daniel Borkmann
2017-05-24 20:07 ` David Miller
2017-05-24 20:17 ` Daniel Borkmann [this message]
2017-05-23 16:30 ` [PATCH net 2/3] bpf: properly reset caller saved regs after helper call and ld_abs/ind Daniel Borkmann
2017-05-23 16:30 ` [PATCH net 3/3] bpf: add various verifier test cases Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5925EA56.3090404@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=ast@fb.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.