From mboxrd@z Thu Jan 1 00:00:00 1970 From: Inki Dae Subject: Re: [PATCH v2] drm/exynos: dsi: Remove bridge node reference in removal Date: Fri, 26 May 2017 10:07:26 +0900 Message-ID: <59277FCE.9010502@samsung.com> References: <1495760521-330-1-git-send-email-hoegeun.kwon@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-reply-to: <1495760521-330-1-git-send-email-hoegeun.kwon@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Hoegeun Kwon , jy0922.shim@samsung.com, sw0312.kim@samsung.com, airlied@linux.ie, kgene@kernel.org, krzk@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, catalin.marinas@arm.com, will.deacon@arm.com Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, javier@osg.samsung.com, linux-arm-kernel@lists.infradead.org List-Id: linux-samsung-soc@vger.kernel.org CgoyMDE364WEIDA17JuUIDI27J28IDEwOjAy7JeQIEhvZWdldW4gS3dvbiDsnbQo6rCAKSDsk7Qg 6riAOgo+IFNpbmNlIGJyaWRnZSBub2RlIGlzIHJlZmVyZW5jZWQgZHVyaW5nIGluIHRoZSBwcm9i ZSwgaXQgc2hvdWxkIGJlCj4gcmVsZWFzZWQgb24gcmVtb3ZhbC4KPiAKPiBTdWdnZXN0ZWQtYnk6 IEFuZHJ6ZWogSGFqZGEgPGEuaGFqZGFAc2Ftc3VuZy5jb20+Cj4gU2lnbmVkLW9mZi1ieTogSG9l Z2V1biBLd29uIDxob2VnZXVuLmt3b25Ac2Ftc3VuZy5jb20+Cj4gLS0tCj4gSGkgSW5raSwKPiAK PiBUaGlzIHBhdGNoIHNlZW1zIHRvIGhhdmUgYmVlbiBmb3Jnb3R0ZW4uLi4gOikKClllYWgsIGZv cmdvdCB0aGlzLiBNZXJnZWQuCgpUaGFua3MsCklua2kgRGFlCgo+IAo+IENoYW5nZXMgZm9yIFYy Ogo+IAo+IC0gQ2hlY2tlZCBmb3IgcmViYXNlIDQuMTItcmMyCj4gCj4gQmVzdCByZWdhcmRzLAo+ IEhvZWdldW4KPiAKPiAgZHJpdmVycy9ncHUvZHJtL2V4eW5vcy9leHlub3NfZHJtX2RzaS5jIHwg NCArKysrCj4gIDEgZmlsZSBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKykKPiAKPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9ncHUvZHJtL2V4eW5vcy9leHlub3NfZHJtX2RzaS5jIGIvZHJpdmVycy9ncHUv ZHJtL2V4eW5vcy9leHlub3NfZHJtX2RzaS5jCj4gaW5kZXggNjk4YTgyNC4uYTExYjc5NSAxMDA2 NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZXh5bm9zL2V4eW5vc19kcm1fZHNpLmMKPiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vZXh5bm9zL2V4eW5vc19kcm1fZHNpLmMKPiBAQCAtMTgwNSw2ICsx ODA1LDEwIEBAIHN0YXRpYyBpbnQgZXh5bm9zX2RzaV9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2 aWNlICpwZGV2KQo+ICAKPiAgc3RhdGljIGludCBleHlub3NfZHNpX3JlbW92ZShzdHJ1Y3QgcGxh dGZvcm1fZGV2aWNlICpwZGV2KQo+ICB7Cj4gKwlzdHJ1Y3QgZXh5bm9zX2RzaSAqZHNpID0gcGxh dGZvcm1fZ2V0X2RydmRhdGEocGRldik7Cj4gKwo+ICsJb2Zfbm9kZV9wdXQoZHNpLT5icmlkZ2Vf bm9kZSk7Cj4gKwo+ICAJcG1fcnVudGltZV9kaXNhYmxlKCZwZGV2LT5kZXYpOwo+ICAKPiAgCWNv bXBvbmVudF9kZWwoJnBkZXYtPmRldiwgJmV4eW5vc19kc2lfY29tcG9uZW50X29wcyk7Cj4gCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBt YWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: inki.dae@samsung.com (Inki Dae) Date: Fri, 26 May 2017 10:07:26 +0900 Subject: [PATCH v2] drm/exynos: dsi: Remove bridge node reference in removal In-Reply-To: <1495760521-330-1-git-send-email-hoegeun.kwon@samsung.com> References: <1495760521-330-1-git-send-email-hoegeun.kwon@samsung.com> Message-ID: <59277FCE.9010502@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org 2017? 05? 26? 10:02? Hoegeun Kwon ?(?) ? ?: > Since bridge node is referenced during in the probe, it should be > released on removal. > > Suggested-by: Andrzej Hajda > Signed-off-by: Hoegeun Kwon > --- > Hi Inki, > > This patch seems to have been forgotten... :) Yeah, forgot this. Merged. Thanks, Inki Dae > > Changes for V2: > > - Checked for rebase 4.12-rc2 > > Best regards, > Hoegeun > > drivers/gpu/drm/exynos/exynos_drm_dsi.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c > index 698a824..a11b795 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c > @@ -1805,6 +1805,10 @@ static int exynos_dsi_probe(struct platform_device *pdev) > > static int exynos_dsi_remove(struct platform_device *pdev) > { > + struct exynos_dsi *dsi = platform_get_drvdata(pdev); > + > + of_node_put(dsi->bridge_node); > + > pm_runtime_disable(&pdev->dev); > > component_del(&pdev->dev, &exynos_dsi_component_ops); > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S939523AbdEZBHh (ORCPT ); Thu, 25 May 2017 21:07:37 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:49048 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S939494AbdEZBHb (ORCPT ); Thu, 25 May 2017 21:07:31 -0400 X-AuditID: b6c32a2c-f79be6d0000051f7-0a-59277fd07dbc MIME-version: 1.0 Content-transfer-encoding: 8BIT Content-type: text/plain; charset="utf-8" Message-id: <59277FCE.9010502@samsung.com> Date: Fri, 26 May 2017 10:07:26 +0900 From: Inki Dae User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Hoegeun Kwon , jy0922.shim@samsung.com, sw0312.kim@samsung.com, airlied@linux.ie, kgene@kernel.org, krzk@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, catalin.marinas@arm.com, will.deacon@arm.com Cc: javier@osg.samsung.com, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, a.hajda@samsung.com Subject: Re: [PATCH v2] drm/exynos: dsi: Remove bridge node reference in removal In-reply-to: <1495760521-330-1-git-send-email-hoegeun.kwon@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrBJsWRmVeSWpSXmKPExsWy7bCmpu6FevVIg3dXjC1urTvHatF77iST xftlPYwW848AuVe+vmezeL+8i83izds1TBYv7l1kseh//JrZ4vz5DewWmx5fY7W4vGsOm8WM 8/uYLJZev8hk0br3CLvFjMkv2SxefjzB4iDosWbeGkaPTas62Ty2f3vA6nG/+ziTx+Yl9R5b +u+ye/RtWcXo8XmTXABHVKpNRmpiSmqRQmpecn5KZl66rZJ3cLxzvKmZgaGuoaWFuZJCXmJu qq2Si0+ArltmDtAbSgpliTmlQKGAxOJiJX07m6L80pJUhYz84hJbpWhDQyM9QwNzPSMjIz0T 41grI1OgkoTUjO0HnzIVzOas+Dr3IlsD4wn2LkZODgkBE4lT7++zQNhiEhfurWfrYuTiEBJY yiix+ut+JgjnM6PEzx3XGLsYOcA65p52hYjvYJR4vekEM0g3r4CgxI/J91hAapgF5CWOXMoG CTMLaEq8+DKJBaL+HqPEzMUrmSDqtSQ2zpvKCmKzCKhKPG48A3YRG5A9ccV9NhBbVCBCYuf8 b+wgzSIC7xkljh3eDnYRs8BNRomHF6+DdQsLBEnsWb0F7AdOAXeJl7NXMEP885VdYs3ETIir ZSU2HYAKu0jsOniBEcIWlnh1fAs0KKQkujtmgS2TEGhnlGibeYYVwmlhlPjfcwUaSMYSp7oa mSB+45Po/f2ECWIBr0RHmxBEiYfEzQkLoYY6SkzecZsR4v1ZjBLvLv5lmsAoPwspxGYhQmwW UogtYGRexSiWWlCcm55abFpgqFecmFtcmpeul5yfu4kRnIq1dHYw3lvgfYhRgINRiYfXQUg9 Uog1say4MvcQowQHs5II79Z0oBBvSmJlVWpRfnxRaU5q8SFGU2CAT2SWEk3OB+aJvJJ4QxNL AxNTM2MDY0MLSyVxXo2V1yKEBNITS1KzU1MLUotg+pg4OKUaGN1O5UszFxxljTV82BQ5v/7B i/M5Wf6rslra7Bdv3Pk+UOOCafnkCPv1V3We9X8JNNzmxtx1SZHJ4eWVjesK3qW7eN99vsjI g1NN9bnJPDeJTg7nFSqvbJleZHFG1VstEl15+Tv/CfF9yf4Bk1oL5WrvTUt1XhI2Wy558lYV v0eNy/4vXJouocRSnJFoqMVcVJwIAEh+tErbAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrMIsWRmVeSWpSXmKPExsVy+t9jAd0L9eqRBpfOslvcWneO1aL33Ekm i/fLehgt5h8Bcq98fc9m8X55F5vFm7drmCxe3LvIYtH/+DWzxfnzG9gtNj2+xmpxedccNosZ 5/cxWSy9fpHJonXvEXaLGZNfslm8/HiCxUHQY828NYwem1Z1snls//aA1eN+93Emj81L6j22 9N9l9+jbsorR4/MmuQCOKDebjNTElNQihdS85PyUzLx0W6XQEDddCyWFvMTcVFulCF3fkCAl hbLEnFIgz8gADTg4B7gHK+nbJbhlbD/4lKlgNmfF17kX2RoYT7B3MXJwSAiYSMw97drFyAlk iklcuLeerYuRi0NIYBujRNOCBhaQBK+AoMSPyfdYQOqZBeQljlzKhjDVJaZMyYUof8Ao8Wrn ITaIci2JjfOmsoLYLAKqEo8bz7CD2GxA9sQV99lAekUFIiS6T1SChEUE3jNK/NgqAjKHWeA6 o8Snt+vB5ggLBEjMn/+MGWLBHEaJ7bf6mEESnALuEi9nr2CewCgwC8l5sxDOm4Vw3gJG5lWM XKkFxbnpucVGBUabGIERvO2wVsAOxqZz0YcYBTgYlXh4PVLUI4VYE8uKK3MPMUpwMCuJ8G5N BwrxpiRWVqUW5ccXleakFh9iNAX6aCKzlGhyPjC55JXEG5pYGpkYmJkZGhkYmymJ804I/BIh JJCeWJKanZpakFoE08fEwSnVwChnOCP5Lk/Xf4lM66Xe8yXfc/Zs2CAud9U0Q1wpPVbPnK2m 6fX+fUU/1WOPuZca5a726eJ50rQjp952dYn1zwnsZude3/g3sWXmRvPQP13RSRrCWgvmbnhz 9fc8gV5j9t266jfzKvz2P5iUtYt7TW7UmROMXAo3D2TOYXVdX3qjbiPPq5U8SUosxRmJhlrM RcWJAK0ieXf2AgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170526010728epcas5p184cbfc1db4705aff36e144271c53f056 X-Msg-Generator: CA X-Sender-IP: 182.195.42.80 X-Local-Sender: =?UTF-8?B?64yA7J246riwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbU2VuaW9yIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?SW5raSBEYWUbVGl6ZW4gUGxhdGZvcm0gTGFiLhtTYW1zdW5n?= =?UTF-8?B?IEVsZWN0cm9uaWNzG1NlbmlvciBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG1RFTEUbQzEwVjgxMTE=?= CMS-TYPE: 105P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20170526010217epcas1p3bfb8d9f733bcdafb4209d917fdf28dd8 X-RootMTR: 20170526010217epcas1p3bfb8d9f733bcdafb4209d917fdf28dd8 References: <1495760521-330-1-git-send-email-hoegeun.kwon@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2017년 05월 26일 10:02에 Hoegeun Kwon 이(가) 쓴 글: > Since bridge node is referenced during in the probe, it should be > released on removal. > > Suggested-by: Andrzej Hajda > Signed-off-by: Hoegeun Kwon > --- > Hi Inki, > > This patch seems to have been forgotten... :) Yeah, forgot this. Merged. Thanks, Inki Dae > > Changes for V2: > > - Checked for rebase 4.12-rc2 > > Best regards, > Hoegeun > > drivers/gpu/drm/exynos/exynos_drm_dsi.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c > index 698a824..a11b795 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c > @@ -1805,6 +1805,10 @@ static int exynos_dsi_probe(struct platform_device *pdev) > > static int exynos_dsi_remove(struct platform_device *pdev) > { > + struct exynos_dsi *dsi = platform_get_drvdata(pdev); > + > + of_node_put(dsi->bridge_node); > + > pm_runtime_disable(&pdev->dev); > > component_del(&pdev->dev, &exynos_dsi_component_ops); >