From mboxrd@z Thu Jan 1 00:00:00 1970 From: laurentiu.tudor@nxp.com (Laurentiu Tudor) Date: Fri, 26 May 2017 13:19:53 +0000 Subject: [PATCH 1/5][v2] staging: fsl-mc: fix several checkpath.pl warnings In-Reply-To: <20170525165844.GA8812@kroah.com> References: <20170522120935.4119-1-laurentiu.tudor@nxp.com> <20170522120935.4119-2-laurentiu.tudor@nxp.com> <20170525165844.GA8812@kroah.com> Message-ID: <59282B78.1010709@nxp.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Greg, On 05/25/2017 07:58 PM, Greg KH wrote: > On Mon, May 22, 2017 at 03:09:31PM +0300, laurentiu.tudor at nxp.com wrote: >> From: Laurentiu Tudor > > Your subject line is very odd, please use the 'v2' marking properly... > >> >> Remove several unneeded #includes, forward >> declarations and fix several issues reported >> by checkpatch.pl --strict, such as: >> - kfree(NULL) is safe and check is not required >> - macro argument reuse may cause possible side effects >> - enclose macro params in parens to avoid precedence issues >> - coding style > > These, as always, need to be broken up into one-patch-per-type-of-thing, > you have been in the staging tree long enough to know this :( Sorry about that. Will take care of all your comments in the next respin. --- Thanks & Best Regards, Laurentiu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1947840AbdEZNUD (ORCPT ); Fri, 26 May 2017 09:20:03 -0400 Received: from mail-db5eur01on0055.outbound.protection.outlook.com ([104.47.2.55]:64688 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S934085AbdEZNT7 (ORCPT ); Fri, 26 May 2017 09:19:59 -0400 From: Laurentiu Tudor To: Greg KH CC: "stuyoder@gmail.com" , "devel@driverdev.osuosl.org" , "arnd@arndb.de" , Roy Pledge , "linux-kernel@vger.kernel.org" , "agraf@suse.de" , "Catalin Horghidan" , Ioana Ciornei , Leo Li , Bharat Bhushan , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH 1/5][v2] staging: fsl-mc: fix several checkpath.pl warnings Thread-Topic: [PATCH 1/5][v2] staging: fsl-mc: fix several checkpath.pl warnings Thread-Index: AQHS0vRS2H8K/6ye4kOaupGOGPfaRaIFSm0AgAFVLgA= Date: Fri, 26 May 2017 13:19:53 +0000 Message-ID: <59282B78.1010709@nxp.com> References: <20170522120935.4119-1-laurentiu.tudor@nxp.com> <20170522120935.4119-2-laurentiu.tudor@nxp.com> <20170525165844.GA8812@kroah.com> In-Reply-To: <20170525165844.GA8812@kroah.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: linuxfoundation.org; dkim=none (message not signed) header.d=none;linuxfoundation.org; dmarc=none action=none header.from=nxp.com; x-originating-ip: [192.88.146.1] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;VI1PR0401MB1727;7:+NaW+vxw0PK7vEWQ0e6uCfGDGby3jVR0jSp2MdiF6TR2Rf5uDiWL8maAm7pqtQiCnSHGEjLcVpwjeiO5chT+EDthOMhIsSRnYgPiOBOKRYkLI0Guw2zymT/cuLscF6wL4BPJYgMWBl9O8zGDmZqL1LWwHWWV0Iy9JyVCGQW0eHlUltNTnPpEADVVv9ox9v/2E2nOssiaD8RaseC+qBmqnk4+xsSgjTF/tY2JvImuuRX09DY2sXE3sqZVBp7KZJE3VN6gXF8Z3vW62GyQnqxxiypwhRXAKzaPIEuTuTTgdOIPRFLZK5XVkJ/gIgk2P5s2uTMvn/CRQ7lCNvXujxYiFg== x-forefront-antispam-report: SFV:SKI;SCL:-1SFV:NSPM;SFS:(10009020)(6009001)(39450400003)(39860400002)(39410400002)(39400400002)(39840400002)(39850400002)(43544003)(24454002)(377454003)(189998001)(54356999)(2950100002)(6916009)(65816999)(50986999)(87266999)(76176999)(99136001)(3660700001)(81166006)(8676002)(33656002)(5660300001)(2900100001)(6436002)(6486002)(6506006)(3280700002)(229853002)(478600001)(8936002)(110136004)(6246003)(2906002)(38730400002)(39060400002)(7736002)(99286003)(305945005)(54906002)(66066001)(53936002)(59896002)(25786009)(53546009)(6512007)(5250100002)(86362001)(102836003)(6116002)(80316001)(3846002)(36756003)(4326008)(14454004);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR0401MB1727;H:VI1PR0401MB1856.eurprd04.prod.outlook.com;FPR:;SPF:None;MLV:ovrnspm;PTR:InfoNoRecords;LANG:en; x-ms-traffictypediagnostic: VI1PR0401MB1727: x-ms-office365-filtering-correlation-id: 05292f2f-a55b-4f2f-ce20-08d4a439e5a4 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081)(201702281549075);SRVR:VI1PR0401MB1727; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3002001)(6055026)(6041248)(20161123560025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123564025)(20161123562025)(6072148);SRVR:VI1PR0401MB1727;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0401MB1727; x-forefront-prvs: 031996B7EF spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="Windows-1252" Content-ID: <7AEED48B31D6C2449938B81CFA58932A@eurprd04.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 26 May 2017 13:19:53.7625 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB1727 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v4QDLQNx004331 Hi Greg, On 05/25/2017 07:58 PM, Greg KH wrote: > On Mon, May 22, 2017 at 03:09:31PM +0300, laurentiu.tudor@nxp.com wrote: >> From: Laurentiu Tudor > > Your subject line is very odd, please use the 'v2' marking properly... > >> >> Remove several unneeded #includes, forward >> declarations and fix several issues reported >> by checkpatch.pl --strict, such as: >> - kfree(NULL) is safe and check is not required >> - macro argument reuse may cause possible side effects >> - enclose macro params in parens to avoid precedence issues >> - coding style > > These, as always, need to be broken up into one-patch-per-type-of-thing, > you have been in the staging tree long enough to know this :( Sorry about that. Will take care of all your comments in the next respin. --- Thanks & Best Regards, Laurentiu