From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751962AbdE0EwT (ORCPT ); Sat, 27 May 2017 00:52:19 -0400 Received: from regular1.263xmail.com ([211.150.99.132]:44631 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751322AbdE0EwR (ORCPT ); Sat, 27 May 2017 00:52:17 -0400 X-263anti-spam: KSV:0;BIG:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ADDR-CHECKED4: 1 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ANTISPAM-LEVEL: 2 X-RL-SENDER: jeffy.chen@rock-chips.com X-FST-TO: tglx@linutronix.de X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: jeffy.chen@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <592905F7.4010803@rock-chips.com> Date: Sat, 27 May 2017 12:52:07 +0800 From: jeffy User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:19.0) Gecko/20130126 Thunderbird/19.0 MIME-Version: 1.0 To: Thomas Gleixner CC: linux-kernel@vger.kernel.org, briannorris@chromium.org, dianders@chromium.org, tfiga@chromium.org Subject: Re: [PATCH] genirq: Check irq disabled & masked states in irq_shutdown References: <1495804658-12410-1-git-send-email-jeffy.chen@rock-chips.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Thomas, On 05/26/2017 09:20 PM, Thomas Gleixner wrote: > On Fri, 26 May 2017, Jeffy Chen wrote: > >> If irq is already disabled and masked, we would hit a unbalanced irq >> shutdown/disable/mask when freeing it. > > Errr? What exactly is unbalanced? None of the called functions has any > counter or whatever. > > Can you please explain what you are trying to fix? sorry, i'll try to rewrite the commit message. for example when a driver(drivers/net/wireless/marvell/mwifiex/main.c) try to do these: devm_request_irq->irq_startup->irq_enable disable_irq <-- disabled and masked devm_free_irq->irq_shutdown <-- disable it again and the pinctrl-rockchip driver would enable/disable gpio clk in irq_enable/irq_disable, so it would try to disable a disabled clk(due to unbalanced irq disable) > > Thanks, > > tglx > > >