From mboxrd@z Thu Jan 1 00:00:00 1970 From: jeffy Subject: Re: [PATCH v11] drm: Unplug drm device when unregistering it (v8) Date: Wed, 31 May 2017 10:39:13 +0800 Message-ID: <592E2CD1.8080206@rock-chips.com> References: <1492068764-24353-1-git-send-email-jeffy.chen@rock-chips.com> <20170414151503.lmpp3udfuycavfki@art_vandelay> <20170529202512.GF23936@nuc-i3427.alporthouse.com> <47c5eca2-3624-edbc-bb2d-453645b6bf3b@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from regular1.263xmail.com (regular1.263xmail.com [211.150.99.131]) by gabe.freedesktop.org (Postfix) with ESMTPS id A41156E158 for ; Wed, 31 May 2017 02:40:14 +0000 (UTC) In-Reply-To: <47c5eca2-3624-edbc-bb2d-453645b6bf3b@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Hans de Goede , Chris Wilson , Sean Paul , linux-kernel@vger.kernel.org, briannorris@chromium.org, dianders@chromium.org, tfiga@chromium.org, zyw@rock-chips.com, marcheu@chromium.org, mark.yao@rock-chips.com, hshi@chromium.org, Daniel Vetter , Jani Nikula , dri-devel@lists.freedesktop.org, David Airlie , Tom Gundersen , =?UTF-8?B?TWFyY28gRGllZ28gQXVyw6lsaW8gTWVzcXVpdGE=?= , Patrik Jakobsson , Dave Airlie List-Id: dri-devel@lists.freedesktop.org SGkgSGFucywKCnRoYW54IGZvciBpbnZlc3RpZ2F0aW5nIDopCgpPbiAwNS8zMC8yMDE3IDAzOjA2 IFBNLCBIYW5zIGRlIEdvZWRlIHdyb3RlOgo+IEhpLAo+Cj4gT24gMjktMDUtMTcgMjI6MjUsIENo cmlzIFdpbHNvbiB3cm90ZToKPj4gT24gRnJpLCBBcHIgMTQsIDIwMTcgYXQgMTE6MTU6MDRBTSAt MDQwMCwgU2VhbiBQYXVsIHdyb3RlOgo+Pj4gT24gVGh1LCBBcHIgMTMsIDIwMTcgYXQgMDM6MzI6 NDRQTSArMDgwMCwgSmVmZnkgQ2hlbiB3cm90ZToKPj4+PiBBZnRlciB1bmJpbmRpbmcgZHJtLCB0 aGUgdXNlciBzcGFjZSBtYXkgc3RpbGwgb3ducyB0aGUgZHJtIGRldiBmZCwgYW5kCj4+Pj4gbWF5 IHN0aWxsIGJlIGFibGUgdG8gY2FsbCBkcm0gaW9jdGwuCj4+Pj4KPj4+PiBXZSdyZSB1c2luZyBh biB1bnBsdWdnZWQgc3RhdGUgdG8gcHJldmVudCBzb21ldGhpbmcgbGlrZSB0aGF0LCBzbyBsZXQn cwo+Pj4+IHJldXNlIGl0IGhlcmUuCj4+Pj4KPj4+PiBBbHNvIGRyb3AgZHJtX3VucGx1Z19kZXYs IGJlY2F1c2UgaXQgd291bGQgYmUgdW51c2VkIGFmdGVyIG90aGVyCj4+Pj4gY2hhbmdlcy4KPj4+ Pgo+Pj4+IFZlcmlmaWVkIG9uIHJrMzM5OSBjaHJvbWVib29rIGtldmluKHdpdGggY3JvcyA0LjQg a2VybmVsKSwgbm8gbW9yZQo+Pj4+IGNyYXNoZXMKPj4+PiB3aGVuIHVuYmluZGluZyBkcm0gd2l0 aCB1aSBzZXJ2aWNlIHN0aWxsIHJ1bm5pbmcuCj4+Pj4KPj4+PiB2MjogRml4IHNvbWUgY29tbWl0 IG1lc3NhZ2VzLgo+Pj4+IHYzOiBSZXVzZSB1bnBsdWcgc3RhdHVzLgo+Pj4+IHY0OiBBZGQgZHJt X2RldmljZV9zZXRfcGx1Z19zdGF0ZSBoZWxwZXIuCj4+Pj4gdjU6IEZpeCBoYW5nIHdoZW4gdW5y ZWdpc3RlcmluZyBkcm0gZGV2IHdpdGggb3Blbl9jb3VudCAwLgo+Pj4+IHY2OiBNb3ZlIGRybV9k ZXZpY2Vfc2V0X3BsdWdfc3RhdGUgaW50byBkcm1fZHJ2Lgo+Pj4+IHY3OiBBZGQgbWlzc2luZyBk cm1fZGV2X3VucmVmIGluIHVkbF9kcnYuCj4+Pj4gdjg6IEZpeCBjb21waWxlciBlcnJvcnMgYWZ0 ZXIgZW5hYmxlIHVkbC4KPj4+Pgo+Pj4+IFNpZ25lZC1vZmYtYnk6IEplZmZ5IENoZW4gPGplZmZ5 LmNoZW5Acm9jay1jaGlwcy5jb20+Cj4+Pj4KPj4+PiAtLS0KPj4+Cj4+PiBIaSBKZWZmeSwKPj4+ IEdpdmVuIHRoZSB0cm91YmxlIHdlJ3ZlIGhhZCB3aXRoIHRoaXMgcGF0Y2ggYWxyZWFkeSwgY291 cGxlZCB3aXRoIHRoZQo+Pj4gZmFjdCB0aGF0Cj4+PiB1bmJpbmRpbmcgd2hpbGUgdXNlcnNwYWNl IGlzIGFjdGl2ZSBpcyBhIGNvbnRyaXZlZC9wYXRob2xvZ2ljYWwgY2FzZSwKPj4+IEkgZG9uJ3QK Pj4+IHRoaW5rIGl0J3Mgd29ydGggcGlja2luZyB0aGlzIHBhdGNoIHVwc3RyZWFtLgo+Pj4KPj4+ IElmIGl0J3MgcmVhbGx5IGNhdXNpbmcgaXNzdWVzIGRvd25zdHJlYW0sIHlvdSBjYW4gYWRkIG15 IFJldmlld2VkLWJ5Cj4+PiBmb3IgYSBDSFJPTUlVTQo+Pj4gcGF0Y2gsIGJ1dCBJJ2QgcmF0aGVy IG5vdCBjYXJyeSBwYXRjaGVzIGluIHRoZSBDck9TIHJlcG8gaWYgd2UgZG9uJ3QKPj4+IG5lZWQg dG8uCj4+Cj4+IFdvdWxkIGEKPj4KPj4gRml4ZXM6IGEzOWJlNjA2Zjk5ZCAoImRybTogRG8gYSBm dWxsIGRldmljZSB1bnJlZ2lzdGVyIHdoZW4gdW5wbHVnZ2luZyIpCj4+IFJlcG9ydGVkLWJ5OiBN YXJjbyBEaWVnbyBBdXLDqWxpbyBNZXNxdWl0YSA8bWFyY29kaWVnb21lc3F1aXRhQGdtYWlsLmNv bT4KPj4gQ2M6IEhhbnMgZGUgR29lZGUgPGhkZWdvZWRlQHJlZGhhdC5jb20+Cj4+Cj4+IGNvbnZp bmNlIHVzIHRvIGxvb2sgaW50byB0aGlzIHBhdGNoIGFnYWluPwo+Cj4gVGhlIHByb2JsZW0gaXMg dGhpcyBwYXRjaCBpcyB3cm9uZywgc2VlIGJlbG93Lgo+Cj4+Pj4gICBkcml2ZXJzL2dwdS9kcm0v ZHJtX2Rydi5jICAgICB8IDI2ICsrKysrKysrKystLS0tLS0tLS0tLS0tLS0tCj4+Pj4gICBkcml2 ZXJzL2dwdS9kcm0vdWRsL3VkbF9kcnYuYyB8ICAzICsrLQo+Pj4+ICAgaW5jbHVkZS9kcm0vZHJt UC5oICAgICAgICAgICAgfCAgNiAtLS0tLS0KPj4+PiAgIGluY2x1ZGUvZHJtL2RybV9kcnYuaCAg ICAgICAgIHwgIDEgLQo+Pj4+ICAgNCBmaWxlcyBjaGFuZ2VkLCAxMiBpbnNlcnRpb25zKCspLCAy NCBkZWxldGlvbnMoLSkKPj4+Pgo+Pj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJt X2Rydi5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9kcnYuYwo+Pj4+IGluZGV4IGI1YzZiYjQuLmUx ZGE0ZDEgMTAwNjQ0Cj4+Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9kcnYuYwo+Pj4+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZHJ2LmMKPj4+PiBAQCAtMzU1LDIyICszNTUsNiBAQCB2 b2lkIGRybV9wdXRfZGV2KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4+Pj4gICB9Cj4+Pj4gICBF WFBPUlRfU1lNQk9MKGRybV9wdXRfZGV2KTsKPj4+PiAtdm9pZCBkcm1fdW5wbHVnX2RldihzdHJ1 Y3QgZHJtX2RldmljZSAqZGV2KQo+Pj4+IC17Cj4+Pj4gLSAgICAvKiBmb3IgYSBVU0IgZGV2aWNl ICovCj4+Pj4gLSAgICBkcm1fZGV2X3VucmVnaXN0ZXIoZGV2KTsKPj4+PiAtCj4+Pj4gLSAgICBt dXRleF9sb2NrKCZkcm1fZ2xvYmFsX211dGV4KTsKPj4+PiAtCj4+Pj4gLSAgICBkcm1fZGV2aWNl X3NldF91bnBsdWdnZWQoZGV2KTsKPj4+PiAtCj4+Pj4gLSAgICBpZiAoZGV2LT5vcGVuX2NvdW50 ID09IDApIHsKPj4+PiAtICAgICAgICBkcm1fcHV0X2RldihkZXYpOwo+Pj4+IC0gICAgfQo+Pj4+ IC0gICAgbXV0ZXhfdW5sb2NrKCZkcm1fZ2xvYmFsX211dGV4KTsKPj4+PiAtfQo+Pj4+IC1FWFBP UlRfU1lNQk9MKGRybV91bnBsdWdfZGV2KTsKPj4+PiAtCj4+Pj4gICAvKgo+Pj4+ICAgICogRFJN IGludGVybmFsIG1vdW50Cj4+Pj4gICAgKiBXZSB3YW50IHRvIGJlIGFibGUgdG8gYWxsb2NhdGUg b3VyIG93biAic3RydWN0IGFkZHJlc3Nfc3BhY2UiCj4+Pj4gdG8gY29udHJvbAo+Pj4+IEBAIC03 MzMsNiArNzE3LDEzIEBAIHN0YXRpYyB2b2lkIHJlbW92ZV9jb21wYXRfY29udHJvbF9saW5rKHN0 cnVjdAo+Pj4+IGRybV9kZXZpY2UgKmRldikKPj4+PiAgICAgICBrZnJlZShuYW1lKTsKPj4+PiAg IH0KPj4+PiArc3RhdGljIGlubGluZSB2b2lkIGRybV9kZXZpY2Vfc2V0X3BsdWdfc3RhdGUoc3Ry dWN0IGRybV9kZXZpY2UgKmRldiwKPj4+PiArICAgICAgICAgICAgICAgICAgICAgICAgIGJvb2wg cGx1Z2dlZCkKPj4+PiArewo+Pj4+ICsgICAgc21wX3dtYigpOwo+Pj4+ICsgICAgYXRvbWljX3Nl dCgmZGV2LT51bnBsdWdnZWQsICFwbHVnZ2VkKTsKPj4+PiArfQo+Pj4+ICsKPj4+PiAgIC8qKgo+ Pj4+ICAgICogZHJtX2Rldl9yZWdpc3RlciAtIFJlZ2lzdGVyIERSTSBkZXZpY2UKPj4+PiAgICAq IEBkZXY6IERldmljZSB0byByZWdpc3Rlcgo+Pj4+IEBAIC03ODcsNiArNzc4LDggQEAgaW50IGRy bV9kZXZfcmVnaXN0ZXIoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPj4+PiB1bnNpZ25lZCBsb25n IGZsYWdzKQo+Pj4+ICAgICAgIGlmIChkcm1fY29yZV9jaGVja19mZWF0dXJlKGRldiwgRFJJVkVS X01PREVTRVQpKQo+Pj4+ICAgICAgICAgICBkcm1fbW9kZXNldF9yZWdpc3Rlcl9hbGwoZGV2KTsK Pj4+PiArICAgIGRybV9kZXZpY2Vfc2V0X3BsdWdfc3RhdGUoZGV2LCB0cnVlKTsKPj4+PiArCj4+ Pj4gICAgICAgcmV0ID0gMDsKPj4+PiAgICAgICBEUk1fSU5GTygiSW5pdGlhbGl6ZWQgJXMgJWQu JWQuJWQgJXMgZm9yICVzIG9uIG1pbm9yICVkXG4iLAo+Pj4+IEBAIC04MjYsNiArODE5LDcgQEAg dm9pZCBkcm1fZGV2X3VucmVnaXN0ZXIoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPj4+PiAgICAg ICBkcm1fbGFzdGNsb3NlKGRldik7Cj4+Pj4gICAgICAgZGV2LT5yZWdpc3RlcmVkID0gZmFsc2U7 Cj4+Pj4gKyAgICBkcm1fZGV2aWNlX3NldF9wbHVnX3N0YXRlKGRldiwgZmFsc2UpOwo+Pj4+ICAg ICAgIGlmIChkcm1fY29yZV9jaGVja19mZWF0dXJlKGRldiwgRFJJVkVSX01PREVTRVQpKQo+Pj4+ ICAgICAgICAgICBkcm1fbW9kZXNldF91bnJlZ2lzdGVyX2FsbChkZXYpOwo+Pj4+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vdWRsL3VkbF9kcnYuYwo+Pj4+IGIvZHJpdmVycy9ncHUvZHJt L3VkbC91ZGxfZHJ2LmMKPj4+PiBpbmRleCBjZDhiMDE3Li5mYzczZTI0IDEwMDY0NAo+Pj4+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS91ZGwvdWRsX2Rydi5jCj4+Pj4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL3VkbC91ZGxfZHJ2LmMKPj4+PiBAQCAtMTA4LDcgKzEwOCw4IEBAIHN0YXRpYyB2b2lkIHVk bF91c2JfZGlzY29ubmVjdChzdHJ1Y3QKPj4+PiB1c2JfaW50ZXJmYWNlICppbnRlcmZhY2UpCj4+ Pj4gICAgICAgZHJtX2ttc19oZWxwZXJfcG9sbF9kaXNhYmxlKGRldik7Cj4+Pj4gICAgICAgdWRs X2ZiZGV2X3VucGx1ZyhkZXYpOwo+Pj4+ICAgICAgIHVkbF9kcm9wX3VzYihkZXYpOwo+Pj4+IC0g ICAgZHJtX3VucGx1Z19kZXYoZGV2KTsKPj4+PiArICAgIGRybV9kZXZfdW5yZWdpc3RlcihkZXYp Owo+Pj4+ICsgICAgZHJtX2Rldl91bnJlZihkZXYpOwo+Cj4gVGhlIHVucmVmIGhlcmUgd2lsbCBj YXVzZSB0aGUgZGV2aWNlIHN0cnVjdCB0byBnZXQgZnJlZS1lZCBldmVuIGlmCj4gdXNlcnNwYWNl IHN0aWxsIGhvbGRzIHJlZmVyZW5jZXMgdG8gaXQgdGhyb3VnaCB0aGUgZHJtX2Rldi4gVG8gZml4 Cj4gdGhpcyB3ZSB3b3VsZCBuZWVkIHRvIGNhbGwgZHJtX2Rldl9yZWYgb24gYSBvcGVuIGZyb20g dXNlcnNwYWNlIGFuZAo+IGRybV9kZXZfdW5yZWYgZnJvbSBkcm1fcmVsZWFzZS4KCnJpZ2h0LCBi dXQgaSB0aGluayB3ZSBhcmUgYWxyZWFkeSBkaWQgdGhlIHJlZi91bnJlZiBpbiB0aGUgb3Blbi9y ZWxlYXNlIAp0aHJvdWdoIGRybV9taW5vcl9hY3F1aXJlL2RybV9taW5vcl9yZWxlYXNlLgoKaSB0 aGluayB0aGUgcHJvYmxlbSB3b3VsZCBiZToKMS8gd2UgYXJlIHRyeWluZyB0byB1bnJlZ2lzdGVy JnVucmVmIHdoZW4gZGlzY29ubmVjdGVkCgoyLyB0aGUgZHJtX3JlbGVhc2Ugd291bGQgdHJ5IHRv IHVucmVnaXN0ZXImdW5yZWYoYnkgY2FsbGluZyBkcm1fcHV0X2RldikgCndoZW4gZm91bmQgaXQg dW5wbHVnZ2VkLgoKYW5kIHlvdXIgcGF0Y2ggImRybTogRG8gbm90IGNhbGwgZHJtX2Rldl91bnJl Z2lzdGVyIHR3aWNlIG9uIApkcm1fdW5wbHVnX2RldiIgbG9va3MgbGlrZSBhIGdvb2Qgd2F5IHRv IGZpeCB0aGlzKHRvIG1lKSwgbWF5YmUgd2UgY2FuIApwbGFjZSB0aGlzIHBhdGNoIGFmdGVyIHlv dXJzLCBhbmQgY2hlY2sgZm9yIG9wZW5fY291bnQgaGVyZT8KCi0gICAgZHJtX3VucGx1Z19kZXYo ZGV2KTsKKyAgICBpZiAoZGV2LT5vcGVuX2NvdW50ID09IDApCisgICAgICAgIGRybV9kZXZfdW5y ZWYoZGV2KTsKCgo+Cj4gUmVnYXJkcywKPgo+IEhhbnMKPgo+Cj4KPgo+Pj4+ICAgfQo+Pj4+ICAg LyoKPj4+PiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9kcm0vZHJtUC5oIGIvaW5jbHVkZS9kcm0vZHJt UC5oCj4+Pj4gaW5kZXggM2JmYWZjZC4uOTgwYTIwNCAxMDA2NDQKPj4+PiAtLS0gYS9pbmNsdWRl L2RybS9kcm1QLmgKPj4+PiArKysgYi9pbmNsdWRlL2RybS9kcm1QLmgKPj4+PiBAQCAtNDg4LDEy ICs0ODgsNiBAQCBzdGF0aWMgX19pbmxpbmVfXyBpbnQKPj4+PiBkcm1fY29yZV9jaGVja19mZWF0 dXJlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4+Pj4gICAgICAgcmV0dXJuICgoZGV2LT5kcml2 ZXItPmRyaXZlcl9mZWF0dXJlcyAmIGZlYXR1cmUpID8gMSA6IDApOwo+Pj4+ICAgfQo+Pj4+IC1z dGF0aWMgaW5saW5lIHZvaWQgZHJtX2RldmljZV9zZXRfdW5wbHVnZ2VkKHN0cnVjdCBkcm1fZGV2 aWNlICpkZXYpCj4+Pj4gLXsKPj4+PiAtICAgIHNtcF93bWIoKTsKPj4+PiAtICAgIGF0b21pY19z ZXQoJmRldi0+dW5wbHVnZ2VkLCAxKTsKPj4+PiAtfQo+Pj4+IC0KPj4+PiAgIHN0YXRpYyBpbmxp bmUgaW50IGRybV9kZXZpY2VfaXNfdW5wbHVnZ2VkKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4+ Pj4gICB7Cj4+Pj4gICAgICAgaW50IHJldCA9IGF0b21pY19yZWFkKCZkZXYtPnVucGx1Z2dlZCk7 Cj4+Pj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvZHJtL2RybV9kcnYuaCBiL2luY2x1ZGUvZHJtL2Ry bV9kcnYuaAo+Pj4+IGluZGV4IDBmZWZjM2YuLmViNjMwNzggMTAwNjQ0Cj4+Pj4gLS0tIGEvaW5j bHVkZS9kcm0vZHJtX2Rydi5oCj4+Pj4gKysrIGIvaW5jbHVkZS9kcm0vZHJtX2Rydi5oCj4+Pj4g QEAgLTU0NCw3ICs1NDQsNiBAQCB2b2lkIGRybV9kZXZfdW5yZWdpc3RlcihzdHJ1Y3QgZHJtX2Rl dmljZSAqZGV2KTsKPj4+PiAgIHZvaWQgZHJtX2Rldl9yZWYoc3RydWN0IGRybV9kZXZpY2UgKmRl dik7Cj4+Pj4gICB2b2lkIGRybV9kZXZfdW5yZWYoc3RydWN0IGRybV9kZXZpY2UgKmRldik7Cj4+ Pj4gICB2b2lkIGRybV9wdXRfZGV2KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpOwo+Pj4+IC12b2lk IGRybV91bnBsdWdfZGV2KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpOwo+Pj4+ICAgaW50IGRybV9k ZXZfc2V0X3VuaXF1ZShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCBjb25zdCBjaGFyICpuYW1lKTsK Pj4KPgo+Cj4KCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751076AbdEaCkU (ORCPT ); Tue, 30 May 2017 22:40:20 -0400 Received: from regular1.263xmail.com ([211.150.99.131]:34219 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750811AbdEaCkT (ORCPT ); Tue, 30 May 2017 22:40:19 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: jeffy.chen@rock-chips.com X-FST-TO: hdegoede@redhat.com X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: jeffy.chen@rock-chips.com X-UNIQUE-TAG: <5dfb4eff35a1530252e062213e353e62> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <592E2CD1.8080206@rock-chips.com> Date: Wed, 31 May 2017 10:39:13 +0800 From: jeffy User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:19.0) Gecko/20130126 Thunderbird/19.0 MIME-Version: 1.0 To: Hans de Goede , Chris Wilson , Sean Paul , linux-kernel@vger.kernel.org, briannorris@chromium.org, dianders@chromium.org, tfiga@chromium.org, zyw@rock-chips.com, marcheu@chromium.org, mark.yao@rock-chips.com, hshi@chromium.org, Daniel Vetter , Jani Nikula , dri-devel@lists.freedesktop.org, David Airlie , Tom Gundersen , =?UTF-8?B?TWFyY28gRGllZ28gQXVyw6lsaW8gTWVzcXVpdGE=?= , Patrik Jakobsson , Dave Airlie Subject: Re: [PATCH v11] drm: Unplug drm device when unregistering it (v8) References: <1492068764-24353-1-git-send-email-jeffy.chen@rock-chips.com> <20170414151503.lmpp3udfuycavfki@art_vandelay> <20170529202512.GF23936@nuc-i3427.alporthouse.com> <47c5eca2-3624-edbc-bb2d-453645b6bf3b@redhat.com> In-Reply-To: <47c5eca2-3624-edbc-bb2d-453645b6bf3b@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Hans, thanx for investigating :) On 05/30/2017 03:06 PM, Hans de Goede wrote: > Hi, > > On 29-05-17 22:25, Chris Wilson wrote: >> On Fri, Apr 14, 2017 at 11:15:04AM -0400, Sean Paul wrote: >>> On Thu, Apr 13, 2017 at 03:32:44PM +0800, Jeffy Chen wrote: >>>> After unbinding drm, the user space may still owns the drm dev fd, and >>>> may still be able to call drm ioctl. >>>> >>>> We're using an unplugged state to prevent something like that, so let's >>>> reuse it here. >>>> >>>> Also drop drm_unplug_dev, because it would be unused after other >>>> changes. >>>> >>>> Verified on rk3399 chromebook kevin(with cros 4.4 kernel), no more >>>> crashes >>>> when unbinding drm with ui service still running. >>>> >>>> v2: Fix some commit messages. >>>> v3: Reuse unplug status. >>>> v4: Add drm_device_set_plug_state helper. >>>> v5: Fix hang when unregistering drm dev with open_count 0. >>>> v6: Move drm_device_set_plug_state into drm_drv. >>>> v7: Add missing drm_dev_unref in udl_drv. >>>> v8: Fix compiler errors after enable udl. >>>> >>>> Signed-off-by: Jeffy Chen >>>> >>>> --- >>> >>> Hi Jeffy, >>> Given the trouble we've had with this patch already, coupled with the >>> fact that >>> unbinding while userspace is active is a contrived/pathological case, >>> I don't >>> think it's worth picking this patch upstream. >>> >>> If it's really causing issues downstream, you can add my Reviewed-by >>> for a CHROMIUM >>> patch, but I'd rather not carry patches in the CrOS repo if we don't >>> need to. >> >> Would a >> >> Fixes: a39be606f99d ("drm: Do a full device unregister when unplugging") >> Reported-by: Marco Diego Aurélio Mesquita >> Cc: Hans de Goede >> >> convince us to look into this patch again? > > The problem is this patch is wrong, see below. > >>>> drivers/gpu/drm/drm_drv.c | 26 ++++++++++---------------- >>>> drivers/gpu/drm/udl/udl_drv.c | 3 ++- >>>> include/drm/drmP.h | 6 ------ >>>> include/drm/drm_drv.h | 1 - >>>> 4 files changed, 12 insertions(+), 24 deletions(-) >>>> >>>> diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c >>>> index b5c6bb4..e1da4d1 100644 >>>> --- a/drivers/gpu/drm/drm_drv.c >>>> +++ b/drivers/gpu/drm/drm_drv.c >>>> @@ -355,22 +355,6 @@ void drm_put_dev(struct drm_device *dev) >>>> } >>>> EXPORT_SYMBOL(drm_put_dev); >>>> -void drm_unplug_dev(struct drm_device *dev) >>>> -{ >>>> - /* for a USB device */ >>>> - drm_dev_unregister(dev); >>>> - >>>> - mutex_lock(&drm_global_mutex); >>>> - >>>> - drm_device_set_unplugged(dev); >>>> - >>>> - if (dev->open_count == 0) { >>>> - drm_put_dev(dev); >>>> - } >>>> - mutex_unlock(&drm_global_mutex); >>>> -} >>>> -EXPORT_SYMBOL(drm_unplug_dev); >>>> - >>>> /* >>>> * DRM internal mount >>>> * We want to be able to allocate our own "struct address_space" >>>> to control >>>> @@ -733,6 +717,13 @@ static void remove_compat_control_link(struct >>>> drm_device *dev) >>>> kfree(name); >>>> } >>>> +static inline void drm_device_set_plug_state(struct drm_device *dev, >>>> + bool plugged) >>>> +{ >>>> + smp_wmb(); >>>> + atomic_set(&dev->unplugged, !plugged); >>>> +} >>>> + >>>> /** >>>> * drm_dev_register - Register DRM device >>>> * @dev: Device to register >>>> @@ -787,6 +778,8 @@ int drm_dev_register(struct drm_device *dev, >>>> unsigned long flags) >>>> if (drm_core_check_feature(dev, DRIVER_MODESET)) >>>> drm_modeset_register_all(dev); >>>> + drm_device_set_plug_state(dev, true); >>>> + >>>> ret = 0; >>>> DRM_INFO("Initialized %s %d.%d.%d %s for %s on minor %d\n", >>>> @@ -826,6 +819,7 @@ void drm_dev_unregister(struct drm_device *dev) >>>> drm_lastclose(dev); >>>> dev->registered = false; >>>> + drm_device_set_plug_state(dev, false); >>>> if (drm_core_check_feature(dev, DRIVER_MODESET)) >>>> drm_modeset_unregister_all(dev); >>>> diff --git a/drivers/gpu/drm/udl/udl_drv.c >>>> b/drivers/gpu/drm/udl/udl_drv.c >>>> index cd8b017..fc73e24 100644 >>>> --- a/drivers/gpu/drm/udl/udl_drv.c >>>> +++ b/drivers/gpu/drm/udl/udl_drv.c >>>> @@ -108,7 +108,8 @@ static void udl_usb_disconnect(struct >>>> usb_interface *interface) >>>> drm_kms_helper_poll_disable(dev); >>>> udl_fbdev_unplug(dev); >>>> udl_drop_usb(dev); >>>> - drm_unplug_dev(dev); >>>> + drm_dev_unregister(dev); >>>> + drm_dev_unref(dev); > > The unref here will cause the device struct to get free-ed even if > userspace still holds references to it through the drm_dev. To fix > this we would need to call drm_dev_ref on a open from userspace and > drm_dev_unref from drm_release. right, but i think we are already did the ref/unref in the open/release through drm_minor_acquire/drm_minor_release. i think the problem would be: 1/ we are trying to unregister&unref when disconnected 2/ the drm_release would try to unregister&unref(by calling drm_put_dev) when found it unplugged. and your patch "drm: Do not call drm_dev_unregister twice on drm_unplug_dev" looks like a good way to fix this(to me), maybe we can place this patch after yours, and check for open_count here? - drm_unplug_dev(dev); + if (dev->open_count == 0) + drm_dev_unref(dev); > > Regards, > > Hans > > > > >>>> } >>>> /* >>>> diff --git a/include/drm/drmP.h b/include/drm/drmP.h >>>> index 3bfafcd..980a204 100644 >>>> --- a/include/drm/drmP.h >>>> +++ b/include/drm/drmP.h >>>> @@ -488,12 +488,6 @@ static __inline__ int >>>> drm_core_check_feature(struct drm_device *dev, >>>> return ((dev->driver->driver_features & feature) ? 1 : 0); >>>> } >>>> -static inline void drm_device_set_unplugged(struct drm_device *dev) >>>> -{ >>>> - smp_wmb(); >>>> - atomic_set(&dev->unplugged, 1); >>>> -} >>>> - >>>> static inline int drm_device_is_unplugged(struct drm_device *dev) >>>> { >>>> int ret = atomic_read(&dev->unplugged); >>>> diff --git a/include/drm/drm_drv.h b/include/drm/drm_drv.h >>>> index 0fefc3f..eb63078 100644 >>>> --- a/include/drm/drm_drv.h >>>> +++ b/include/drm/drm_drv.h >>>> @@ -544,7 +544,6 @@ void drm_dev_unregister(struct drm_device *dev); >>>> void drm_dev_ref(struct drm_device *dev); >>>> void drm_dev_unref(struct drm_device *dev); >>>> void drm_put_dev(struct drm_device *dev); >>>> -void drm_unplug_dev(struct drm_device *dev); >>>> int drm_dev_set_unique(struct drm_device *dev, const char *name); >> > > >