From: Ping-Ke Shih <pkshih@realtek.com>
To: Thadeu Lima de Souza Cascardo <cascardo@igalia.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: Kalle Valo <kvalo@kernel.org>,
"kernel-dev@igalia.com" <kernel-dev@igalia.com>
Subject: RE: [PATCH net 2/5] wifi: rtlwifi: rtl8192se: rise completion of firmware loading as last step
Date: Fri, 8 Nov 2024 01:58:26 +0000 [thread overview]
Message-ID: <592ce269cce94d2e919ec3221bd0eefa@realtek.com> (raw)
In-Reply-To: <20241107133322.855112-3-cascardo@igalia.com>
Thadeu Lima de Souza Cascardo <cascardo@igalia.com> wrote:
> Just like in commit 4dfde294b979 ("rtlwifi: rise completion at the last
> step of firmware callback"), only signal completion once the function is
> finished. Otherwise, the module removal waiting for the completion could
> free the memory that the callback will still use before returning.
>
> Fixes: b0302aba812b ("rtlwifi: Convert to asynchronous firmware load")
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@igalia.com>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
next prev parent reply other threads:[~2024-11-08 1:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-07 13:33 [PATCH net 0/5] wifi: rtlwifi: usb probe error path fixes Thadeu Lima de Souza Cascardo
2024-11-07 13:33 ` [PATCH net 1/5] wifi: rtlwifi: do not complete firmware loading needlessly Thadeu Lima de Souza Cascardo
2024-11-08 1:57 ` Ping-Ke Shih
2024-11-18 1:55 ` Ping-Ke Shih
2024-11-07 13:33 ` [PATCH net 2/5] wifi: rtlwifi: rtl8192se: rise completion of firmware loading as last step Thadeu Lima de Souza Cascardo
2024-11-08 1:58 ` Ping-Ke Shih [this message]
2024-11-07 13:33 ` [PATCH net 3/5] wifi: rtlwifi: wait for firmware loading before releasing memory Thadeu Lima de Souza Cascardo
2024-11-08 2:12 ` Ping-Ke Shih
2024-11-08 11:05 ` Thadeu Lima de Souza Cascardo
2024-11-11 1:12 ` Ping-Ke Shih
2024-11-07 13:33 ` [PATCH net 4/5] wifi: rtlwifi: fix init_sw_vars leak when probe fails Thadeu Lima de Souza Cascardo
2024-11-08 2:14 ` Ping-Ke Shih
2024-11-07 13:33 ` [PATCH net 5/5] wifi: rtlwifi: usb: fix workqueue " Thadeu Lima de Souza Cascardo
2024-11-08 2:23 ` Ping-Ke Shih
2024-11-08 11:15 ` Thadeu Lima de Souza Cascardo
2024-11-11 2:58 ` Ping-Ke Shih
2024-11-08 1:41 ` [PATCH net 0/5] wifi: rtlwifi: usb probe error path fixes Ping-Ke Shih
2024-11-08 10:55 ` Thadeu Lima de Souza Cascardo
2024-11-11 11:33 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=592ce269cce94d2e919ec3221bd0eefa@realtek.com \
--to=pkshih@realtek.com \
--cc=cascardo@igalia.com \
--cc=kernel-dev@igalia.com \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.