From: John Fastabend <john.fastabend@gmail.com>
To: David Miller <davem@davemloft.net>, roopa@cumulusnetworks.com
Cc: netdev@vger.kernel.org, dsahern@gmail.com
Subject: Re: [PATCH net-next] ipv4: route: restore skb_dst_set in inet_rtm_getroute
Date: Thu, 01 Jun 2017 12:43:26 -0700 [thread overview]
Message-ID: <59306E5E.9050806@gmail.com> (raw)
In-Reply-To: <20170601.113429.1492311634394467957.davem@davemloft.net>
On 06/01/2017 08:34 AM, David Miller wrote:
> From: Roopa Prabhu <roopa@cumulusnetworks.com>
> Date: Wed, 31 May 2017 22:53:25 -0700
>
>> From: Roopa Prabhu <roopa@cumulusnetworks.com>
>>
>> recent updates to inet_rtm_getroute dropped skb_dst_set in
>> inet_rtm_getroute. This patch restores it because it is
>> needed to release the dst correctly.
>>
>> Fixes: 3765d35ed8b9 ("net: ipv4: Convert inet_rtm_getroute to rcu versions of route lookup")
>> Reported-by: John Fastabend <john.fastabend@gmail.com>
>> Signed-off-by: David Ahern <dsahern@gmail.com>
>> Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
>
> Applied.
>
Thanks Roopa this fixes the regression on my systems.
.John
prev parent reply other threads:[~2017-06-01 19:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-01 5:53 [PATCH net-next] ipv4: route: restore skb_dst_set in inet_rtm_getroute Roopa Prabhu
2017-06-01 15:34 ` David Miller
2017-06-01 19:43 ` John Fastabend [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59306E5E.9050806@gmail.com \
--to=john.fastabend@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.