From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2] maintainers: claim maintainership of Toeplitz hash Date: Wed, 06 Feb 2019 11:38:57 +0100 Message-ID: <5937441.0T0pBNs0GK@xps> References: <1549375057-4211-1-git-send-email-vladimir.medvedkin@intel.com> <1549375057-4211-2-git-send-email-vladimir.medvedkin@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Yipeng Wang , Sameh Gobriel , Bruce Richardson , Pablo de Lara To: Vladimir Medvedkin Return-path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id A3DB15942 for ; Wed, 6 Feb 2019 11:39:00 +0100 (CET) In-Reply-To: <1549375057-4211-2-git-send-email-vladimir.medvedkin@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 05/02/2019 14:57, Vladimir Medvedkin: > --- a/MAINTAINERS > +++ b/MAINTAINERS > +M: Vladimir Medvedkin > +F: lib/librte_hash/rte_thash.h I'm not sure about adding maintainership for one file. You are the author of this file, so you should be consulted during reviews if you don't catch them by yourself. But I prefer seeing maintainers as taking charge and understanding of a full library as a block. And unfortunately, it does not work with the script: devtools/get-maintainer.sh lib/librte_hash/rte_cuckoo_hash.h You would appear as maintainer for all hash files.