From: Menglong Dong <menglong.dong@linux.dev>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: Andrii Nakryiko <andrii@kernel.org>,
Alexei Starovoitov <ast@kernel.org>, bpf <bpf@vger.kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Eduard <eddyz87@gmail.com>, Hao Luo <haoluo@google.com>,
John Fastabend <john.fastabend@gmail.com>,
Jiri Olsa <jolsa@kernel.org>, KP Singh <kpsingh@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Martin KaFai Lau <martin.lau@linux.dev>,
Network Development <netdev@vger.kernel.org>,
Stanislav Fomichev <sdf@fomichev.me>, Song Liu <song@kernel.org>,
syzkaller-bugs <syzkaller-bugs@googlegroups.com>,
Yonghong Song <yonghong.song@linux.dev>,
syzbot <syzbot+18b26edb69b2e19f3b33@syzkaller.appspotmail.com>
Subject: Re: [syzbot] [bpf?] possible deadlock in bpf_lru_push_free (2)
Date: Sat, 15 Nov 2025 19:20:12 +0800 [thread overview]
Message-ID: <5938862.DvuYhMxLoT@7950hx> (raw)
In-Reply-To: <CAADnVQK8Viv9DTtfSQTm8T4Nuy2zoUyqRvhqTtzZWNc3By2Xpg@mail.gmail.com>
On 2025/11/15 10:36, Alexei Starovoitov wrote:
> On Thu, Nov 13, 2025 at 11:08 PM Menglong Dong <menglong.dong@linux.dev> wrote:
> >
> >
> > Hmm...I have not figure out a good idea, and maybe we can
> > use some transaction process here. Is there anyone else
> > that working on this issue?
>
> yeah. it's not easy. rqspinlock is not a drop-in replacement.
> But before we move any further, can you actually reproduce?
> I tried the repro.c with lockdep, kasan and all other debug configs
> and it doesn't repro.
> Maybe it was fixed already by nokprobe-ing lru, but syzbot didn't notice.
I think it's not fix yet. After pulling the latest bpf-next, it can
still be reproduced in my environment by running the ./test_progs
for several times, and following is the log.
We can still use the lru map in NMI context now, right? So I guess
the problem exists.
[ 230.458271] ================================
[ 230.458272] WARNING: inconsistent lock state
[ 230.458273] 6.18.0-rc5-g0d1fd0291e7a #82 Tainted: G W OE N
[ 230.458274] --------------------------------
[ 230.458275] inconsistent {INITIAL USE} -> {IN-NMI} usage.
[ 230.458275] new_name/10710 [HC1[1]:SC0[0]:HE0:SE1] takes:
[ 230.458277] ffffe8ffffbeade0 (&loc_l->lock){....}-{2:2}, at: bpf_lru_pop_free+0xea/0x620
[ 230.458282] {INITIAL USE} state was registered at:
[ 230.458283] lock_acquire+0xbc/0x2e0
[ 230.458285] _raw_spin_lock_irqsave+0x39/0x60
[ 230.458288] bpf_lru_pop_free+0xea/0x620
[ 230.458289] htab_lru_map_update_elem+0x7e/0x430
[ 230.458290] bpf_map_update_value+0x341/0x7d0
[ 230.458292] __sys_bpf+0x2360/0x3090
[ 230.458293] __x64_sys_bpf+0x21/0x30
[ 230.458295] do_syscall_64+0xbb/0x380
[ 230.458297] entry_SYSCALL_64_after_hwframe+0x77/0x7f
[ 230.458299] irq event stamp: 186
[ 230.458299] hardirqs last enabled at (185): [<ffffffff8282d75b>] irqentry_exit+0x3b/0x90
[ 230.458301] hardirqs last disabled at (186): [<ffffffff8282a3ef>] exc_nmi+0x7f/0x110
[ 230.458302] softirqs last enabled at (0): [<ffffffff8131ae53>] copy_process+0xa03/0x20a0
[ 230.458305] softirqs last disabled at (0): [<0000000000000000>] 0x0
[ 230.458306]
[ 230.458306] other info that might help us debug this:
[ 230.458307] Possible unsafe locking scenario:
[ 230.458307]
[ 230.458307] CPU0
[ 230.458308] ----
[ 230.458308] lock(&loc_l->lock);
[ 230.458309] <Interrupt>
[ 230.458309] lock(&loc_l->lock);
[ 230.458310]
[ 230.458310] *** DEADLOCK ***
[ 230.458310]
[ 230.458310] no locks held by new_name/10710.
[ 230.458311]
[ 230.458311] stack backtrace:
[ 230.458312] CPU: 3 UID: 0 PID: 10710 Comm: new_name Tainted: G W OE N 6.18.0-rc5-g0d1fd0291e7a #82 PREEMPT(full)
[ 230.458315] Tainted: [W]=WARN, [O]=OOT_MODULE, [E]=UNSIGNED_MODULE, [N]=TEST
[ 230.458315] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Arch Linux 1.17.0-2-2 04/01/2014
[ 230.458316] Call Trace:
[ 230.458317] <NMI>
[ 230.458318] dump_stack_lvl+0x5d/0x80
[ 230.458322] print_usage_bug.part.0+0x22b/0x2d0
[ 230.458324] lock_acquire+0x269/0x2e0
[ 230.458326] ? bpf_lru_pop_free+0xea/0x620
[ 230.458329] _raw_spin_lock_irqsave+0x39/0x60
[ 230.458330] ? bpf_lru_pop_free+0xea/0x620
[ 230.458332] bpf_lru_pop_free+0xea/0x620
[ 230.458336] htab_lru_map_update_elem+0x7e/0x430
[ 230.458338] ? srso_alias_return_thunk+0x5/0xfbef5
[ 230.458340] ? srso_alias_return_thunk+0x5/0xfbef5
[ 230.458341] ? __htab_map_lookup_elem+0x39/0xf0
[ 230.458344] bpf_prog_11d2424ce61f7f6c_oncpu_lru_map+0xe4/0x168
[ 230.458346] __perf_event_overflow+0x387/0x590
[ 230.458351] amd_pmu_v2_handle_irq+0x383/0x400
[ 230.458363] ? srso_alias_return_thunk+0x5/0xfbef5
[ 230.458364] ? look_up_lock_class+0x64/0x150
[ 230.458365] ? srso_alias_return_thunk+0x5/0xfbef5
[ 230.458366] ? lock_acquire+0x1e0/0x2e0
[ 230.458368] ? nmi_handle.part.0+0x30/0x230
[ 230.458372] perf_event_nmi_handler+0x34/0x60
[ 230.458374] nmi_handle.part.0+0xc9/0x230
[ 230.458378] default_do_nmi+0x10e/0x170
[ 230.458379] exc_nmi+0xe3/0x110
[ 230.458381] end_repeat_nmi+0xf/0x53
[ 230.458383] RIP: 0010:debug_check_no_locks_freed+0x1a/0x130
[ 230.458384] Code: 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 f3 0f 1e fa 8b 15 0a 69 22 03 85 d2 0f 84 86 00 00 00 41 56 41 54 55 53 9c 5d <fa> 65 48 8b 05 55 8d d4 03 48 63 80 40 0b 00 00 85 c0 7e 43 65 48
[ 230.458385] RSP: 0018:ffffc9000277be08 EFLAGS: 00000202
[ 230.458386] RAX: 0000000000000007 RBX: ffff88811d749c00 RCX: 0000000000000009
[ 230.458387] RDX: 0000000000000001 RSI: 0000000000000400 RDI: ffff88811d749c00
[ 230.458388] RBP: 0000000000000202 R08: ffff88812659b500 R09: 0000000000038e72
[ 230.458388] R10: 0000000000000000 R11: 00000000000025d6 R12: ffff888100045200
[ 230.458389] R13: ffffea000475d200 R14: ffffffff8170e3d6 R15: 0000000000000000
[ 230.458390] ? free_pipe_info+0xa6/0xb0
[ 230.458397] ? debug_check_no_locks_freed+0x1a/0x130
[ 230.458399] ? debug_check_no_locks_freed+0x1a/0x130
[ 230.458401] </NMI>
[ 230.458401] <TASK>
[ 230.458402] ? free_pipe_info+0xa6/0xb0
[ 230.458404] kfree+0xdc/0x4f0
[ 230.458406] ? srso_alias_return_thunk+0x5/0xfbef5
[ 230.458408] ? __free_frozen_pages+0x1e3/0x600
[ 230.458411] ? free_pipe_info+0xa6/0xb0
[ 230.458412] free_pipe_info+0xa6/0xb0
[ 230.458414] pipe_release+0x10a/0x120
[ 230.458416] __fput+0x103/0x2c0
[ 230.458419] __x64_sys_close+0x3d/0x80
[ 230.458422] do_syscall_64+0xbb/0x380
[ 230.458424] entry_SYSCALL_64_after_hwframe+0x77/0x7f
[ 230.458425] RIP: 0033:0x7f2a8be9f042
[ 230.458426] Code: 08 0f 85 d1 40 ff ff 49 89 fb 48 89 f0 48 89 d7 48 89 ce 4c 89 c2 4d 89 ca 4c 8b 44 24 08 4c 8b 4c 24 10 4c 89 5c 24 08 0f 05 <c3> 66 2e 0f 1f 84 00 00 00 00 00 66 2e 0f 1f 84 00 00 00 00 00 66
[ 230.458427] RSP: 002b:00007ffdf8ab3118 EFLAGS: 00000246 ORIG_RAX: 0000000000000003
[ 230.458428] RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007f2a8be9f042
[ 230.458428] RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000087
[ 230.458429] RBP: 00007ffdf8ab3140 R08: 0000000000000000 R09: 0000000000000000
[ 230.458429] R10: 0000000000000000 R11: 0000000000000246 R12: 00007ffdf8ab3548
[ 230.458430] R13: 0000000000000001 R14: 00007f2a95a18000 R15: 000055c8da5fdd70
>
prev parent reply other threads:[~2025-11-15 11:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-13 4:26 [syzbot] [bpf?] possible deadlock in bpf_lru_push_free (2) syzbot
2025-11-14 7:08 ` Menglong Dong
2025-11-15 2:36 ` Alexei Starovoitov
2025-11-15 11:20 ` Menglong Dong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5938862.DvuYhMxLoT@7950hx \
--to=menglong.dong@linux.dev \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=sdf@fomichev.me \
--cc=song@kernel.org \
--cc=syzbot+18b26edb69b2e19f3b33@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.