From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark yao Subject: Re: [PATCH 1/4] drm: bridge: dw-hdmi: Export hdmi_phy_configure_dwc_hdmi_3d_tx Date: Fri, 9 Jun 2017 12:03:31 +0800 Message-ID: <593A1E13.70501@rock-chips.com> References: <1496976070-29573-1-git-send-email-mark.yao@rock-chips.com> <1496976343-30005-1-git-send-email-mark.yao@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from regular1.263xmail.com (regular1.263xmail.com [211.150.99.130]) by gabe.freedesktop.org (Postfix) with ESMTPS id 908316E54C for ; Fri, 9 Jun 2017 04:03:36 +0000 (UTC) In-Reply-To: <1496976343-30005-1-git-send-email-mark.yao@rock-chips.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Archit Taneja , David Airlie , Laurent Pinchart , Jose Abreu , Neil Armstrong , Daniel Vetter , Kieran Bingham Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SWdub3JlIHRoaXMgcGF0Y2gsIEpvc2UgaGFzIGEgYmV0dGVyIHBhdGNoIHRvIHNvbHZlIHJrMzM5 OSBoZG1pIHBoeSAKY29uZmlndXJlLgoKSGkgSm9zZQoKU29ycnkgZm9yIG1pc3NpbmcgeW91ciBw YXRjaCBhYm91dCBoZG1pIDIuMCB2ZW5kb3IgcGh5IGZpeHVwOiAKaHR0cHM6Ly9wYXRjaHdvcmsu a2VybmVsLm9yZy9wYXRjaC85NzAyMjI5Ckl0IHdvcmtzIGZpbmUgb24gcmszMzk5L3JrMzI4OCwg Y2FuIHlvdSByZXNlbmQgYSBzdGFuZGFyZCBwYXRjaCB0byB1cHN0cmVhbT8KClRoYW5rcwoKT24g MjAxN+W5tDA25pyIMDnml6UgMTA6NDUsIE1hcmsgWWFvIHdyb3RlOgo+IFNvIGR3LWhkbWkgdmVu ZG9yIGRyaXZlciBjYW4gcmV1c2UgaGRtaV9waHlfY29uZmlndXJlX2R3Y19oZG1pXzNkX3R4Cj4g dG8gY29uZmlndXJlIHRoZWlyIGhhcmR3YXJlLgo+Cj4gU2lnbmVkLW9mZi1ieTogTWFyayBZYW8g PG1hcmsueWFvQHJvY2stY2hpcHMuY29tPgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2JyaWRn ZS9zeW5vcHN5cy9kdy1oZG1pLmMgfCAzICsrLQo+ICAgaW5jbHVkZS9kcm0vYnJpZGdlL2R3X2hk bWkuaCAgICAgICAgICAgICAgfCAzICsrKwo+ICAgMiBmaWxlcyBjaGFuZ2VkLCA1IGluc2VydGlv bnMoKyksIDEgZGVsZXRpb24oLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYnJp ZGdlL3N5bm9wc3lzL2R3LWhkbWkuYyBiL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2Uvc3lub3BzeXMv ZHctaGRtaS5jCj4gaW5kZXggNGUxZjU0YS4uYzFjZWVjNyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vYnJpZGdlL3N5bm9wc3lzL2R3LWhkbWkuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9icmlkZ2Uvc3lub3BzeXMvZHctaGRtaS5jCj4gQEAgLTEwOTcsNyArMTA5Nyw3IEBAIHN0YXRp YyBpbnQgZHdfaGRtaV9waHlfcG93ZXJfb24oc3RydWN0IGR3X2hkbWkgKmhkbWkpCj4gICAgKiBp bmZvcm1hdGlvbiB0aGUgRFdDIE1ITCBQSFkgaGFzIHRoZSBzYW1lIHJlZ2lzdGVyIGxheW91dCBh bmQgaXMgdGh1cyBhbHNvCj4gICAgKiBzdXBwb3J0ZWQgYnkgdGhpcyBmdW5jdGlvbi4KPiAgICAq Lwo+IC1zdGF0aWMgaW50IGhkbWlfcGh5X2NvbmZpZ3VyZV9kd2NfaGRtaV8zZF90eChzdHJ1Y3Qg ZHdfaGRtaSAqaGRtaSwKPiAraW50IGhkbWlfcGh5X2NvbmZpZ3VyZV9kd2NfaGRtaV8zZF90eChz dHJ1Y3QgZHdfaGRtaSAqaGRtaSwKPiAgIAkJY29uc3Qgc3RydWN0IGR3X2hkbWlfcGxhdF9kYXRh ICpwZGF0YSwKPiAgIAkJdW5zaWduZWQgbG9uZyBtcGl4ZWxjbG9jaykKPiAgIHsKPiBAQCAtMTE0 Niw2ICsxMTQ2LDcgQEAgc3RhdGljIGludCBoZG1pX3BoeV9jb25maWd1cmVfZHdjX2hkbWlfM2Rf dHgoc3RydWN0IGR3X2hkbWkgKmhkbWksCj4gICAKPiAgIAlyZXR1cm4gMDsKPiAgIH0KPiArRVhQ T1JUX1NZTUJPTF9HUEwoaGRtaV9waHlfY29uZmlndXJlX2R3Y19oZG1pXzNkX3R4KTsKPiAgIAo+ ICAgc3RhdGljIGludCBoZG1pX3BoeV9jb25maWd1cmUoc3RydWN0IGR3X2hkbWkgKmhkbWkpCj4g ICB7Cj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvZHJtL2JyaWRnZS9kd19oZG1pLmggYi9pbmNsdWRl L2RybS9icmlkZ2UvZHdfaGRtaS5oCj4gaW5kZXggZWQ1OTliZS4uN2ViNjdlNiAxMDA2NDQKPiAt LS0gYS9pbmNsdWRlL2RybS9icmlkZ2UvZHdfaGRtaS5oCj4gKysrIGIvaW5jbHVkZS9kcm0vYnJp ZGdlL2R3X2hkbWkuaAo+IEBAIC0xNTAsNiArMTUwLDkgQEAgaW50IGR3X2hkbWlfcHJvYmUoc3Ry dWN0IHBsYXRmb3JtX2RldmljZSAqcGRldiwKPiAgIGludCBkd19oZG1pX2JpbmQoc3RydWN0IHBs YXRmb3JtX2RldmljZSAqcGRldiwgc3RydWN0IGRybV9lbmNvZGVyICplbmNvZGVyLAo+ICAgCQkg Y29uc3Qgc3RydWN0IGR3X2hkbWlfcGxhdF9kYXRhICpwbGF0X2RhdGEpOwo+ICAgCj4gK2ludCBo ZG1pX3BoeV9jb25maWd1cmVfZHdjX2hkbWlfM2RfdHgoc3RydWN0IGR3X2hkbWkgKmhkbWksCj4g KwkJY29uc3Qgc3RydWN0IGR3X2hkbWlfcGxhdF9kYXRhICpwZGF0YSwKPiArCQl1bnNpZ25lZCBs b25nIG1waXhlbGNsb2NrKTsKPiAgIHZvaWQgZHdfaGRtaV9zZXR1cF9yeF9zZW5zZShzdHJ1Y3Qg ZGV2aWNlICpkZXYsIGJvb2wgaHBkLCBib29sIHJ4X3NlbnNlKTsKPiAgIAo+ICAgdm9pZCBkd19o ZG1pX3NldF9zYW1wbGVfcmF0ZShzdHJ1Y3QgZHdfaGRtaSAqaGRtaSwgdW5zaWduZWQgaW50IHJh dGUpOwoKCi0tIArvvK1hcmsgWWFvCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751501AbdFIEDk (ORCPT ); Fri, 9 Jun 2017 00:03:40 -0400 Received: from regular1.263xmail.com ([211.150.99.130]:37011 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750829AbdFIEDj (ORCPT ); Fri, 9 Jun 2017 00:03:39 -0400 X-263anti-spam: KSV:0;BIG:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ADDR-CHECKED4: 1 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ANTISPAM-LEVEL: 2 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: linux-kernel@vger.kernel.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: <66fe89263bebdc520d0b32f39aadadb1> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH 1/4] drm: bridge: dw-hdmi: Export hdmi_phy_configure_dwc_hdmi_3d_tx To: Archit Taneja , David Airlie , Laurent Pinchart , Jose Abreu , Neil Armstrong , Daniel Vetter , Kieran Bingham References: <1496976070-29573-1-git-send-email-mark.yao@rock-chips.com> <1496976343-30005-1-git-send-email-mark.yao@rock-chips.com> Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org From: Mark yao Message-ID: <593A1E13.70501@rock-chips.com> Date: Fri, 9 Jun 2017 12:03:31 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1496976343-30005-1-git-send-email-mark.yao@rock-chips.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ignore this patch, Jose has a better patch to solve rk3399 hdmi phy configure. Hi Jose Sorry for missing your patch about hdmi 2.0 vendor phy fixup: https://patchwork.kernel.org/patch/9702229 It works fine on rk3399/rk3288, can you resend a standard patch to upstream? Thanks On 2017年06月09日 10:45, Mark Yao wrote: > So dw-hdmi vendor driver can reuse hdmi_phy_configure_dwc_hdmi_3d_tx > to configure their hardware. > > Signed-off-by: Mark Yao > --- > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 3 ++- > include/drm/bridge/dw_hdmi.h | 3 +++ > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > index 4e1f54a..c1ceec7 100644 > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > @@ -1097,7 +1097,7 @@ static int dw_hdmi_phy_power_on(struct dw_hdmi *hdmi) > * information the DWC MHL PHY has the same register layout and is thus also > * supported by this function. > */ > -static int hdmi_phy_configure_dwc_hdmi_3d_tx(struct dw_hdmi *hdmi, > +int hdmi_phy_configure_dwc_hdmi_3d_tx(struct dw_hdmi *hdmi, > const struct dw_hdmi_plat_data *pdata, > unsigned long mpixelclock) > { > @@ -1146,6 +1146,7 @@ static int hdmi_phy_configure_dwc_hdmi_3d_tx(struct dw_hdmi *hdmi, > > return 0; > } > +EXPORT_SYMBOL_GPL(hdmi_phy_configure_dwc_hdmi_3d_tx); > > static int hdmi_phy_configure(struct dw_hdmi *hdmi) > { > diff --git a/include/drm/bridge/dw_hdmi.h b/include/drm/bridge/dw_hdmi.h > index ed599be..7eb67e6 100644 > --- a/include/drm/bridge/dw_hdmi.h > +++ b/include/drm/bridge/dw_hdmi.h > @@ -150,6 +150,9 @@ int dw_hdmi_probe(struct platform_device *pdev, > int dw_hdmi_bind(struct platform_device *pdev, struct drm_encoder *encoder, > const struct dw_hdmi_plat_data *plat_data); > > +int hdmi_phy_configure_dwc_hdmi_3d_tx(struct dw_hdmi *hdmi, > + const struct dw_hdmi_plat_data *pdata, > + unsigned long mpixelclock); > void dw_hdmi_setup_rx_sense(struct device *dev, bool hpd, bool rx_sense); > > void dw_hdmi_set_sample_rate(struct dw_hdmi *hdmi, unsigned int rate); -- Ｍark Yao