On 06/09/2017 01:11 AM, Nicholas A. Bellinger wrote: > Hi Bryant & Co, > > On Tue, 2017-06-06 at 09:28 -0500, Bryant G. Ly wrote: >> From: "Bryant G. Ly" >> >> This patch consists of adding a netlink to allow for reconfiguration >> of a device in tcmu. >> >> It also changes and adds some attributes that are reconfigurable: >> write_cache, device size, and device path. >> >> V2 - Fixes kfree in tcmu: Make dev_config configurable >> V3 - Fixes spelling error >> V4 - change strcpy to strlcpy for tcmu_dev_path_store and move >> tcmu_reconfig_type into target_core_user.h >> >> >> Bryant G. Ly (5): >> tcmu: Support emulate_write_cache >> tcmu: Add netlink for device reconfiguration >> tcmu: Make dev_size configurable via userspace >> tcmu: Make dev_config configurable >> tcmu: Add Type of reconfig into netlink >> >> drivers/target/target_core_user.c | 152 ++++++++++++++++++++++++++++++++-- >> include/uapi/linux/target_core_user.h | 9 ++ >> 2 files changed, 155 insertions(+), 6 deletions(-) >> > > AFAICT, it looks like all of the review comments have been addressed in > -v4. > > Applied to target-pending/for-next, with MNC's (pseudo) Reviewed-by's > added for #3-#5. > > Please let me know if anything else needs to be changed. > The patches look ok. Thanks. Could you just merge the attached patch into "[PATCH v4 5/5] tcmu: Add Type of reconfig into netlink" or into the patchset after it? It just makes some of the names a little less generic and only returns the reconfig attr for reconfig commands.