From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Agner Subject: Re: Lockdep warning when using REGCACHE_RBTREE Date: Fri, 15 Jan 2016 11:08:31 -0800 Message-ID: <593bcd768227b953c0fc87cc0e5b175d@agner.ch> References: <20160115000144.GU6588@sirena.org.uk> <44832539ca2bcc0be6e08260083363fe@agner.ch> <20160115162832.GY6588@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.kmu-office.ch (mail.kmu-office.ch [178.209.48.109]) by gabe.freedesktop.org (Postfix) with ESMTPS id EC8556E179 for ; Fri, 15 Jan 2016 11:10:42 -0800 (PST) In-Reply-To: <20160115162832.GY6588@sirena.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Mark Brown Cc: peterz@infradead.org, mingo@redhat.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gMjAxNi0wMS0xNSAwODoyOCwgTWFyayBCcm93biB3cm90ZToKPiBPbiBUaHUsIEphbiAxNCwg MjAxNiBhdCAwNToxNDo0N1BNIC0wODAwLCBTdGVmYW4gQWduZXIgd3JvdGU6Cj4gCj4+IE9uIGEg c2xpZ2h0bHkgb3RoZXIgdG9waWMsIEkgcXVlc3Rpb24gd2hldGhlciBSRUdDQUNIRV9SQlRSRUUg aXMgdGhlCj4+IHJpZ2h0IGNhY2hlIHR5cGUgZm9yIHRoZSBEQ1UgRFJNIGRyaXZlci4gVGhlIGRy aXZlciBoYXMgdXNlcyBhIHJlZ21hcAo+PiBhcmVhIG9mIDExNDQgMzItYml0IHJlZ2lzdGVycywg dGhlIG1vc3Qgc3BhY2UgaXMgdXNlZCBieSB0aGUgbGF5ZXIKPj4gY29uZmlndXJhdGlvbiByZWdp c3RlcnMgd2hpY2ggYXJlIDB4NDAgYXBhcnQgYW5kIDB4MC0weDIwIGZvciBlYWNoIGxheWVyCj4+ IGFyZSBhY3R1YWxseSB1c2VkIChoZW5jZSBzb21ld2hhdCBhYm92ZSA1MCUpLgo+IAo+PiBXb3Vs ZCBGTEFUIGJlIHRoZSBiZXR0ZXIgY2FjaGUgdHlwZT8KPiAKPiBZZXMsIGFuZCBpZiBpdCdzIGEg TU1JTyBkZXZpY2UgdGhlIHBlcmZvcm1hbmNlIG9mIGEgZmxhdCBjYWNoZSBpcyBtb3JlCj4gaW4g bGluZSB3aXRoIHRoZSBkZXZpY2UgcGVyZm9ybWFuY2UuCgpUaGFua3MgZm9yIGNvbmZpcm1pbmcg dGhhdC4gSSB3aWxsIHN3aXRjaCB0byBSRUdDQUNIRV9GTEFUIHRoZW4sIEkgZm91bmQKYSBzZWNv bmQgZHJpdmVyIHdpdGggdGhlIHZlcnkgc2FtZSBpc3N1ZSwgYWxzbyBhIE1NSU8gbWFwcGVkIGRl dmljZToKZHJpdmVycy9wd20vcHdtLWZzbC1mdG0uYy4uLgoKLS0KU3RlZmFuCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxp c3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753730AbcAOTKn (ORCPT ); Fri, 15 Jan 2016 14:10:43 -0500 Received: from mail.kmu-office.ch ([178.209.48.109]:49400 "EHLO mail.kmu-office.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751073AbcAOTKm (ORCPT ); Fri, 15 Jan 2016 14:10:42 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Date: Fri, 15 Jan 2016 11:08:31 -0800 From: Stefan Agner To: Mark Brown Cc: festevam@gmail.com, peterz@infradead.org, mingo@redhat.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: Lockdep warning when using REGCACHE_RBTREE In-Reply-To: <20160115162832.GY6588@sirena.org.uk> References: <20160115000144.GU6588@sirena.org.uk> <44832539ca2bcc0be6e08260083363fe@agner.ch> <20160115162832.GY6588@sirena.org.uk> Message-ID: <593bcd768227b953c0fc87cc0e5b175d@agner.ch> User-Agent: Roundcube Webmail/1.1.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016-01-15 08:28, Mark Brown wrote: > On Thu, Jan 14, 2016 at 05:14:47PM -0800, Stefan Agner wrote: > >> On a slightly other topic, I question whether REGCACHE_RBTREE is the >> right cache type for the DCU DRM driver. The driver has uses a regmap >> area of 1144 32-bit registers, the most space is used by the layer >> configuration registers which are 0x40 apart and 0x0-0x20 for each layer >> are actually used (hence somewhat above 50%). > >> Would FLAT be the better cache type? > > Yes, and if it's a MMIO device the performance of a flat cache is more > in line with the device performance. Thanks for confirming that. I will switch to REGCACHE_FLAT then, I found a second driver with the very same issue, also a MMIO mapped device: drivers/pwm/pwm-fsl-ftm.c... -- Stefan