From: Daniel Borkmann <daniel@iogearbox.net>
To: David Daney <david.daney@cavium.com>,
Alexei Starovoitov <ast@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org
Subject: Re: [PATCH 4/4] samples/bpf: Fix tracex5 to work with MIPS syscalls.
Date: Wed, 14 Jun 2017 02:21:36 +0200 [thread overview]
Message-ID: <59408190.6030206@iogearbox.net> (raw)
In-Reply-To: <20170613234938.4823-5-david.daney@cavium.com>
On 06/14/2017 01:49 AM, David Daney wrote:
> There are two problems:
>
> 1) In MIPS the __NR_* macros expand to an expression, this causes the
> sections of the object file to be named like:
>
> .
> .
> .
> [ 5] kprobe/(5000 + 1) PROGBITS 0000000000000000 000160 ...
> [ 6] kprobe/(5000 + 0) PROGBITS 0000000000000000 000258 ...
> [ 7] kprobe/(5000 + 9) PROGBITS 0000000000000000 000348 ...
> .
> .
> .
>
> The fix here is to use the "asm_offsets" trick to evaluate the macros
> in the C compiler and generate a header file with a usable form of the
> macros.
>
> 2) MIPS syscall numbers start at 5000, so we need a bigger map to hold
> the sub-programs.
>
> Signed-off-by: David Daney <david.daney@cavium.com>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
next prev parent reply other threads:[~2017-06-14 0:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-13 23:49 [PATCH 0/4] bpf: Changes needed (or desired) for MIPS support David Daney
2017-06-13 23:49 ` [PATCH 1/4] tools: bpf_jit_disasm: Handle large images David Daney
2017-06-14 0:19 ` Daniel Borkmann
2017-06-13 23:49 ` [PATCH 2/4] test_bpf: Add test to make conditional jump cross a large number of insns David Daney
2017-06-14 0:20 ` Daniel Borkmann
2017-06-13 23:49 ` [PATCH 3/4] bpf: Add MIPS support to samples/bpf David Daney
2017-06-14 0:20 ` Daniel Borkmann
2017-06-13 23:49 ` [PATCH 4/4] samples/bpf: Fix tracex5 to work with MIPS syscalls David Daney
2017-06-14 0:21 ` Daniel Borkmann [this message]
2017-06-14 0:22 ` [PATCH 0/4] bpf: Changes needed (or desired) for MIPS support Daniel Borkmann
2017-06-14 15:54 ` David Daney
2017-06-14 19:03 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59408190.6030206@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=ast@kernel.org \
--cc=davem@davemloft.net \
--cc=david.daney@cavium.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=netdev@vger.kernel.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.