From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Howells Subject: Re: [PATCH] SELinux: Create a common helper to determine an inode label [ver #2] Date: Thu, 18 Jun 2015 19:23:28 +0100 Message-ID: <5947.1434651808@warthog.procyon.org.uk> References: <5583007A.8040704@tycho.nsa.gov> <1509.1434645664@warthog.procyon.org.uk> <5582FB01.9080602@tycho.nsa.gov> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: In-Reply-To: <5583007A.8040704@tycho.nsa.gov> Content-ID: <5946.1434651808.1@warthog.procyon.org.uk> Sender: linux-security-module-owner@vger.kernel.org To: Stephen Smalley Cc: dhowells@redhat.com, linux-fsdevel@vger.kernel.org, linux-security-module@vger.kernel.org, linux-unionfs@vger.kernel.org, linux-kernel@vger.kernel.org, SELinux , Paul Moore List-Id: linux-unionfs@vger.kernel.org Stephen Smalley wrote: > >> + rc = selinux_determine_inode_label(d_inode(dentry), name, > > > > We want d_inode(dentry->d_parent) here. > > Not sure why the caller didn't just pass in the dir inode in the first > place. Might be something in one of the other LSMs? David From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Howells In-Reply-To: <5583007A.8040704@tycho.nsa.gov> References: <5583007A.8040704@tycho.nsa.gov> <1509.1434645664@warthog.procyon.org.uk> <5582FB01.9080602@tycho.nsa.gov> To: Stephen Smalley Subject: Re: [PATCH] SELinux: Create a common helper to determine an inode label [ver #2] MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Date: Thu, 18 Jun 2015 19:23:28 +0100 Message-ID: <5947.1434651808@warthog.procyon.org.uk> Cc: linux-unionfs@vger.kernel.org, linux-kernel@vger.kernel.org, dhowells@redhat.com, linux-security-module@vger.kernel.org, SELinux , linux-fsdevel@vger.kernel.org List-Id: "Security-Enhanced Linux \(SELinux\) mailing list" List-Post: List-Help: Stephen Smalley wrote: > >> + rc = selinux_determine_inode_label(d_inode(dentry), name, > > > > We want d_inode(dentry->d_parent) here. > > Not sure why the caller didn't just pass in the dir inode in the first > place. Might be something in one of the other LSMs? David