All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Borkmann <daniel@iogearbox.net>
To: Jakub Kicinski <kubakici@wp.pl>
Cc: netdev@vger.kernel.org, davem@davemloft.net, kafai@fb.com,
	oss-drivers@netronome.com, brouer@redhat.com
Subject: Re: [RFC net-next 2/8] xdp: add HW offload mode flag for installing programs
Date: Tue, 20 Jun 2017 01:36:21 +0200	[thread overview]
Message-ID: <59485FF5.7010308@iogearbox.net> (raw)
In-Reply-To: <20170619162455.466ca63e@cakuba.netronome.com>

On 06/20/2017 01:24 AM, Jakub Kicinski wrote:
[...]
> The XDP_SETUP_PROG_HW command is purely for convenience of drivers
> without an offload.  I felt it's not appropriate to burden all drivers
> with:
>
> if (xdp->flags & XDP_FLAGS_HW_MODE)
> 	return -EOPNOTSUPP;
>
> But, I do have a patch which does it, so I'm happy to drop the new
> command if it's preferred.

Ahh, that makes sense, yep. I was only focused on reviewing this in
the context of nfp driver. Lack of coffee. ;)

  reply	other threads:[~2017-06-19 23:36 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-16 23:57 [RFC net-next 0/8] xdp: offload mode Jakub Kicinski
2017-06-16 23:57 ` [RFC net-next 1/8] xdp: pass XDP flags into install handlers Jakub Kicinski
2017-06-19 23:38   ` Daniel Borkmann
2017-06-16 23:57 ` [RFC net-next 2/8] xdp: add HW offload mode flag for installing programs Jakub Kicinski
2017-06-19 22:55   ` Daniel Borkmann
2017-06-19 23:24     ` Jakub Kicinski
2017-06-19 23:36       ` Daniel Borkmann [this message]
2017-06-19 23:39   ` Daniel Borkmann
2017-06-16 23:57 ` [RFC net-next 3/8] nfp: xdp: move driver XDP setup into a separate function Jakub Kicinski
2017-06-16 23:57 ` [RFC net-next 4/8] nfp: bpf: don't offload XDP programs in DRV_MODE Jakub Kicinski
2017-06-16 23:57 ` [RFC net-next 5/8] nfp: bpf: take a reference on offloaded programs Jakub Kicinski
2017-06-19 23:23   ` Daniel Borkmann
2017-06-19 23:34     ` Jakub Kicinski
2017-06-16 23:57 ` [RFC net-next 6/8] nfp: bpf: add support for XDP_FLAGS_HW_MODE Jakub Kicinski
2017-06-19 23:50   ` Daniel Borkmann
2017-06-20  0:01     ` Jakub Kicinski
2017-06-20  0:09       ` Daniel Borkmann
2017-06-16 23:57 ` [RFC net-next 7/8] xdp: add reporting of offload mode Jakub Kicinski
2017-06-19 23:40   ` Daniel Borkmann
2017-06-16 23:57 ` [RFC net-next 8/8] nfp: xdp: report if program is offloaded Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59485FF5.7010308@iogearbox.net \
    --to=daniel@iogearbox.net \
    --cc=brouer@redhat.com \
    --cc=davem@davemloft.net \
    --cc=kafai@fb.com \
    --cc=kubakici@wp.pl \
    --cc=netdev@vger.kernel.org \
    --cc=oss-drivers@netronome.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.