From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Set skb priority in fragments
Date: Wed, 11 May 2016 08:21:27 +0200 [thread overview]
Message-ID: <5949161.ptvGUENbB7@bentobox> (raw)
In-Reply-To: <1462817016-17867-2-git-send-email-andrew@lunn.ch>
[-- Attachment #1: Type: text/plain, Size: 1093 bytes --]
On Monday 09 May 2016 20:03:35 Andrew Lunn wrote:
> BATMAN will set the skb->priority based on the IP precedence or 802.1q
> tag. However, if it needs to fragment the frame, it currently leaves
> the fragment skb with the default priority and actually overwrites the
> priority in the unfragmented frame. Fix this.
>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> ---
> net/batman-adv/fragmentation.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/batman-adv/fragmentation.c b/net/batman-adv/fragmentation.c
> index 65536db..a3fefbd 100644
> --- a/net/batman-adv/fragmentation.c
> +++ b/net/batman-adv/fragmentation.c
> @@ -414,7 +414,7 @@ static struct sk_buff *batadv_frag_create(struct sk_buff *skb,
> if (!skb_fragment)
> goto err;
>
> - skb->priority = TC_PRIO_CONTROL;
> + skb_fragment->priority = skb->priority;
>
> /* Eat the last mtu-bytes of the skb */
> skb_reserve(skb_fragment, header_size + ETH_HLEN);
>
Please remove linux/pkt_sched.h in fragmentation.c because it is only
used for TC_PRIO_CONTROL in master.
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-05-11 6:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-09 18:03 [B.A.T.M.A.N.] [PATCH 0/2] Fragments and QoS Andrew Lunn
2016-05-09 18:03 ` [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Set skb priority in fragments Andrew Lunn
2016-05-11 6:21 ` Sven Eckelmann [this message]
2016-05-11 8:06 ` Marek Lindner
2016-05-09 18:03 ` [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: Include frame priority in fragment header Andrew Lunn
2016-05-12 10:04 ` Marek Lindner
2016-05-10 14:23 ` [B.A.T.M.A.N.] [PATCH 0/2] Fragments and QoS Simon Wunderlich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5949161.ptvGUENbB7@bentobox \
--to=sven@narfation.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.