From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark yao Subject: Re: [PATCH v3.1 1/3] drm/rockchip: dw_hdmi: add RK3399 HDMI support Date: Thu, 22 Jun 2017 16:02:44 +0800 Message-ID: <594B79A4.1000509@rock-chips.com> References: <1496992236-10634-1-git-send-email-mark.yao@rock-chips.com> <1498115845-7177-1-git-send-email-mark.yao@rock-chips.com> <1751555.73cFbViMXZ@phil> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1751555.73cFbViMXZ@phil> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Heiko Stuebner Cc: Mark Rutland , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Rob Herring , linux-arm-kernel@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org T24gMjAxN+W5tDA25pyIMjLml6UgMTU6MzEsIEhlaWtvIFN0dWVibmVyIHdyb3RlOgo+PiArCj4+ ID4rLyoqCj4+ID4rICogc3RydWN0IHJvY2tjaGlwX2hkbWlfY2hpcF9kYXRhIC0gc3BsaXRlIHRo ZSBncmYgc2V0dGluZyBvZiBraW5kIG9mIGNoaXBzCj4+ID4rICogQGxjZHNlbF9ncmZfcmVnOiBn cmYgcmVnaXN0ZXIgb2Zmc2V0IG9mIGxjZGMgc2VsZWN0Cj4+ID4rICogQGxjZHNlbF9iaWc6IHJl ZyB2YWx1ZSBvZiBzZWxlY3Rpbmcgdm9wIGJpZyBmb3IgSERNSQo+PiA+KyAqIEBsY2RzZWxfbGl0 OiByZWcgdmFsdWUgb2Ygc2VsZWN0aW5nIHZvcCBsaXR0bGUgZm9yIEhETUkKPj4gPisgKi8KPj4g PitzdHJ1Y3Qgcm9ja2NoaXBfaGRtaV9jaGlwX2RhdGEgewo+PiA+Kwl1MzIJbGNkc2VsX2dyZl9y ZWc7Cj4gSG93IGRvIHlvdSBwbGFuIG9uIGhhbmRsaW5nIHRoZSByazMzNjggKHdpdGggb25seSBv bmUgVk9QIGFuZCB0aHVzCj4gbm8gc2VsZWN0aW9uIGhhcHBlbmluZyk/IEknZCBqdXN0IG1ha2Ug dGhlIGFib3ZlIGFuIGludCwgc28gd2UgY291bGQKPiBzZXQgaXQgdG8gLTEgZm9yIHRoYXQgY2Fz ZS4gKHZhbHVlIDAgaXMgYWZ0ZXIgYWxsIGEgdmFsaWQgcmVnKS4KCkl0J3MgYSBwcm9ibGVtIGhh bmRsaW5nIG9uIHJrMzM2OCwgdXNpbmcgLTEgdG8ganVkZ2UgbWVhbnMgdGhhdCB3ZSBuZWVkCmlu aXRpYWwgdGhlIGxjZHNlbF9ncmZfcmVnIHRvIC0xIG9uIHJrMzM2OCBwbGF0Zm9ybSwgd2UgbmVl ZCBhbHdheXMgYWRkIGEgcGxhdGZvcm0KZGF0YSB0byBoYW5kbGUgaXQsIHNlZW1zIG5vdCBnb29k IGVub3VnaC4KClNpbmNlIHRoZSBoZG1pIGNoaXAgZGF0YSBvbmx5IHVzZSBmb3Igdm9wIHNlbGVj dGlvbiwgbWF5YmUgd2UgY2FuIGp1ZGdlIHdpdGgKY2hlY2tpbmcgaGRtaS0+Y2hpcF9kYXRhID09 IE5VTEwgZm9yIHRoZSBjYXNlLgoKTWFyay4KCj4KPiBIZWlrbwo+Cj4KCi0tIArvvK1hcmsgWWFv CgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRl dmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: mark.yao@rock-chips.com (Mark yao) Date: Thu, 22 Jun 2017 16:02:44 +0800 Subject: [PATCH v3.1 1/3] drm/rockchip: dw_hdmi: add RK3399 HDMI support In-Reply-To: <1751555.73cFbViMXZ@phil> References: <1496992236-10634-1-git-send-email-mark.yao@rock-chips.com> <1498115845-7177-1-git-send-email-mark.yao@rock-chips.com> <1751555.73cFbViMXZ@phil> Message-ID: <594B79A4.1000509@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2017?06?22? 15:31, Heiko Stuebner wrote: >> + >> >+/** >> >+ * struct rockchip_hdmi_chip_data - splite the grf setting of kind of chips >> >+ * @lcdsel_grf_reg: grf register offset of lcdc select >> >+ * @lcdsel_big: reg value of selecting vop big for HDMI >> >+ * @lcdsel_lit: reg value of selecting vop little for HDMI >> >+ */ >> >+struct rockchip_hdmi_chip_data { >> >+ u32 lcdsel_grf_reg; > How do you plan on handling the rk3368 (with only one VOP and thus > no selection happening)? I'd just make the above an int, so we could > set it to -1 for that case. (value 0 is after all a valid reg). It's a problem handling on rk3368, using -1 to judge means that we need initial the lcdsel_grf_reg to -1 on rk3368 platform, we need always add a platform data to handle it, seems not good enough. Since the hdmi chip data only use for vop selection, maybe we can judge with checking hdmi->chip_data == NULL for the case. Mark. > > Heiko > > -- ?ark Yao From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752744AbdFVIDA (ORCPT ); Thu, 22 Jun 2017 04:03:00 -0400 Received: from regular1.263xmail.com ([211.150.99.137]:55750 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752630AbdFVIC6 (ORCPT ); Thu, 22 Jun 2017 04:02:58 -0400 X-263anti-spam: BIG:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-ADDR-CHECKED4: 1 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ANTISPAM-LEVEL: 2 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: linux-arm-kernel@lists.infradead.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v3.1 1/3] drm/rockchip: dw_hdmi: add RK3399 HDMI support To: Heiko Stuebner References: <1496992236-10634-1-git-send-email-mark.yao@rock-chips.com> <1498115845-7177-1-git-send-email-mark.yao@rock-chips.com> <1751555.73cFbViMXZ@phil> Cc: Mark Rutland , devicetree@vger.kernel.org, David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Rob Herring , linux-arm-kernel@lists.infradead.org From: Mark yao Message-ID: <594B79A4.1000509@rock-chips.com> Date: Thu, 22 Jun 2017 16:02:44 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1751555.73cFbViMXZ@phil> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017年06月22日 15:31, Heiko Stuebner wrote: >> + >> >+/** >> >+ * struct rockchip_hdmi_chip_data - splite the grf setting of kind of chips >> >+ * @lcdsel_grf_reg: grf register offset of lcdc select >> >+ * @lcdsel_big: reg value of selecting vop big for HDMI >> >+ * @lcdsel_lit: reg value of selecting vop little for HDMI >> >+ */ >> >+struct rockchip_hdmi_chip_data { >> >+ u32 lcdsel_grf_reg; > How do you plan on handling the rk3368 (with only one VOP and thus > no selection happening)? I'd just make the above an int, so we could > set it to -1 for that case. (value 0 is after all a valid reg). It's a problem handling on rk3368, using -1 to judge means that we need initial the lcdsel_grf_reg to -1 on rk3368 platform, we need always add a platform data to handle it, seems not good enough. Since the hdmi chip data only use for vop selection, maybe we can judge with checking hdmi->chip_data == NULL for the case. Mark. > > Heiko > > -- Ｍark Yao