From: John Snow <jsnow@redhat.com>
To: Stefano Garzarella <sgarzare@redhat.com>, qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
qemu-block@nongnu.org, qemu-trivial@nongnu.org,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Max Reitz" <mreitz@redhat.com>,
"Jeff Cody" <codyprime@gmail.com>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH v2 2/2] block/vhdx: Use IEC binary prefixes for size constants
Date: Wed, 27 Mar 2019 13:17:56 -0400 [thread overview]
Message-ID: <5950ecf9-eabc-a361-eab8-49333b60085a@redhat.com> (raw)
In-Reply-To: <20190327095634.53038-3-sgarzare@redhat.com>
On 3/27/19 5:56 AM, Stefano Garzarella wrote:
> Using IEC binary prefixes in order to make the code more readable,
> with the exception of DEFAULT_LOG_SIZE because it's passed to
> stringify().
>
> Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
Looks good to me;
Reviewed-by: John Snow <jsnow@redhat.com>
next prev parent reply other threads:[~2019-03-27 17:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-27 9:56 [Qemu-trivial] [PATCH v2 0/2] block/vhdx: Use IEC binary prefixes from "qemu/units.h" Stefano Garzarella
2019-03-27 9:56 ` [Qemu-trivial] [PATCH v2 1/2] block/vhdx: Remove redundant IEC binary prefixes definition Stefano Garzarella
2019-03-27 12:40 ` Philippe Mathieu-Daudé
2019-03-27 17:16 ` John Snow
2019-03-27 17:23 ` Stefano Garzarella
2019-03-27 20:16 ` [Qemu-trivial] [Qemu-devel] " Philippe Mathieu-Daudé
2019-04-11 19:54 ` [Qemu-trivial] " Laurent Vivier
2019-04-11 19:54 ` [Qemu-devel] " Laurent Vivier
2019-04-11 19:55 ` Laurent Vivier
2019-04-11 19:55 ` [Qemu-devel] " Laurent Vivier
2019-03-27 9:56 ` [Qemu-trivial] [PATCH v2 2/2] block/vhdx: Use IEC binary prefixes for size constants Stefano Garzarella
2019-03-27 12:39 ` Philippe Mathieu-Daudé
2019-03-27 17:17 ` John Snow [this message]
2019-03-28 12:29 ` [Qemu-trivial] [PATCH v2 0/2] block/vhdx: Use IEC binary prefixes from "qemu/units.h" Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5950ecf9-eabc-a361-eab8-49333b60085a@redhat.com \
--to=jsnow@redhat.com \
--cc=codyprime@gmail.com \
--cc=f4bug@amsat.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sgarzare@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.