Re: [PATCH 1/3] drm/amdgpu: fix a typo

From: zhoucm1 <david1.zhou-5C7GfCeVMHo@public.gmane.org>
To: Bas Nieuwenhuizen
	<bas-dldO88ZXqoXqqjsSq9zF6IRWq/SkRNHw@public.gmane.org>,
	Dave Airlie <airlied-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: "Christian König"
	<deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>,
	"amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
	<amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>,
	axie <axie-5C7GfCeVMHo@public.gmane.org>,
	"Marek Olšák" <maraeo-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	"Xie, AlexBin" <AlexBin.Xie-5C7GfCeVMHo@public.gmane.org>
Subject: Re: [PATCH 1/3] drm/amdgpu: fix a typo
Date: Wed, 28 Jun 2017 10:00:25 +0800	[thread overview]
Message-ID: <59530DB9.4000901@amd.com> (raw)
In-Reply-To: <CAP+8YyGouX0AeBxj+UNmb1Q7iwAzt0Z_hx__hf1Bb=YqC55J_A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

On 2017年06月28日 04:50, Bas Nieuwenhuizen wrote:
> On Tue, Jun 27, 2017 at 10:40 PM, Dave Airlie <airlied@gmail.com> wrote:
>> On 26 June 2017 at 19:10, zhoucm1 <david1.zhou@amd.com> wrote:
>>>
>>> On 2017年06月26日 03:48, Dave Airlie wrote:
>>>>> Do you not use bo list at all in mesa? radv as well?
>>>> Currently radv is creating a bo list per command submission. radv does
>>>> not use an offload thread to do command submission, as it seems pretty
>>>> un-vulkan to use a thread for the queue submission thread the game
>>>> uses.
>>>>
>>>> I have considered investigating this, but with vulkan it's probably
>>>> optimising for the single threaded case which isn't where apps should
>>>> really be.
>>>>
>>>> At the moment we regenerate the bo list on every CS ioctl, we probably
>>>> can do a lot better, I know Bas has looked into this area a bit more
>>>> than I.
>>> Thanks Dave for inputting.
>>>
>>> Could I ask more about radv? How does radv make bo list for every cs ioctl?
>>> Adding filter in every operation, any related bo will be add to bo list
>>> during make command submission?
>> When we create command buffers we add each bo to a list for it, but we
>> don't call the kernel ioctl.
>>
>> When we get a QueueSubmit, we usually submit two IBs to the kernel,
>> one with some cache flushes and one with the main IB in it, however as
>> we have to give the kernel one bo list we have to combine the two
>> lists (even if the cache flush list only has one ib in it, itself), so
>> we can't call create bo list early, we have to do it just before
>> command submission. However I don't think we've had any problems with
>> this being our slow path yet, but this may change in the future.
> Yeah. IIRC the bo list create is typically < 10% of our kernel time for radv.

Thanks a lot for all your input.

Regards,
David Zhou
>> Dave.

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx