All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] km/common: remove unused code
Date: Fri, 30 Jun 2017 15:52:10 +0200	[thread overview]
Message-ID: <5956578A.9070705@denx.de> (raw)
In-Reply-To: <20170630133335.15461-1-holger.brunck@keymile.com>

Hello Holger,

Am 30.06.2017 um 15:33 schrieb Holger Brunck:
> The 82xx board mgcoge3ne was removed from the codebase, so this is dead
> code.
>
> Signed-off-by: Holger Brunck <holger.brunck@keymile.com>
> Cc: Heiko Schocher <hs@denx.de>
> ---
>   board/keymile/common/common.c | 3 ---
>   1 file changed, 3 deletions(-)

nice catch! Thanks!

Reviewed-by: Heiko Schocher <hs@denx.de>

bye,
Heiko
>
> diff --git a/board/keymile/common/common.c b/board/keymile/common/common.c
> index 0829b7fa06..408079c9a1 100644
> --- a/board/keymile/common/common.c
> +++ b/board/keymile/common/common.c
> @@ -355,9 +355,6 @@ static int do_checktestboot(cmd_tbl_t *cmdtp, int flag, int argc,
>   #if defined(CONFIG_POST)
>   	testpin = post_hotkeys_pressed();
>   #endif
> -#if defined(CONFIG_MGCOGE3NE)
> -	testpin = get_testpin();
> -#endif
>   	s = getenv("test_bank");
>   	/* when test_bank is not set, act as if testpin is not asserted */
>   	testboot = (testpin != 0) && (s);
>

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

  reply	other threads:[~2017-06-30 13:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-30 13:33 [U-Boot] [PATCH] km/common: remove unused code Holger Brunck
2017-06-30 13:52 ` Heiko Schocher [this message]
2017-07-07 11:41 ` [U-Boot] " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5956578A.9070705@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.