From: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>
To: netdev@vger.kernel.org, Marek Vasut <marex@denx.de>
Cc: Marek Vasut <marex@denx.de>,
Amitkumar Karwar <amit.karwar@redpinesignals.com>,
Angus Ainslie <angus@akkea.ca>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Kalle Valo <kvalo@codeaurora.org>,
Karun Eagalapati <karun256@gmail.com>,
Martin Fuzzey <martin.fuzzey@flowbird.group>,
Martin Kepplinger <martink@posteo.de>,
Prameela Rani Garnepudi <prameela.j04cs@gmail.com>,
Siva Rebbagondla <siva8118@gmail.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] rsi: Fix module dev_oper_mode parameter description
Date: Thu, 16 Sep 2021 09:03:08 +0200 [thread overview]
Message-ID: <5957470.R6RXr1ZQNe@pliszka> (raw)
In-Reply-To: <20210915080841.73938-1-marex@denx.de>
On środa, 15 września 2021 10:08:41 CEST Marek Vasut wrote:
> +#define DEV_OPMODE_PARAM_DESC \
> + __stringify(DEV_OPMODE_WIFI_ALONE) "[Wi-Fi alone], " \
> + __stringify(DEV_OPMODE_BT_ALONE) "[BT classic alone], " \
> + __stringify(DEV_OPMODE_BT_LE_ALONE) "[BT LE], "
\
> + __stringify(DEV_OPMODE_BT_DUAL) "[BT Dual], "
\
> + __stringify(DEV_OPMODE_STA_BT) "[Wi-Fi STA + BT
classic], " \
> + __stringify(DEV_OPMODE_STA_BT_LE) "[Wi-Fi STA + BT LE], " \
> + __stringify(DEV_OPMODE_STA_BT_DUAL) "[Wi-Fi STA + BT
classic + BT LE], " \
> + __stringify(DEV_OPMODE_AP_BT) "[AP + BT classic], "
\
> + __stringify(DEV_OPMODE_AP_BT_DUAL) "[AP + BT classic + BT LE]"
There's still some inconsistency in mode naming - how about:
- Wi-Fi STA
- BT classic
- BT LE
- BT classic + BT LE
- Wi-Fi STA + BT classic
- Wi-Fi STA + BT LE
- Wi-Fi STA + BT classic + BT LE
- Wi-Fi AP + BT classic
- Wi-Fi AP + BT classic + BT LE
"alone" could be added to the first three modes (you missed it in BT LE).
Cheers,
Sebastian
next prev parent reply other threads:[~2021-09-16 7:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 8:08 [PATCH] rsi: Fix module dev_oper_mode parameter description Marek Vasut
2021-09-16 4:39 ` Kalle Valo
2021-09-16 7:03 ` Sebastian Krzyszkowiak [this message]
2021-09-16 14:39 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5957470.R6RXr1ZQNe@pliszka \
--to=sebastian.krzyszkowiak@puri.sm \
--cc=amit.karwar@redpinesignals.com \
--cc=angus@akkea.ca \
--cc=davem@davemloft.net \
--cc=karun256@gmail.com \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=marex@denx.de \
--cc=martin.fuzzey@flowbird.group \
--cc=martink@posteo.de \
--cc=netdev@vger.kernel.org \
--cc=prameela.j04cs@gmail.com \
--cc=siva8118@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.