From: Segher Boessenkool <segher@kernel.crashing.org>
To: michael@ellerman.id.au
Cc: Paul Mackerras <paulus@samba.org>,
linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz,
Auke Kok <auke-jan.h.kok@intel.com>,
gregkh@suse.de, davem@davemloft.net, grundler@parisc-linux.org
Subject: Re: [PATCH] PCI: also read revision ID for sparc64, ppc, read class at the same time
Date: Sun, 10 Jun 2007 14:17:48 +0200 [thread overview]
Message-ID: <59594cddc7b5eb6e355fd01efef8ebcc@kernel.crashing.org> (raw)
In-Reply-To: <1181474643.8351.1.camel@concordia.ozlabs.ibm.com>
>> + dev->revision = get_int_prop(node, "revision-id", 0);
>
> It's not clear to me in the spec if nodes are required to have the
> "revision-id" property.
It is required for every PCI node.
> I guess 0 is a safe default though.
As good as any -- that is, no default is save. 0 should
be "good enough" here I guess.
Segher
next prev parent reply other threads:[~2007-06-10 12:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-09 20:12 [PATCH] PCI: also read revision ID for sparc64, ppc, read class at the same time Auke Kok
2007-06-10 1:54 ` Grant Grundler
2007-06-22 17:12 ` Kok, Auke
2007-06-22 19:46 ` Greg KH
2007-06-10 11:24 ` Michael Ellerman
2007-06-10 12:17 ` Segher Boessenkool [this message]
2007-06-12 1:10 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59594cddc7b5eb6e355fd01efef8ebcc@kernel.crashing.org \
--to=segher@kernel.crashing.org \
--cc=auke-jan.h.kok@intel.com \
--cc=davem@davemloft.net \
--cc=gregkh@suse.de \
--cc=grundler@parisc-linux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=michael@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.