From: zhoucm1 <david1.zhou-5C7GfCeVMHo@public.gmane.org>
To: "Christian König"
<deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>,
"amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
<amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Subject: Re: [PATCH 07/11] drm/amdgpu: rename GART to SYSVM
Date: Tue, 4 Jul 2017 15:59:41 +0800 [thread overview]
Message-ID: <595B4AED.2060008@amd.com> (raw)
In-Reply-To: <b838bbac-38df-5ee4-5447-9edba988ea8a-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
I have no strong opinion with that, this patch is Acked-by: Chunming
Zhou <david1.zhou@amd.com>
On 2017年07月04日 15:43, Christian König wrote:
>> Maybe we just need rename GART functions to SYSVM.
> That is essentially what I've did.
>
> In recent discussion we a couple of times the problem that we need to
> distinguish between the system VM and the GART/GTT domain from TTM.
>
> See starting with R6xx I think we used the system VM to implement the
> old GART functionality from AGP days.
>
> The name stayed the same over the years, but we ran into the problem
> that we wanted to reduce the size of the system VM to save VRAM while
> still having a large GTT domain in TTM to map all system memory at the
> same time.
>
> So that the TTM parts stay the same is intentional.
>
> Regards,
> Christian.
>
> Am 04.07.2017 um 05:13 schrieb Zhou, David(ChunMing):
>> Distinguishing system vm and general vm is a good idea, but I'm not
>> sure about renaming GTT to sysvm part, especially TTM TT stays there.
>> Maybe we just need rename GART functions to SYSVM.
>>
>> Regards,
>> David Zhou
>>
>> -----Original Message-----
>> From: amd-gfx [mailto:amd-gfx-bounces@lists.freedesktop.org] On
>> Behalf Of Christian K?nig
>> Sent: Monday, July 03, 2017 5:45 PM
>> To: amd-gfx@lists.freedesktop.org
>> Subject: [PATCH 07/11] drm/amdgpu: rename GART to SYSVM
>>
>> From: Christian König <christian.koenig@amd.com>
>>
>> Just mass rename all names related to the hardware GART/GTT functions
>> to SYSVM.
>>
>> The name of symbols related to the TTM TT domain stay the same.
>>
>> This should improve the distinction between the two.
>>
>> Signed-off-by: Christian König <christian.koenig@amd.com>
>> ---
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2017-07-04 7:59 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-03 9:44 [PATCH 01/11] drm/amdgpu: reserve the first 2x512 of GART Christian König
[not found] ` <1499075076-1851-1-git-send-email-deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
2017-07-03 9:44 ` [PATCH 02/11] drm/amdgpu: add amdgpu_gart_map function v2 Christian König
[not found] ` <1499075076-1851-2-git-send-email-deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
2017-07-06 16:16 ` Alex Deucher
2017-07-03 9:44 ` [PATCH 03/11] drm/amdgpu: use the GTT windows for BO moves v2 Christian König
[not found] ` <1499075076-1851-3-git-send-email-deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
2017-07-06 16:17 ` Alex Deucher
2017-07-03 9:44 ` [PATCH 04/11] drm/amdgpu: stop mapping BOs to GTT Christian König
[not found] ` <1499075076-1851-4-git-send-email-deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
2017-07-06 16:18 ` Alex Deucher
2017-07-03 9:44 ` [PATCH 05/11] drm/amdgpu: remove maximum BO size limitation v2 Christian König
[not found] ` <1499075076-1851-5-git-send-email-deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
2017-07-06 16:18 ` Alex Deucher
2017-07-03 9:44 ` [PATCH 06/11] drm/amdgpu: use TTM values instead of MC values for the info queries Christian König
[not found] ` <1499075076-1851-6-git-send-email-deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
2017-07-06 16:19 ` Alex Deucher
2017-07-03 9:44 ` [PATCH 07/11] drm/amdgpu: rename GART to SYSVM Christian König
[not found] ` <1499075076-1851-7-git-send-email-deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
2017-07-04 3:13 ` Zhou, David(ChunMing)
[not found] ` <MWHPR1201MB0206D4883B42434777D43C12B4D70-3iK1xFAIwjrUF/YbdlDdgWrFom/aUZj6nBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2017-07-04 7:43 ` Christian König
[not found] ` <b838bbac-38df-5ee4-5447-9edba988ea8a-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
2017-07-04 7:59 ` zhoucm1 [this message]
2017-07-04 8:09 ` Huang Rui
2017-07-04 8:46 ` Christian König
2017-07-04 21:11 ` Felix Kuehling
[not found] ` <61109920-9d05-cb27-67b3-51a1b46b15bc-5C7GfCeVMHo@public.gmane.org>
2017-07-05 0:57 ` Michel Dänzer
[not found] ` <06b47744-60a4-f79e-e120-60d7bcff8526-otUistvHUpPR7s880joybQ@public.gmane.org>
2017-07-05 7:22 ` Christian König
2017-07-06 16:22 ` Alex Deucher
2017-07-03 9:44 ` [PATCH 08/11] drm/amdgpu: move SYSVM struct and function into amdgpu_sysvm.h Christian König
[not found] ` <1499075076-1851-8-git-send-email-deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
2017-07-06 16:24 ` Alex Deucher
2017-07-03 9:44 ` [PATCH 09/11] drm/amdgpu: move amdgpu_sysvm_location into amdgpu_sysvm.c as well Christian König
[not found] ` <1499075076-1851-9-git-send-email-deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
2017-07-06 16:25 ` Alex Deucher
2017-07-03 9:44 ` [PATCH 10/11] drm/amdgpu: setup GTT size directly from module parameter Christian König
[not found] ` <1499075076-1851-10-git-send-email-deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
2017-07-06 16:26 ` Alex Deucher
2017-07-03 9:44 ` [PATCH 11/11] drm/amdgpu: add sysvm_size Christian König
[not found] ` <1499075076-1851-11-git-send-email-deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
2017-07-06 16:28 ` Alex Deucher
2017-07-06 16:15 ` [PATCH 01/11] drm/amdgpu: reserve the first 2x512 of GART Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=595B4AED.2060008@amd.com \
--to=david1.zhou-5c7gfcevmho@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.