From: "Zhang, Jerry (Junwei)" <Jerry.Zhang-5C7GfCeVMHo@public.gmane.org>
To: Huang Rui <ray.huang-5C7GfCeVMHo@public.gmane.org>
Cc: "Deucher,
Alexander" <Alexander.Deucher-5C7GfCeVMHo@public.gmane.org>,
"Koenig,
Christian" <Christian.Koenig-5C7GfCeVMHo@public.gmane.org>,
"amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
<amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>,
"Zhang, Hawking" <Hawking.Zhang-5C7GfCeVMHo@public.gmane.org>
Subject: Re: [PATCH] drm/amdgpu: set firmware loading type as direct by default for raven
Date: Tue, 4 Jul 2017 18:11:44 +0800 [thread overview]
Message-ID: <595B69E0.2020500@amd.com> (raw)
In-Reply-To: <20170704095902.GA25844@hr-amur2>
On 07/04/2017 05:59 PM, Huang Rui wrote:
> On Tue, Jul 04, 2017 at 05:39:51PM +0800, Zhang, Jerry wrote:
>> Hi Ray,
>>
>> Thanks for your initial patch to enable PSP option for Raven.
>>
>> To simplify it, we may leverage VEGA10 case for Raven directly.
>> And remove all Raven existing code under "case CHIP_RAVEN"
>> How do you think about it?
>>
>
> Probably not. Vega10 enabled psp fw loading by default, but not for raven.
>
> My mainly idea here is
>
> default:
> modprobe amdgpu -> use direct fw loading.
>
> debugging psp:
> modprobe amdgpu fw_load_type=2 -> use psp fw loading.
>
> It doesn't impact other guys use and we can debug it more smoothly. :-)
Thanks to explain it in detail.
Got it.
Feel free to add my RB and we can improve it when everything is settled down.
Reviewed-by: Junwei Zhang <Jerry.Zhang@amd.com>
>
> Thanks,
> Ray
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
prev parent reply other threads:[~2017-07-04 10:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-04 8:35 [PATCH] drm/amdgpu: set firmware loading type as direct by default for raven Huang Rui
[not found] ` <1499157314-28393-1-git-send-email-ray.huang-5C7GfCeVMHo@public.gmane.org>
2017-07-04 9:39 ` Zhang, Jerry (Junwei)
[not found] ` <595B6267.9040600-5C7GfCeVMHo@public.gmane.org>
2017-07-04 9:59 ` Huang Rui
2017-07-04 10:11 ` Zhang, Jerry (Junwei) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=595B69E0.2020500@amd.com \
--to=jerry.zhang-5c7gfcevmho@public.gmane.org \
--cc=Alexander.Deucher-5C7GfCeVMHo@public.gmane.org \
--cc=Christian.Koenig-5C7GfCeVMHo@public.gmane.org \
--cc=Hawking.Zhang-5C7GfCeVMHo@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=ray.huang-5C7GfCeVMHo@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.