From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark yao Subject: Re: [PATCH] drm/rockchip: fix NULL check on devm_kzalloc() return value Date: Fri, 7 Jul 2017 08:56:28 +0800 Message-ID: <595EDC3C.1010801@rock-chips.com> References: <20170706215833.GA25411@embeddedgus> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170706215833.GA25411@embeddedgus> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: "Gustavo A. R. Silva" , David Airlie , Heiko Stuebner Cc: linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: linux-rockchip.vger.kernel.org T24gMjAxN+W5tDA35pyIMDfml6UgMDU6NTgsIEd1c3Rhdm8gQS4gUi4gU2lsdmEgd3JvdGU6Cj4g VGhlIHJpZ2h0IHZhcmlhYmxlIHRvIGNoZWNrIGhlcmUgaXMgcG9ydCwgbm90IGRwLgo+Cj4gVGhp cyBpc3N1ZSB3YXMgZGV0ZWN0ZWQgdXNpbmcgQ29jY2luZWxsZSBhbmQgdGhlIGZvbGxvd2luZyBz ZW1hbnRpYyBwYXRjaDoKPgo+IEBACj4gZXhwcmVzc2lvbiB4Owo+IGlkZW50aWZpZXIgZmxkOwo+ IEBACj4KPiAqIHggPSBkZXZtX2t6YWxsb2MoLi4uKTsKPiAgICAuLi4gd2hlbiAhPSB4ID09IE5V TEwKPiAgICB4LT5mbGQKPgo+IFNpZ25lZC1vZmYtYnk6IEd1c3Rhdm8gQS4gUi4gU2lsdmEgPGdh cnNpbHZhQGVtYmVkZGVkb3IuY29tPgoKVGhhbmtzIGZvciB0aGUgZml4LAoKQWNrZWQtYnk6IE1h cmsgWWFvIDxtYXJrLnlhb0Byb2NrLWNoaXBzLmNvbT4KCj4gLS0tCj4gICBkcml2ZXJzL2dwdS9k cm0vcm9ja2NoaXAvY2RuLWRwLWNvcmUuYyB8IDIgKy0KPiAgIDEgZmlsZSBjaGFuZ2VkLCAxIGlu c2VydGlvbigrKSwgMSBkZWxldGlvbigtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9yb2NrY2hpcC9jZG4tZHAtY29yZS5jIGIvZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL2Nkbi1k cC1jb3JlLmMKPiBpbmRleCAxNGZhMWY4Li45YjBiMDU4IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9yb2NrY2hpcC9jZG4tZHAtY29yZS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3Jv Y2tjaGlwL2Nkbi1kcC1jb3JlLmMKPiBAQCAtMTE5NSw3ICsxMTk1LDcgQEAgc3RhdGljIGludCBj ZG5fZHBfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPiAgIAkJCWNvbnRpbnVl Owo+ICAgCj4gICAJCXBvcnQgPSBkZXZtX2t6YWxsb2MoZGV2LCBzaXplb2YoKnBvcnQpLCBHRlBf S0VSTkVMKTsKPiAtCQlpZiAoIWRwKQo+ICsJCWlmICghcG9ydCkKPiAgIAkJCXJldHVybiAtRU5P TUVNOwo+ICAgCj4gICAJCXBvcnQtPmV4dGNvbiA9IGV4dGNvbjsKCgotLSAK77ytYXJrIFlhbwoK Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZl bCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: mark.yao@rock-chips.com (Mark yao) Date: Fri, 7 Jul 2017 08:56:28 +0800 Subject: [PATCH] drm/rockchip: fix NULL check on devm_kzalloc() return value In-Reply-To: <20170706215833.GA25411@embeddedgus> References: <20170706215833.GA25411@embeddedgus> Message-ID: <595EDC3C.1010801@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2017?07?07? 05:58, Gustavo A. R. Silva wrote: > The right variable to check here is port, not dp. > > This issue was detected using Coccinelle and the following semantic patch: > > @@ > expression x; > identifier fld; > @@ > > * x = devm_kzalloc(...); > ... when != x == NULL > x->fld > > Signed-off-by: Gustavo A. R. Silva Thanks for the fix, Acked-by: Mark Yao > --- > drivers/gpu/drm/rockchip/cdn-dp-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/rockchip/cdn-dp-core.c > index 14fa1f8..9b0b058 100644 > --- a/drivers/gpu/drm/rockchip/cdn-dp-core.c > +++ b/drivers/gpu/drm/rockchip/cdn-dp-core.c > @@ -1195,7 +1195,7 @@ static int cdn_dp_probe(struct platform_device *pdev) > continue; > > port = devm_kzalloc(dev, sizeof(*port), GFP_KERNEL); > - if (!dp) > + if (!port) > return -ENOMEM; > > port->extcon = extcon; -- ?ark Yao From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753152AbdGGA44 (ORCPT ); Thu, 6 Jul 2017 20:56:56 -0400 Received: from regular1.263xmail.com ([211.150.99.140]:59200 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752967AbdGGA4z (ORCPT ); Thu, 6 Jul 2017 20:56:55 -0400 X-263anti-spam: KSV:0;BIG:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ADDR-CHECKED4: 1 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ANTISPAM-LEVEL: 2 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: linux-kernel@vger.kernel.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: <3c2c0ad3101c289b19a3545bafb85255> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH] drm/rockchip: fix NULL check on devm_kzalloc() return value To: "Gustavo A. R. Silva" , David Airlie , Heiko Stuebner References: <20170706215833.GA25411@embeddedgus> Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org From: Mark yao Message-ID: <595EDC3C.1010801@rock-chips.com> Date: Fri, 7 Jul 2017 08:56:28 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20170706215833.GA25411@embeddedgus> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017年07月07日 05:58, Gustavo A. R. Silva wrote: > The right variable to check here is port, not dp. > > This issue was detected using Coccinelle and the following semantic patch: > > @@ > expression x; > identifier fld; > @@ > > * x = devm_kzalloc(...); > ... when != x == NULL > x->fld > > Signed-off-by: Gustavo A. R. Silva Thanks for the fix, Acked-by: Mark Yao > --- > drivers/gpu/drm/rockchip/cdn-dp-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/rockchip/cdn-dp-core.c > index 14fa1f8..9b0b058 100644 > --- a/drivers/gpu/drm/rockchip/cdn-dp-core.c > +++ b/drivers/gpu/drm/rockchip/cdn-dp-core.c > @@ -1195,7 +1195,7 @@ static int cdn_dp_probe(struct platform_device *pdev) > continue; > > port = devm_kzalloc(dev, sizeof(*port), GFP_KERNEL); > - if (!dp) > + if (!port) > return -ENOMEM; > > port->extcon = extcon; -- Ｍark Yao