From: Chanwoo Choi <cw00.choi@samsung.com>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>, myungjoo.ham@samsung.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] extcon: int3496: constify acpi_device_id.
Date: Fri, 07 Jul 2017 13:13:09 +0900 [thread overview]
Message-ID: <595F0A55.9070801@samsung.com> (raw)
In-Reply-To: <dcce788befa9d8e0fa849c21229ea356efdb70b0.1499360077.git.arvind.yadav.cs@gmail.com>
On 2017년 07월 07일 01:55, Arvind Yadav wrote:
> acpi_device_id are not supposed to change at runtime. All functions
> working with acpi_device_id provided by <acpi/acpi_bus.h> work with
> const acpi_device_id. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 1733 352 0 2085 825 drivers/extcon/extcon-intel-int3496.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 1797 272 0 2069 815 drivers/extcon/extcon-intel-int3496.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> drivers/extcon/extcon-intel-int3496.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/extcon/extcon-intel-int3496.c b/drivers/extcon/extcon-intel-int3496.c
> index 9d17984..49bf9c6 100644
> --- a/drivers/extcon/extcon-intel-int3496.c
> +++ b/drivers/extcon/extcon-intel-int3496.c
> @@ -174,7 +174,7 @@ static int int3496_remove(struct platform_device *pdev)
> return 0;
> }
>
> -static struct acpi_device_id int3496_acpi_match[] = {
> +static const struct acpi_device_id int3496_acpi_match[] = {
> { "INT3496" },
> { }
> };
>
Applied it.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
prev parent reply other threads:[~2017-07-07 4:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170706165618epcas5p1b527daa8f6674282d0bf72fc9bad9461@epcas5p1.samsung.com>
2017-07-06 16:55 ` [PATCH] extcon: int3496: constify acpi_device_id Arvind Yadav
2017-07-07 4:13 ` Chanwoo Choi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=595F0A55.9070801@samsung.com \
--to=cw00.choi@samsung.com \
--cc=arvind.yadav.cs@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.