Re: [PATCH v4 0/8] powerpc: Testcase improvements and Power8E/NVL removal

[Aditya Gupta <adityag@linux.ibm.com>]

On 01/07/26 02:33, Aditya Gupta wrote:

> Overview
> ========
>
> This patch series merged two patch series sent earlier:
> 	"Testcase improvements for PowerNV"
> 	"Remove deprecated Power8E and 8NVL CPUs"
> since the Power8E removal series depended on the former due to pnv-spi test
>
> Broadly contains 3 changes:
> 1. Testcase improvements:
>      Add a testcase to detect regression in remote interrupts when XIVE changes,
>      since such regression had occurred during Power11 XIVE changes:
>      https://lore.kernel.org/qemu-devel/baf6c854-832b-4a2e-922f-d34e6dadf821@redhat.com/
>
>      Also add Power11 chip and testcase in qtests, and fadump functional test
>
> 2. Power8E/Power8NVL removal
>      Power8E and Power8NVL were deprecated since QEMU 10.1, with
>      commit 264a604e7163 ("target/ppc: Deprecate Power8E and Power8NVL")
>      
>      Hence, remove usage (chip and core types) of Power8E and 8NVL from PowerNV,
>      PSeries as well as testcases.
>
> 3. Maintainer changes
>      Add myself as maintainer for PowerNV machine
>
> Testing
> =======
>
> * Git tree for testing: https://gitlab.com/adi-g15-ibm/qemu/tree/feat_maintainer-v4
> * Gitlab pipeline: https://gitlab.com/adi-g15-ibm/qemu/-/pipelines/2641510943
> * Successful ppc64 functional tests, qtests, boot tests, builds at all commits
>
> Changelog
> =========
> v4:
> + #1: added cores=1, as suggested by cedric, no functional change
> + #3: remove unneeded headers, as suggested by cedric
> + #3: keep power10 xive2 test, as suggested by nikhil
>
> v3:
> + #3: use machine_type array in pnv_xscom_addr, as suggested by shivang, harsh and balaton
>
> v2:
> + #1: put e1000e on socket 1, and disable it's cpu, as suggested by cedric
> + #1: pull out command fail checks into a helper, as suggested by shivang
> + #2: use g_autofree, suggested by cedric
> + #3: use g_autofree in tests updated
> + #8: remove G:, as suggested by daniel
> + rebased to upstream
>
> from previous split series:
> + #1: added checks to see if network is up and interrupts happened, based on shivang's review
> + #3: replaced common if-else-if check for machine type with pnv_get_machine_type
> + #7: added doc in removed-features, as suggested by cedric
> + #6,7: added rb from philippe
> + #8: new patch, maintainer change
>
> Aditya Gupta (8):
>    tests/functional: Add remote interrupts test for PowerNV
>    tests/qtest/pnv_spi: Test Power11 PNV_SPI
>    tests/qtest: Add Power11 chip & machine to qtests
>    tests/functional: Use default powernv machine instead of power10
>    ppc/pnv: Replace Power8E with Power11 for 'none' machine test
>    ppc/pnv: Remove Power8E and Power8NVL pnv chips
>    ppc/pnv: Remove Power8E and Power8NVL CPUs
>    MAINTAINERS: Add self as maintainer for PowerNV
>
>   MAINTAINERS                            |  2 +-
>   docs/about/deprecated.rst              |  9 ---
>   docs/about/removed-features.rst        |  8 +++
>   docs/system/ppc/powernv.rst            |  2 +-
>   docs/system/ppc/pseries.rst            |  2 +-
>   hw/ppc/pnv.c                           | 62 -----------------
>   hw/ppc/pnv_core.c                      |  2 -
>   hw/ppc/spapr_cpu_core.c                |  2 -
>   include/hw/ppc/pnv.h                   |  8 ---
>   target/ppc/cpu-models.c                |  6 --
>   target/ppc/cpu-models.h                |  4 --
>   target/ppc/cpu_init.c                  |  6 --
>   target/ppc/kvm.c                       |  4 +-
>   tests/functional/ppc64/test_fadump.py  |  2 +-
>   tests/functional/ppc64/test_powernv.py | 95 ++++++++++++++++++++++++++
>   tests/qtest/machine-none-test.c        |  2 +-
>   tests/qtest/pnv-host-i2c-test.c        | 10 ++-
>   tests/qtest/pnv-spi-seeprom-test.c     | 20 ++++--
>   tests/qtest/pnv-xive2-test.c           | 21 ++++--
>   tests/qtest/pnv-xscom-test.c           | 22 ++----
>   tests/qtest/pnv-xscom.h                | 38 +++++++----
>   21 files changed, 175 insertions(+), 152 deletions(-)

Hi Glenn,

Do you have any comments on the series, can you give an ack or rb ?


Thanks,
- Aditya G

>
> base-commit: 30e8a06b64aa58a3990ba39cb5d09531e7d265e0