From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Masoud Hasanifard <masoudhasanifard@gmail.com>
Cc: dev@dpdk.org, "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Subject: Re: [PATCH] hash: Correctly set the compare function.
Date: Thu, 22 Sep 2016 17:42:55 +0200 [thread overview]
Message-ID: <5960468.PdAfGihvNv@xps13> (raw)
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8973C9F8E0E@IRSMSX108.ger.corp.intel.com>
2016-09-19 18:36, De Lara Guarch, Pablo:
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Masoud
> Commit titles start with lowercase ("correctly") and without a dot at the end.
> >
> > Set cmp_jump_table_idx to KEY_CUSTOM in rte_hash_cmp_eq so that the
> > custom
> > function we are setting in rte_hash_set_cmp_func properly works. The
> > custom
> > function is only called by rte_hash_cmp_eq if cmp_jump_table_idx is set to
> > KEY_CUSTOM.
>
> I think this is a fix, so probably it should contain the following "Fixes" line in the commit message:
> Fixes: 95da2f8e9c61 ("hash: customize compare function")
[...]
> Good catch! Two comments inline.
Applied, thanks
prev parent reply other threads:[~2016-09-22 15:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-17 9:43 [PATCH] hash: Correctly set the compare function Masoud Hasanifard
2016-09-19 18:36 ` De Lara Guarch, Pablo
2016-09-21 21:29 ` Thomas Monjalon
2016-09-21 21:30 ` De Lara Guarch, Pablo
2016-09-22 15:42 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5960468.PdAfGihvNv@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=masoudhasanifard@gmail.com \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.