All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Beulich <jbeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: "Roger Pau Monné" <roger.pau@citrix.com>,
	"Daniel P . Smith" <dpsmith@apertussolutions.com>,
	"Frediano Ziglio" <frediano.ziglio@cloud.com>,
	"Alejandro Vallejo" <alejandro.vallejo@cloud.com>,
	Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 2/2] x86/trampoline: Rationalise the constants to describe the size
Date: Wed, 13 Nov 2024 11:23:17 +0100	[thread overview]
Message-ID: <5961777b-2d38-4edd-b2e0-2da89862655c@suse.com> (raw)
In-Reply-To: <20241113093058.1562447-3-andrew.cooper3@citrix.com>

On 13.11.2024 10:30, Andrew Cooper wrote:
> --- a/xen/arch/x86/include/asm/config.h
> +++ b/xen/arch/x86/include/asm/config.h
> @@ -51,8 +51,9 @@
>  
>  #define IST_SHSTK_SIZE 1024
>  
> -#define TRAMPOLINE_STACK_SPACE  PAGE_SIZE
> -#define TRAMPOLINE_SPACE        (KB(64) - TRAMPOLINE_STACK_SPACE)
> +/* See asm/trampoline.h */
> +#define TRAMPOLINE_SIZE         KB(64)
> +#define TRAMPOLINE_HEAP_END     (TRAMPOLINE_SIZE - PAGE_SIZE)

Is there actually a reason these can't move to trampoline.h?

Jan



  parent reply	other threads:[~2024-11-13 10:23 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-13  9:30 [PATCH 0/2] x86/trampoline: Layout description improvements Andrew Cooper
2024-11-13  9:30 ` [PATCH 1/2] x86/trampoline: Document how the trampoline is laid out Andrew Cooper
2024-11-13 10:20   ` Jan Beulich
2024-11-13 11:19     ` Andrew Cooper
2024-11-13 11:23       ` Frediano Ziglio
2024-11-13 11:24       ` Jan Beulich
2024-11-13 11:26       ` Jan Beulich
2024-11-13  9:30 ` [PATCH 2/2] x86/trampoline: Rationalise the constants to describe the size Andrew Cooper
2024-11-13 10:18   ` Frediano Ziglio
2024-11-13 10:58     ` Frediano Ziglio
2024-11-13 10:23   ` Jan Beulich [this message]
2024-11-13 11:52     ` Andrew Cooper
2024-11-13 12:00       ` Jan Beulich
2024-11-13 11:36   ` Andrew Cooper
2024-11-13 11:51     ` Frediano Ziglio
2024-11-13 12:02     ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5961777b-2d38-4edd-b2e0-2da89862655c@suse.com \
    --to=jbeulich@suse.com \
    --cc=alejandro.vallejo@cloud.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=dpsmith@apertussolutions.com \
    --cc=frediano.ziglio@cloud.com \
    --cc=roger.pau@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.