From: David Howells <dhowells@redhat.com>
To: Michael Cree <mcree@orcon.net.nz>
Cc: dhowells@redhat.com, linux-alpha@vger.kernel.org,
linux-kernel@vger.kernel.org, rth@twiddle.net,
ink@jurassic.park.msu.ru
Subject: Re: Alpha: suspicious compiler warning in entry.S
Date: Fri, 30 Oct 2009 13:16:59 +0000 [thread overview]
Message-ID: <5962.1256908619@redhat.com> (raw)
In-Reply-To: <4AE7ECC2.8050202@orcon.net.nz>
Michael Cree <mcree@orcon.net.nz> wrote:
> On the assumption that it is important to include the TIF_NOTIFY_RESUME bit
> one might be tempted to modify the code to:
>
> lda $2, _TIF_WORK_MASK
> and $5, $2, $2
>
> but this is time critical code. I am wondering whether it might be better
> to rearrange the bits in the thread information flags so that _TIF_WORK_MASK
> has a value less than 255 and the single instruction to perform an and
> operation can be maintained.
Unless the LDA can be interleaved around some memory accesses, then yes,
compressing _TIF_WORK_MASK would be good.
David
prev parent reply other threads:[~2009-10-30 13:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-28 7:03 Alpha: suspicious compiler warning in entry.S Michael Cree
2009-10-28 23:13 ` Richard Henderson
2009-10-31 2:33 ` [PATCH] Alpha: Rearrange thread info flags fixing two regressions Michael Cree
2009-12-01 4:06 ` Matt Turner
2009-12-01 4:06 ` Matt Turner
2009-12-01 12:31 ` Christoph Hellwig
2009-12-01 15:58 ` Matt Turner
2009-10-30 13:16 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5962.1256908619@redhat.com \
--to=dhowells@redhat.com \
--cc=ink@jurassic.park.msu.ru \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcree@orcon.net.nz \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.