From: Menglong Dong <menglong.dong@linux.dev>
To: Yonghong Song <yonghong.song@linux.dev>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <martin.lau@linux.dev>,
Eduard Zingerman <eddyz87@gmail.com>, Song Liu <song@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@fomichev.me>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>,
Alan Maguire <alan.maguire@oracle.com>,
"T.J. Mercier" <tjmercier@google.com>
Cc: "T.J. Mercier" <tjmercier@google.com>,
bpf@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bpf: Fix bpf_seq_read docs for increased buffer size
Date: Sun, 07 Dec 2025 13:07:58 +0800 [thread overview]
Message-ID: <5964481.DvuYhMxLoT@7950hx> (raw)
In-Reply-To: <20251207005854.2708338-1-tjmercier@google.com>
On 12/7/25 8:58 AM, T.J. Mercier wrote:
> Commit af65320948b8 ("bpf: Bump iter seq size to support BTF
> representation of large data structures") increased the fixed buffer
> size from PAGE_SIZE to PAGE_SIZE << 3, but the docs for the function
> didn't get updated at the same time. Update them.
>
> Fixes: af65320948b8 ("bpf: Bump iter seq size to support BTF representation of large data structures")
I think we don't need the "Fixes" tag for the document fix?
Therefore, it's better to go to the "bpf-next" tree with the
corresponding tag:
[PATCH bpf-next]
Thanks!
Menglong Dong
> Signed-off-by: T.J. Mercier <tjmercier@google.com>
> ---
> kernel/bpf/bpf_iter.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/bpf/bpf_iter.c b/kernel/bpf/bpf_iter.c
> index eec60b57bd3d..4b58d56ecab1 100644
> --- a/kernel/bpf/bpf_iter.c
> +++ b/kernel/bpf/bpf_iter.c
> @@ -86,7 +86,7 @@ static bool bpf_iter_support_resched(struct seq_file *seq)
>
> /* bpf_seq_read, a customized and simpler version for bpf iterator.
> * The following are differences from seq_read():
> - * . fixed buffer size (PAGE_SIZE)
> + * . fixed buffer size (PAGE_SIZE << 3)
> * . assuming NULL ->llseek()
> * . stop() may call bpf program, handling potential overflow there
> */
>
next prev parent reply other threads:[~2025-12-07 5:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-07 0:58 [PATCH] bpf: Fix bpf_seq_read docs for increased buffer size T.J. Mercier
2025-12-07 5:07 ` Menglong Dong [this message]
2025-12-07 9:12 ` T.J. Mercier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5964481.DvuYhMxLoT@7950hx \
--to=menglong.dong@linux.dev \
--cc=alan.maguire@oracle.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=sdf@fomichev.me \
--cc=song@kernel.org \
--cc=tjmercier@google.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.