From: Daniel Borkmann <daniel@iogearbox.net>
To: Jesper Dangaard Brouer <brouer@redhat.com>, Yonghong Song <yhs@fb.com>
Cc: ast@fb.com, brakmo@fb.com, netdev@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH net v2] samples/bpf: fix a build issue
Date: Tue, 11 Jul 2017 22:02:27 +0200 [thread overview]
Message-ID: <59652ED3.5020607@iogearbox.net> (raw)
In-Reply-To: <20170711215114.4726d1da@redhat.com>
On 07/11/2017 09:51 PM, Jesper Dangaard Brouer wrote:
> On Mon, 10 Jul 2017 14:04:28 -0700 Yonghong Song <yhs@fb.com> wrote:
>
>> With latest net-next:
>> ====
>> clang -nostdinc -isystem /usr/lib/gcc/x86_64-redhat-linux/6.3.1/include -I./arch/x86/include -I./arch/x86/include/generated/uapi -I./arch/x86/include/generated -I./include -I./arch/x86/include/uapi -I./include/uapi -I./include/generated/uapi -include ./include/linux/kconfig.h -Isamples/bpf \
>> -D__KERNEL__ -D__ASM_SYSREG_H -Wno-unused-value -Wno-pointer-sign \
>> -Wno-compare-distinct-pointer-types \
>> -Wno-gnu-variable-sized-type-not-at-end \
>> -Wno-address-of-packed-member -Wno-tautological-compare \
>> -Wno-unknown-warning-option \
>> -O2 -emit-llvm -c samples/bpf/tcp_synrto_kern.c -o -| llc -march=bpf -filetype=obj -o samples/bpf/tcp_synrto_kern.o
>> samples/bpf/tcp_synrto_kern.c:20:10: fatal error: 'bpf_endian.h' file not found
>> ^~~~~~~~~~~~~~
>> 1 error generated.
>> ====
>>
>> net has the same issue.
>>
>> Add support for ntohl and htonl in tools/testing/selftests/bpf/bpf_endian.h.
>
> I think this patch should have been split up in two patches. One where
> you fix the compile issue, and one where you add support for ntohl and
> htonl. And you are also moving the file... I'm getting confused
> reading this patch.
Could have been done, sure. Patch is still straight forward and small as-is,
so I don't really mind having this user space code squashed together.
next prev parent reply other threads:[~2017-07-11 20:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-10 21:04 [PATCH net v2] samples/bpf: fix a build issue Yonghong Song
2017-07-10 21:13 ` Daniel Borkmann
2017-07-10 22:10 ` Lawrence Brakmo
2017-07-11 19:51 ` Jesper Dangaard Brouer
2017-07-11 20:02 ` Daniel Borkmann [this message]
2017-07-12 3:51 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59652ED3.5020607@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=ast@fb.com \
--cc=brakmo@fb.com \
--cc=brouer@redhat.com \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.