From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark yao Subject: Re: [PATCH 5/5] dt-bindings: display: fill Documents for series of vop Date: Wed, 12 Jul 2017 08:21:00 +0800 Message-ID: <59656B6C.5020308@rock-chips.com> References: <1499776908-16811-1-git-send-email-mark.yao@rock-chips.com> <1499776958-17062-1-git-send-email-mark.yao@rock-chips.com> <7391489.lxuf2bMt0N@diego> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <7391489.lxuf2bMt0N@diego> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: =?UTF-8?Q?Heiko_St=c3=bcbner?= Cc: Mark Rutland , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Rob Herring , linux-arm-kernel@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org T24gMjAxN+W5tDA35pyIMTHml6UgMjA6NDUsIEhlaWtvIFN0w7xibmVyIHdyb3RlOgo+IEhpIE1h cmssCj4KPiBBbSBEaWVuc3RhZywgMTEuIEp1bGkgMjAxNywgMjA6NDI6MzggQ0VTVCBzY2hyaWVi IE1hcmsgWWFvOgo+PiBTaWduZWQtb2ZmLWJ5OiBNYXJrIFlhbyA8bWFyay55YW9Acm9jay1jaGlw cy5jb20+Cj4+IC0tLQo+PiAgIERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9kaXNw bGF5L3JvY2tjaGlwL3JvY2tjaGlwLXZvcC50eHQgfCA0Cj4+ICsrKysgMSBmaWxlIGNoYW5nZWQs IDQgaW5zZXJ0aW9ucygrKQo+Pgo+PiBkaWZmIC0tZ2l0Cj4+IGEvRG9jdW1lbnRhdGlvbi9kZXZp Y2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvcm9ja2NoaXAvcm9ja2NoaXAtdm9wLnR4dAo+PiBiL0Rv Y3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9kaXNwbGF5L3JvY2tjaGlwL3JvY2tjaGlw LXZvcC50eHQgaW5kZXgKPj4gOWViM2YwYS4uMTFmYTNiMCAxMDA2NDQKPj4gLS0tIGEvRG9jdW1l bnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvcm9ja2NoaXAvcm9ja2NoaXAtdm9w LnR4dAo+PiArKysgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZGlzcGxheS9y b2NrY2hpcC9yb2NrY2hpcC12b3AudHh0Cj4+IEBAIC04LDggKzgsMTIgQEAgUmVxdWlyZWQgcHJv cGVydGllczoKPj4gICAtIGNvbXBhdGlibGU6IHZhbHVlIHNob3VsZCBiZSBvbmUgb2YgdGhlIGZv bGxvd2luZwo+PiAgIAkJInJvY2tjaGlwLHJrMzAzNi12b3AiOwo+PiAgIAkJInJvY2tjaGlwLHJr MzI4OC12b3AiOwo+PiArCQkicm9ja2NoaXAscmszMzY4LXZvcCI7Cj4+ICsJCSJyb2NrY2hpcCxy azMzNjYtdm9wIjsKPj4gICAJCSJyb2NrY2hpcCxyazMzOTktdm9wLWJpZyI7Cj4+ICAgCQkicm9j a2NoaXAscmszMzk5LXZvcC1saXQiOwo+PiArCQkicm9ja2NoaXAscmszMjJ4LXZvcCI7Cj4gcGxl YXNlIGRvbid0IHVzZSB3aWxkY2FyZHMgaW4gZGV2aWNldHJlZSBjb21wYXRpYmxlcy4gV2UndmUg c29tZWhvdwo+IHN0YW5kYXJkaXplZCBvbiB1c2luZyByazMyMjggZm9yIGJvdGggdGhlIHJrMzIy OCBhbmQgcmszMjI5ICh3aGljaCBhcmUKPiBuZWFybHkgdGhlIHNhbWUgc29jIHdpdGggc29tZSBz cGVlZCBhZGp1c3RtZW50cykKPgo+IFNvLAo+ICsJCSJyb2NrY2hpcCxyazMyMjgtdm9wIjsKPiBw bGVhc2UKPgo+Cj4gVGhhbmtzCj4gSGVpa28KCkdvdCBpdCwgSSB3aWxsIGZpeCBpdCBhdCBuZXh0 IHZlcnNpb24KClRoYW5rcwpNYXJrCgo+Cj4+ICsJCSJyb2NrY2hpcCxyazMzMjgtdm9wIjsKPj4K Pj4gICAtIGludGVycnVwdHM6IHNob3VsZCBjb250YWluIGEgbGlzdCBvZiBhbGwgVk9QIElQIGJs b2NrIGludGVycnVwdHMgaW4gdGhlCj4+ICAgCQkgb3JkZXI6IFZTWU5DLCBMQ0RfU1lTVEVNLiBU aGUgaW50ZXJydXB0IHNwZWNpZmllcgo+Cj4KPgo+CgoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: mark.yao@rock-chips.com (Mark yao) Date: Wed, 12 Jul 2017 08:21:00 +0800 Subject: [PATCH 5/5] dt-bindings: display: fill Documents for series of vop In-Reply-To: <7391489.lxuf2bMt0N@diego> References: <1499776908-16811-1-git-send-email-mark.yao@rock-chips.com> <1499776958-17062-1-git-send-email-mark.yao@rock-chips.com> <7391489.lxuf2bMt0N@diego> Message-ID: <59656B6C.5020308@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2017?07?11? 20:45, Heiko St?bner wrote: > Hi Mark, > > Am Dienstag, 11. Juli 2017, 20:42:38 CEST schrieb Mark Yao: >> Signed-off-by: Mark Yao >> --- >> Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt | 4 >> ++++ 1 file changed, 4 insertions(+) >> >> diff --git >> a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt >> b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt index >> 9eb3f0a..11fa3b0 100644 >> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt >> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt >> @@ -8,8 +8,12 @@ Required properties: >> - compatible: value should be one of the following >> "rockchip,rk3036-vop"; >> "rockchip,rk3288-vop"; >> + "rockchip,rk3368-vop"; >> + "rockchip,rk3366-vop"; >> "rockchip,rk3399-vop-big"; >> "rockchip,rk3399-vop-lit"; >> + "rockchip,rk322x-vop"; > please don't use wildcards in devicetree compatibles. We've somehow > standardized on using rk3228 for both the rk3228 and rk3229 (which are > nearly the same soc with some speed adjustments) > > So, > + "rockchip,rk3228-vop"; > please > > > Thanks > Heiko Got it, I will fix it at next version Thanks Mark > >> + "rockchip,rk3328-vop"; >> >> - interrupts: should contain a list of all VOP IP block interrupts in the >> order: VSYNC, LCD_SYSTEM. The interrupt specifier > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755911AbdGLAVL (ORCPT ); Tue, 11 Jul 2017 20:21:11 -0400 Received: from regular1.263xmail.com ([211.150.99.136]:53385 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754135AbdGLAVK (ORCPT ); Tue, 11 Jul 2017 20:21:10 -0400 X-263anti-spam: KSV:0;BIG:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ADDR-CHECKED4: 1 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ANTISPAM-LEVEL: 2 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: linux-kernel@vger.kernel.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH 5/5] dt-bindings: display: fill Documents for series of vop To: =?UTF-8?Q?Heiko_St=c3=bcbner?= References: <1499776908-16811-1-git-send-email-mark.yao@rock-chips.com> <1499776958-17062-1-git-send-email-mark.yao@rock-chips.com> <7391489.lxuf2bMt0N@diego> Cc: David Airlie , Rob Herring , Mark Rutland , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org From: Mark yao Message-ID: <59656B6C.5020308@rock-chips.com> Date: Wed, 12 Jul 2017 08:21:00 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <7391489.lxuf2bMt0N@diego> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017年07月11日 20:45, Heiko Stübner wrote: > Hi Mark, > > Am Dienstag, 11. Juli 2017, 20:42:38 CEST schrieb Mark Yao: >> Signed-off-by: Mark Yao >> --- >> Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt | 4 >> ++++ 1 file changed, 4 insertions(+) >> >> diff --git >> a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt >> b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt index >> 9eb3f0a..11fa3b0 100644 >> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt >> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt >> @@ -8,8 +8,12 @@ Required properties: >> - compatible: value should be one of the following >> "rockchip,rk3036-vop"; >> "rockchip,rk3288-vop"; >> + "rockchip,rk3368-vop"; >> + "rockchip,rk3366-vop"; >> "rockchip,rk3399-vop-big"; >> "rockchip,rk3399-vop-lit"; >> + "rockchip,rk322x-vop"; > please don't use wildcards in devicetree compatibles. We've somehow > standardized on using rk3228 for both the rk3228 and rk3229 (which are > nearly the same soc with some speed adjustments) > > So, > + "rockchip,rk3228-vop"; > please > > > Thanks > Heiko Got it, I will fix it at next version Thanks Mark > >> + "rockchip,rk3328-vop"; >> >> - interrupts: should contain a list of all VOP IP block interrupts in the >> order: VSYNC, LCD_SYSTEM. The interrupt specifier > > > >