All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tao Cui <cui.tao@linux.dev>
To: Tejun Heo <tj@kernel.org>
Cc: cui.tao@linux.dev, void@manifault.com, arighi@nvidia.com,
	changwoo@igalia.com, suzhidao@xiaomi.com, emil@etsalapatis.com,
	sched-ext@lists.linux.dev, linux-kernel@vger.kernel.org,
	bpf@vger.kernel.org, cuitao@kylinos.cn
Subject: Re: [PATCH v2] sched_ext: pass the initial cpu.idle state in scx_cgroup_init_args
Date: Tue, 25 Aug 2026 10:26:51 +0800	[thread overview]
Message-ID: <596acf85-5332-463b-a4d0-a8fcfca903a5@linux.dev> (raw)
In-Reply-To: <20eb5e65cb330a6f9cc41781af302873@kernel.org>

Hello, Tejun,

在 2026/8/25 00:54, Tejun Heo 写道:
> Hello, Tao.
> 
> On Mon, Aug 24, 2026 at 10:28:16PM +0800, Tao Cui wrote:
>> +
>> +	/* whether the cgroup is configured idle via cpu.idle */
>> +	bool			idle;
> 
> In sched_ext, a bare "idle" reads as CPU idle state (ops.update_idle(),
> idle cpumasks, scx_bpf_pick_idle_cpu()). cpu.idle is the cgroup analog
> of the SCHED_IDLE policy, so please name the field sched_idle instead.
> Renaming tg->scx.idle to match would be nice too.
> 

Thanks for the review. Both are renamed in v3: the new
scx_cgroup_init_args field, and tg->scx.idle -> tg->scx.sched_idle
as a separate second patch in the series, so 1/2 stays minimal for
stable backport.

Thanks,
Tao

> Thanks.
> 


      reply	other threads:[~2026-08-25  2:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-24 14:28 [PATCH v2] sched_ext: pass the initial cpu.idle state in scx_cgroup_init_args Tao Cui
2026-08-24 15:07 ` Andrea Righi
2026-08-25  2:20   ` Tao Cui
2026-08-24 16:54 ` Tejun Heo
2026-08-25  2:26   ` Tao Cui [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=596acf85-5332-463b-a4d0-a8fcfca903a5@linux.dev \
    --to=cui.tao@linux.dev \
    --cc=arighi@nvidia.com \
    --cc=bpf@vger.kernel.org \
    --cc=changwoo@igalia.com \
    --cc=cuitao@kylinos.cn \
    --cc=emil@etsalapatis.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sched-ext@lists.linux.dev \
    --cc=suzhidao@xiaomi.com \
    --cc=tj@kernel.org \
    --cc=void@manifault.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.