From: jeffy <jeffy.chen@rock-chips.com>
To: Oliver Neukum <oneukum@suse.com>, linux-kernel@vger.kernel.org
Cc: briannorris@chromium.org, dianders@chromium.org,
Johan Hedberg <johan.hedberg@gmail.com>,
xiyou.wangcong@gmail.com, Marcel Holtmann <marcel@holtmann.org>,
Gustavo Padovan <gustavo@padovan.org>,
linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v5] Bluetooth: btusb: Fix memory leak in play_deferred
Date: Thu, 20 Jul 2017 18:56:08 +0800 [thread overview]
Message-ID: <59708C48.3020500@rock-chips.com> (raw)
In-Reply-To: <1500541861.10409.2.camel@suse.com>
Hi Oliver,
On 07/20/2017 05:11 PM, Oliver Neukum wrote:
>> >+ if (err < 0) {
>> >+ if (err != -EPERM && err != -ENODEV)
>> >+ BT_ERR("%s urb %p submission failed (%d)",
>> >+ data->hdev->name, urb, -err);
>> >+ kfree(urb->setup_packet);
>> >+ usb_unanchor_urb(urb);
>> >+ usb_free_urb(urb);
>> > break;
>> >+ }
>> >
>> > data->tx_in_flight++;
>> >+ usb_free_urb(urb);
>> >+ }
>> >+
>> >+ /* Cleanup the rest deferred urbs. */
>> >+ while ((urb = usb_get_from_anchor(&data->deferred))) {
>> >+ BT_ERR("%s urb %p submission failed (%d)",
> This looks very good, except for this message, which is incorrect.
>
hmm, since we already print error log when submission failed before,
i'll remove this, thanks.
prev parent reply other threads:[~2017-07-20 10:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-20 0:42 [PATCH v5] Bluetooth: btusb: Fix memory leak in play_deferred Jeffy Chen
2017-07-20 9:11 ` Oliver Neukum
2017-07-20 10:56 ` jeffy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59708C48.3020500@rock-chips.com \
--to=jeffy.chen@rock-chips.com \
--cc=briannorris@chromium.org \
--cc=dianders@chromium.org \
--cc=gustavo@padovan.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=oneukum@suse.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.