From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yunlong Song Subject: Re: [PATCH] f2fs: let __get_victim successfully get a segno in corner case Date: Thu, 20 Jul 2017 20:27:11 +0800 Message-ID: <5970A19F.4030000@huawei.com> References: <1500033432-57620-1-git-send-email-yunlong.song@huawei.com> <20170716010934.GC51202@jaegeuk-macbookpro.roam.corp.google.com> <3b3c1eba.b25.15d495786fe.Coremail.sylinux@163.com> <20170717165636.GB81128@jaegeuk-macbookpro.roam.corp.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from sog-mx-3.v43.ch3.sourceforge.com ([172.29.43.193] helo=mx.sourceforge.net) by sfs-ml-1.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1dYAYZ-000824-Ue for linux-f2fs-devel@lists.sourceforge.net; Thu, 20 Jul 2017 12:27:51 +0000 Received: from szxga03-in.huawei.com ([45.249.212.189]) by sog-mx-3.v43.ch3.sourceforge.com with esmtps (TLSv1:RC4-SHA:128) (Exim 4.76) id 1dYAYX-0008VI-NL for linux-f2fs-devel@lists.sourceforge.net; Thu, 20 Jul 2017 12:27:51 +0000 In-Reply-To: <20170717165636.GB81128@jaegeuk-macbookpro.roam.corp.google.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net To: Jaegeuk Kim , sylinux Cc: chao , linux-kernel , linux-f2fs-devel , linux-fsdevel SGksIEpheSwKICAgIFRoZSBkaXN0cmlidXRpb24gaXMgbGlrZSB0aGlzLCB1bml0IGlzIHNlZ21l bnQgY291bnRzOgogICAgY250X2ZyZWU6IDAgKGZyZWUgYmxvY2tzKQogICAgY250X2Z1bGw6IDI1 MTgyIChzZWdtZW50IHdoaWNoIGhhcyA1MTIgYmxvY2tzKQogICAgY250X292ZXI6IDI1MTkyIChz ZWdtZW50IHdoaWNoIHZhbGlkIGJsb2NrcyBvdmVyIGZnZ2NfdGhyZXNob2xkKQogICAgY250X2Jl bG93OiA4NzAgKHNlZ21lbnQgd2hpY2ggdmFsaWQgYmxvY2tzIGJlbG93IGZnZ2NfdGhyZXNob2xk KQoKVGhlIHRlc3QgaXMgZnJhZ21lbnQgdGVzdCwgYWRkIGFuZCBkZWxldGUgc21hbGwgZmlsZXMg b3ZlciBhbmQgb3Zlci4KCk9uIDIwMTcvNy8xOCAwOjU2LCBKYWVnZXVrIEtpbSB3cm90ZToKPiBP biAwNy8xNiwgc3lsaW51eCB3cm90ZToKPj4gSW4gZmFjdO+8jHRoaXMgaXMgbm90ICJzdXBwb3Nl IiBjYXNlIHlldCwgd2UgaGF2ZSBhbHJlYWR5IG1ldCB0aGlzIHByb2JsZW0gc2V2ZXJhbCB0aW1l cyBpbiBzb21lIHRlc3Qgc3VpdHMgZm9yIGNvcm5lciBjYXNlLCBvciBJIGNhbm5vdCBub3RpY2Ug dGhhdCB0aGlzIGNvdWxkIGhhcHBlbi4KPiBTbywgaGF2ZSB5b3UgdGFrZW4gYSBsb29rIGF0IGRp c3RyaWJ1dGlvbiBvZiB2YWxpZCBibG9ja3MgaW4gdGhhdCBjYXNlPwo+IEknbSB3b25kZXJpbmcg d2hhdCBkaXN0cmlidXRpb24gY2FuIGNhdXNlIHRoaXMuCj4KPiBUaGFua3MsCj4KPj4KPj4KPj4K Pj4g5Y+R6Ieq572R5piT6YKu566x5aSn5biICj4+IE9uIDA3LzE2LzIwMTcgMDk6MDksIEphZWdl dWsgS2ltIHdyb3RlOgo+PiBIaSBZdW5sb25nLAo+Pgo+PiBPbiAwNy8xNCwgWXVubG9uZyBTb25n IHdyb3RlOgo+Pj4gU3VwcG9zZSB0aGF0IHRoZSB2YWxpZCBibG9ja3Mgb2YgZWFjaCBzZWN0aW9u IGFyZSBhbGwgb3ZlciBzYmktPmZnZ2NfdGhyZXNob2xkLAo+PiBIb3cgYWJvdXQgYWRkaW5nIGEg a2VybmVsIG1lc3NhZ2UgZmlyc3QgdG8gZGV0ZWN0IHlvdXIgKnN1cHBvc2VkKiBzY2VhbnJpbz8K Pj4gSWYgdGhhdCBoYXBwZW5zLCBpdCdsbCBiZSBhIHNvcnQgb2YgYnVnIHdoaWNoIHdlIGhhdmVu J3QgYXNzdW1lZC4KPj4KPj4gVGhhbmtzLAo+Pgo+Pj4gYW5kIGV2ZW4gaGFzX25vdF9lbm91Z2hf ZnJlZV9zZWNzIGlzIHRydWUsIGYyZnNfZ2MgY2Fubm90IGRvIGl0cyBqb2Igc2luY2UgdGhlCj4+ PiBub19mZ2djX2NhbmRpZGF0ZSBhbHdheXMgcmV0dXJucyB0cnVlLiBBcyBhIHJlc3VsdCwgdGhl IHJlc2VydmVkIHNlZ21lbnRzIGNhbiBiZQo+Pj4gdXNlZCB1cCwgYW5kIGZpbmFsbHkgdGhlcmUg aXMgbm8gZnJlZSBzZWdtZW50IGF0IGFsbCwgYW5kIGdldF9uZXdfc2VnbWVudCBjYW5ub3QKPj4+ IGdldCBhIGZyZWUgc2VnbWVudCwgZmlsZXN5c3RlbSB3aWxsIHRyYXAgaW50byBhIHdyb25nIHN0 YXR1cy4KPj4+Cj4+PiBUbyBmaXggdGhpcywgd2UgcmVjb3JkIHRoZSBzZWdubyB3aGljaCBoYXMg YSByb3VnaCBtaW5pbXVtIGNvc3QgYW5kIHJldHVybiBpdCB0bwo+Pj4gX19nZXRfdmljdGltIHRv IGNvbnRpbnVlIGYyZnNfZ2MncyBqb2IuCj4+Pgo+Pj4gU2lnbmVkLW9mZi1ieTogWXVubG9uZyBT b25nIDx5dW5sb25nLnNvbmdAaHVhd2VpLmNvbT4KPj4+IC0tLQo+Pj4gIGZzL2YyZnMvZ2MuYyAg ICAgIHwgMTkgKysrKysrKysrKysrKystLS0tLQo+Pj4gIGZzL2YyZnMvc2VnbWVudC5oIHwgMTcg KysrKysrKysrKysrKystLS0KPj4+ICAyIGZpbGVzIGNoYW5nZWQsIDI4IGluc2VydGlvbnMoKyks IDggZGVsZXRpb25zKC0pCj4+Pgo+Pj4gZGlmZiAtLWdpdCBhL2ZzL2YyZnMvZ2MuYyBiL2ZzL2Yy ZnMvZ2MuYwo+Pj4gaW5kZXggZmEzZDJlMi4uOTY1ZTc4MyAxMDA2NDQKPj4+IC0tLSBhL2ZzL2Yy ZnMvZ2MuYwo+Pj4gKysrIGIvZnMvZjJmcy9nYy5jCj4+PiBAQCAtMTc4LDYgKzE3OCw4IEBAIHN0 YXRpYyB2b2lkIHNlbGVjdF9wb2xpY3koc3RydWN0IGYyZnNfc2JfaW5mbyAqc2JpLCBpbnQgZ2Nf dHlwZSwKPj4+ICAgICAgICAgIHAtPm9mZnNldCA9IDA7Cj4+PiAgICAgIGVsc2UKPj4+ICAgICAg ICAgIHAtPm9mZnNldCA9IFNJVF9JKHNiaSktPmxhc3RfdmljdGltW3AtPmdjX21vZGVdOwo+Pj4g Kwo+Pj4gKyAgICBwLT5taW5fY29zdF9yID0gVUlOVF9NQVg7Cj4+PiAgfQo+Pj4gIAo+Pj4gIHN0 YXRpYyB1bnNpZ25lZCBpbnQgZ2V0X21heF9jb3N0KHN0cnVjdCBmMmZzX3NiX2luZm8gKnNiaSwK Pj4+IEBAIC0xOTQsNyArMTk2LDcgQEAgc3RhdGljIHVuc2lnbmVkIGludCBnZXRfbWF4X2Nvc3Qo c3RydWN0IGYyZnNfc2JfaW5mbyAqc2JpLAo+Pj4gICAgICAgICAgcmV0dXJuIDA7Cj4+PiAgfQo+ Pj4gIAo+Pj4gLXN0YXRpYyB1bnNpZ25lZCBpbnQgY2hlY2tfYmdfdmljdGltcyhzdHJ1Y3QgZjJm c19zYl9pbmZvICpzYmkpCj4+PiArc3RhdGljIHVuc2lnbmVkIGludCBjaGVja19iZ192aWN0aW1z KHN0cnVjdCBmMmZzX3NiX2luZm8gKnNiaSwgc3RydWN0IHZpY3RpbV9zZWxfcG9saWN5ICpwKQo+ Pj4gIHsKPj4+ICAgICAgc3RydWN0IGRpcnR5X3NlZ2xpc3RfaW5mbyAqZGlydHlfaSA9IERJUlRZ X0koc2JpKTsKPj4+ICAgICAgdW5zaWduZWQgaW50IHNlY25vOwo+Pj4gQEAgLTIwOCwxMSArMjEw LDEyIEBAIHN0YXRpYyB1bnNpZ25lZCBpbnQgY2hlY2tfYmdfdmljdGltcyhzdHJ1Y3QgZjJmc19z Yl9pbmZvICpzYmkpCj4+PiAgICAgICAgICBpZiAoc2VjX3VzYWdlX2NoZWNrKHNiaSwgc2Vjbm8p KQo+Pj4gICAgICAgICAgICAgIGNvbnRpbnVlOwo+Pj4gIAo+Pj4gLSAgICAgICAgaWYgKG5vX2Zn Z2NfY2FuZGlkYXRlKHNiaSwgc2Vjbm8pKQo+Pj4gKyAgICAgICAgcC0+Y3VyX3NlZ25vX3IgPSBH RVRfU0VHX0ZST01fU0VDKHNiaSwgc2Vjbm8pOwo+Pj4gKyAgICAgICAgaWYgKG5vX2ZnZ2NfY2Fu ZGlkYXRlKHNiaSwgc2Vjbm8sIHApKQo+Pj4gICAgICAgICAgICAgIGNvbnRpbnVlOwo+Pj4gIAo+ Pj4gICAgICAgICAgY2xlYXJfYml0KHNlY25vLCBkaXJ0eV9pLT52aWN0aW1fc2VjbWFwKTsKPj4+ IC0gICAgICAgIHJldHVybiBHRVRfU0VHX0ZST01fU0VDKHNiaSwgc2Vjbm8pOwo+Pj4gKyAgICAg ICAgcmV0dXJuIHAtPmN1cl9zZWdub19yOwo+Pj4gICAgICB9Cj4+PiAgICAgIHJldHVybiBOVUxM X1NFR05POwo+Pj4gIH0KPj4+IEBAIC0zMzIsNyArMzM1LDcgQEAgc3RhdGljIGludCBnZXRfdmlj dGltX2J5X2RlZmF1bHQoc3RydWN0IGYyZnNfc2JfaW5mbyAqc2JpLAo+Pj4gIAo+Pj4gICAgICBs YXN0X3ZpY3RpbSA9IHNtLT5sYXN0X3ZpY3RpbVtwLmdjX21vZGVdOwo+Pj4gICAgICBpZiAocC5h bGxvY19tb2RlID09IExGUyAmJiBnY190eXBlID09IEZHX0dDKSB7Cj4+PiAtICAgICAgICBwLm1p bl9zZWdubyA9IGNoZWNrX2JnX3ZpY3RpbXMoc2JpKTsKPj4+ICsgICAgICAgIHAubWluX3NlZ25v ID0gY2hlY2tfYmdfdmljdGltcyhzYmksICZwKTsKPj4+ICAgICAgICAgIGlmIChwLm1pbl9zZWdu byAhPSBOVUxMX1NFR05PKQo+Pj4gICAgICAgICAgICAgIGdvdG8gZ290X2l0Owo+Pj4gICAgICB9 Cj4+PiBAQCAtMzY5LDggKzM3Miw5IEBAIHN0YXRpYyBpbnQgZ2V0X3ZpY3RpbV9ieV9kZWZhdWx0 KHN0cnVjdCBmMmZzX3NiX2luZm8gKnNiaSwKPj4+ICAgICAgICAgICAgICBnb3RvIG5leHQ7Cj4+ PiAgICAgICAgICBpZiAoZ2NfdHlwZSA9PSBCR19HQyAmJiB0ZXN0X2JpdChzZWNubywgZGlydHlf aS0+dmljdGltX3NlY21hcCkpCj4+PiAgICAgICAgICAgICAgZ290byBuZXh0Owo+Pj4gKyAgICAg ICAgcC5jdXJfc2Vnbm9fciA9IHNlZ25vOwo+Pj4gICAgICAgICAgaWYgKGdjX3R5cGUgPT0gRkdf R0MgJiYgcC5hbGxvY19tb2RlID09IExGUyAmJgo+Pj4gLSAgICAgICAgICAgICAgICAgICAgbm9f ZmdnY19jYW5kaWRhdGUoc2JpLCBzZWNubykpCj4+PiArICAgICAgICAgICAgICAgICAgICBub19m Z2djX2NhbmRpZGF0ZShzYmksIHNlY25vLCAmcCkpCj4+PiAgICAgICAgICAgICAgZ290byBuZXh0 Owo+Pj4gIAo+Pj4gICAgICAgICAgY29zdCA9IGdldF9nY19jb3N0KHNiaSwgc2Vnbm8sICZwKTsK Pj4+IEBAIC00MDMsNiArNDA3LDExIEBAIHN0YXRpYyBpbnQgZ2V0X3ZpY3RpbV9ieV9kZWZhdWx0 KHN0cnVjdCBmMmZzX3NiX2luZm8gKnNiaSwKPj4+ICAgICAgICAgIHRyYWNlX2YyZnNfZ2V0X3Zp Y3RpbShzYmktPnNiLCB0eXBlLCBnY190eXBlLCAmcCwKPj4+ICAgICAgICAgICAgICAgICAgc2Jp LT5jdXJfdmljdGltX3NlYywKPj4+ICAgICAgICAgICAgICAgICAgcHJlZnJlZV9zZWdtZW50cyhz YmkpLCBmcmVlX3NlZ21lbnRzKHNiaSkpOwo+Pj4gKyAgICB9IGVsc2UgaWYgKGhhc19ub3RfZW5v dWdoX2ZyZWVfc2VjcyhzYmksIDAsIDApKSB7Cj4+PiArICAgICAgICBwLm1pbl9zZWdubyA9IHAu bWluX3NlZ25vX3I7Cj4+PiArICAgICAgICBpZiAocC5hbGxvY19tb2RlID09IExGUyAmJiBnY190 eXBlID09IEZHX0dDKQo+Pj4gKyAgICAgICAgICAgIGNsZWFyX2JpdChHRVRfU0VDX0ZST01fU0VH KHNiaSwgcC5taW5fc2Vnbm8pLCBkaXJ0eV9pLT52aWN0aW1fc2VjbWFwKTsKPj4+ICsgICAgICAg IGdvdG8gZ290X2l0Owo+Pj4gICAgICB9Cj4+PiAgb3V0Ogo+Pj4gICAgICBtdXRleF91bmxvY2so JmRpcnR5X2ktPnNlZ2xpc3RfbG9jayk7Cj4+PiBkaWZmIC0tZ2l0IGEvZnMvZjJmcy9zZWdtZW50 LmggYi9mcy9mMmZzL3NlZ21lbnQuaAo+Pj4gaW5kZXggNmI4NzFiNC4uN2QyZDBmMyAxMDA2NDQK Pj4+IC0tLSBhL2ZzL2YyZnMvc2VnbWVudC5oCj4+PiArKysgYi9mcy9mMmZzL3NlZ21lbnQuaAo+ Pj4gQEAgLTE2OSw2ICsxNjksOSBAQCBzdHJ1Y3QgdmljdGltX3NlbF9wb2xpY3kgewo+Pj4gICAg ICB1bnNpZ25lZCBpbnQgb2ZzX3VuaXQ7ICAgICAgICAvKiBiaXRtYXAgc2VhcmNoIHVuaXQgKi8K Pj4+ICAgICAgdW5zaWduZWQgaW50IG1pbl9jb3N0OyAgICAgICAgLyogbWluaW11bSBjb3N0ICov Cj4+PiAgICAgIHVuc2lnbmVkIGludCBtaW5fc2Vnbm87ICAgICAgICAvKiBzZWdtZW50ICMgaGF2 aW5nIG1pbi4gY29zdCAqLwo+Pj4gKyAgICB1bnNpZ25lZCBpbnQgbWluX2Nvc3RfcjsgICAgICAg IC8qIHJvdWdoIG1pbmltdW0gY29zdCAqLwo+Pj4gKyAgICB1bnNpZ25lZCBpbnQgbWluX3NlZ25v X3I7ICAgICAgICAvKiBzZWdtZW50ICMgaGF2aW5nIHJvdWdoIG1pbi4gY29zdCAqLwo+Pj4gKyAg ICB1bnNpZ25lZCBpbnQgY3VyX3NlZ25vX3I7ICAgICAgICAvKiBzZWdtZW50ICMgcm91Z2ggcHJv Y2VzcyBpcyBoYW5kbGluZyAqLwo+Pj4gIH07Cj4+PiAgCj4+PiAgc3RydWN0IHNlZ19lbnRyeSB7 Cj4+PiBAQCAtNzQzLDExICs3NDYsMTkgQEAgc3RhdGljIGlubGluZSBibG9ja190IHN1bV9ibGtf YWRkcihzdHJ1Y3QgZjJmc19zYl9pbmZvICpzYmksIGludCBiYXNlLCBpbnQgdHlwZSkKPj4+ICB9 Cj4+PiAgCj4+PiAgc3RhdGljIGlubGluZSBib29sIG5vX2ZnZ2NfY2FuZGlkYXRlKHN0cnVjdCBm MmZzX3NiX2luZm8gKnNiaSwKPj4+IC0gICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBp bnQgc2Vjbm8pCj4+PiArICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IHNlY25v LCBzdHJ1Y3QgdmljdGltX3NlbF9wb2xpY3kgKnApCj4+PiAgewo+Pj4gLSAgICBpZiAoZ2V0X3Zh bGlkX2Jsb2NrcyhzYmksIEdFVF9TRUdfRlJPTV9TRUMoc2JpLCBzZWNubyksIHRydWUpID49Cj4+ PiAtICAgICAgICAgICAgICAgICAgICAgICAgc2JpLT5mZ2djX3RocmVzaG9sZCkKPj4+ICsgICAg dW5zaWduZWQgaW50IGN1cl9jb3N0Owo+Pj4gKwo+Pj4gKyAgICBjdXJfY29zdCA9IGdldF92YWxp ZF9ibG9ja3Moc2JpLCBHRVRfU0VHX0ZST01fU0VDKHNiaSwgc2Vjbm8pLCB0cnVlKTsKPj4+ICsg ICAgaWYgKGN1cl9jb3N0ID49IHNiaS0+ZmdnY190aHJlc2hvbGQpIHsKPj4+ICsgICAgICAgIGlm IChwLT5taW5fY29zdF9yID4gY3VyX2Nvc3QpIHsKPj4+ICsgICAgICAgICAgICBwLT5taW5fY29z dF9yID0gY3VyX2Nvc3Q7Cj4+PiArICAgICAgICAgICAgcC0+bWluX3NlZ25vX3IgPSBwLT5jdXJf c2Vnbm9fcjsKPj4+ICsgICAgICAgIH0KPj4+ICAgICAgICAgIHJldHVybiB0cnVlOwo+Pj4gKyAg ICB9Cj4+PiArCj4+PiAgICAgIHJldHVybiBmYWxzZTsKPj4+ICB9Cj4+PiAgCj4+PiAtLQo+Pj4g MS44LjUuMgo+IC4KPgoKCi0tIApUaGFua3MsCll1bmxvbmcgU29uZwoKCgotLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0KQ2hlY2sgb3V0IHRoZSB2aWJyYW50IHRlY2ggY29tbXVuaXR5IG9uIG9uZSBvZiB0 aGUgd29ybGQncyBtb3N0CmVuZ2FnaW5nIHRlY2ggc2l0ZXMsIFNsYXNoZG90Lm9yZyEgaHR0cDov L3NkbS5saW5rL3NsYXNoZG90Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCkxpbnV4LWYyZnMtZGV2ZWwgbWFpbGluZyBsaXN0CkxpbnV4LWYyZnMtZGV2ZWxA bGlzdHMuc291cmNlZm9yZ2UubmV0Cmh0dHBzOi8vbGlzdHMuc291cmNlZm9yZ2UubmV0L2xpc3Rz L2xpc3RpbmZvL2xpbnV4LWYyZnMtZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH] f2fs: let __get_victim successfully get a segno in corner case To: Jaegeuk Kim , sylinux References: <1500033432-57620-1-git-send-email-yunlong.song@huawei.com> <20170716010934.GC51202@jaegeuk-macbookpro.roam.corp.google.com> <3b3c1eba.b25.15d495786fe.Coremail.sylinux@163.com> <20170717165636.GB81128@jaegeuk-macbookpro.roam.corp.google.com> CC: chao , yuchao0 , miaoxie , "bintian.wang" , linux-fsdevel , linux-f2fs-devel , linux-kernel From: Yunlong Song Message-ID: <5970A19F.4030000@huawei.com> Date: Thu, 20 Jul 2017 20:27:11 +0800 MIME-Version: 1.0 In-Reply-To: <20170717165636.GB81128@jaegeuk-macbookpro.roam.corp.google.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: Hi, Jay, The distribution is like this, unit is segment counts: cnt_free: 0 (free blocks) cnt_full: 25182 (segment which has 512 blocks) cnt_over: 25192 (segment which valid blocks over fggc_threshold) cnt_below: 870 (segment which valid blocks below fggc_threshold) The test is fragment test, add and delete small files over and over. On 2017/7/18 0:56, Jaegeuk Kim wrote: > On 07/16, sylinux wrote: >> In fact，this is not "suppose" case yet, we have already met this problem several times in some test suits for corner case, or I cannot notice that this could happen. > So, have you taken a look at distribution of valid blocks in that case? > I'm wondering what distribution can cause this. > > Thanks, > >> >> >> >> 发自网易邮箱大师 >> On 07/16/2017 09:09, Jaegeuk Kim wrote: >> Hi Yunlong, >> >> On 07/14, Yunlong Song wrote: >>> Suppose that the valid blocks of each section are all over sbi->fggc_threshold, >> How about adding a kernel message first to detect your *supposed* sceanrio? >> If that happens, it'll be a sort of bug which we haven't assumed. >> >> Thanks, >> >>> and even has_not_enough_free_secs is true, f2fs_gc cannot do its job since the >>> no_fggc_candidate always returns true. As a result, the reserved segments can be >>> used up, and finally there is no free segment at all, and get_new_segment cannot >>> get a free segment, filesystem will trap into a wrong status. >>> >>> To fix this, we record the segno which has a rough minimum cost and return it to >>> __get_victim to continue f2fs_gc's job. >>> >>> Signed-off-by: Yunlong Song >>> --- >>> fs/f2fs/gc.c | 19 ++++++++++++++----- >>> fs/f2fs/segment.h | 17 ++++++++++++++--- >>> 2 files changed, 28 insertions(+), 8 deletions(-) >>> >>> diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c >>> index fa3d2e2..965e783 100644 >>> --- a/fs/f2fs/gc.c >>> +++ b/fs/f2fs/gc.c >>> @@ -178,6 +178,8 @@ static void select_policy(struct f2fs_sb_info *sbi, int gc_type, >>> p->offset = 0; >>> else >>> p->offset = SIT_I(sbi)->last_victim[p->gc_mode]; >>> + >>> + p->min_cost_r = UINT_MAX; >>> } >>> >>> static unsigned int get_max_cost(struct f2fs_sb_info *sbi, >>> @@ -194,7 +196,7 @@ static unsigned int get_max_cost(struct f2fs_sb_info *sbi, >>> return 0; >>> } >>> >>> -static unsigned int check_bg_victims(struct f2fs_sb_info *sbi) >>> +static unsigned int check_bg_victims(struct f2fs_sb_info *sbi, struct victim_sel_policy *p) >>> { >>> struct dirty_seglist_info *dirty_i = DIRTY_I(sbi); >>> unsigned int secno; >>> @@ -208,11 +210,12 @@ static unsigned int check_bg_victims(struct f2fs_sb_info *sbi) >>> if (sec_usage_check(sbi, secno)) >>> continue; >>> >>> - if (no_fggc_candidate(sbi, secno)) >>> + p->cur_segno_r = GET_SEG_FROM_SEC(sbi, secno); >>> + if (no_fggc_candidate(sbi, secno, p)) >>> continue; >>> >>> clear_bit(secno, dirty_i->victim_secmap); >>> - return GET_SEG_FROM_SEC(sbi, secno); >>> + return p->cur_segno_r; >>> } >>> return NULL_SEGNO; >>> } >>> @@ -332,7 +335,7 @@ static int get_victim_by_default(struct f2fs_sb_info *sbi, >>> >>> last_victim = sm->last_victim[p.gc_mode]; >>> if (p.alloc_mode == LFS && gc_type == FG_GC) { >>> - p.min_segno = check_bg_victims(sbi); >>> + p.min_segno = check_bg_victims(sbi, &p); >>> if (p.min_segno != NULL_SEGNO) >>> goto got_it; >>> } >>> @@ -369,8 +372,9 @@ static int get_victim_by_default(struct f2fs_sb_info *sbi, >>> goto next; >>> if (gc_type == BG_GC && test_bit(secno, dirty_i->victim_secmap)) >>> goto next; >>> + p.cur_segno_r = segno; >>> if (gc_type == FG_GC && p.alloc_mode == LFS && >>> - no_fggc_candidate(sbi, secno)) >>> + no_fggc_candidate(sbi, secno, &p)) >>> goto next; >>> >>> cost = get_gc_cost(sbi, segno, &p); >>> @@ -403,6 +407,11 @@ static int get_victim_by_default(struct f2fs_sb_info *sbi, >>> trace_f2fs_get_victim(sbi->sb, type, gc_type, &p, >>> sbi->cur_victim_sec, >>> prefree_segments(sbi), free_segments(sbi)); >>> + } else if (has_not_enough_free_secs(sbi, 0, 0)) { >>> + p.min_segno = p.min_segno_r; >>> + if (p.alloc_mode == LFS && gc_type == FG_GC) >>> + clear_bit(GET_SEC_FROM_SEG(sbi, p.min_segno), dirty_i->victim_secmap); >>> + goto got_it; >>> } >>> out: >>> mutex_unlock(&dirty_i->seglist_lock); >>> diff --git a/fs/f2fs/segment.h b/fs/f2fs/segment.h >>> index 6b871b4..7d2d0f3 100644 >>> --- a/fs/f2fs/segment.h >>> +++ b/fs/f2fs/segment.h >>> @@ -169,6 +169,9 @@ struct victim_sel_policy { >>> unsigned int ofs_unit; /* bitmap search unit */ >>> unsigned int min_cost; /* minimum cost */ >>> unsigned int min_segno; /* segment # having min. cost */ >>> + unsigned int min_cost_r; /* rough minimum cost */ >>> + unsigned int min_segno_r; /* segment # having rough min. cost */ >>> + unsigned int cur_segno_r; /* segment # rough process is handling */ >>> }; >>> >>> struct seg_entry { >>> @@ -743,11 +746,19 @@ static inline block_t sum_blk_addr(struct f2fs_sb_info *sbi, int base, int type) >>> } >>> >>> static inline bool no_fggc_candidate(struct f2fs_sb_info *sbi, >>> - unsigned int secno) >>> + unsigned int secno, struct victim_sel_policy *p) >>> { >>> - if (get_valid_blocks(sbi, GET_SEG_FROM_SEC(sbi, secno), true) >= >>> - sbi->fggc_threshold) >>> + unsigned int cur_cost; >>> + >>> + cur_cost = get_valid_blocks(sbi, GET_SEG_FROM_SEC(sbi, secno), true); >>> + if (cur_cost >= sbi->fggc_threshold) { >>> + if (p->min_cost_r > cur_cost) { >>> + p->min_cost_r = cur_cost; >>> + p->min_segno_r = p->cur_segno_r; >>> + } >>> return true; >>> + } >>> + >>> return false; >>> } >>> >>> -- >>> 1.8.5.2 > . > -- Thanks, Yunlong Song