From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark yao Subject: Re: [PATCH] [RESEND] drm/rockchip: fix Kconfig dependencies Date: Mon, 24 Jul 2017 09:58:18 +0800 Message-ID: <5975543A.80407@rock-chips.com> References: <20170721211214.3386387-1-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170721211214.3386387-1-arnd@arndb.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Arnd Bergmann , David Airlie , Heiko Stuebner Cc: Jeffy Chen , linux-rockchip@lists.infradead.org, Stephen Boyd , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Chris Zhong , Guenter Roeck , linux-arm-kernel@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org T24gMjAxN+W5tDA35pyIMjLml6UgMDU6MTIsIEFybmQgQmVyZ21hbm4gd3JvdGU6Cj4gQSBidWcg dGhhdCBJIGhhZCBmaXhlZCBlYXJsaWVyIGp1c3QgY2FtZSBiYWNrLCB3aXRoIENPTkZJR19FWFRD T049bSwKPiB0aGUgcm9ja2NoaXAgZHJtIGRyaXZlciB3aWxsIGZhaWwgdG8gbGluazoKPgo+IGRy aXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9jZG4tZHAtY29yZS5vOiBJbiBmdW5jdGlvbiBgY2RuX2Rw X2dldF9wb3J0X2xhbmVzJzoKPiBjZG4tZHAtY29yZS5jOigudGV4dC5jZG5fZHBfZ2V0X3BvcnRf bGFuZXMrMHgzMCk6IHVuZGVmaW5lZCByZWZlcmVuY2UgdG8gYGV4dGNvbl9nZXRfc3RhdGUnCj4g Y2RuLWRwLWNvcmUuYzooLnRleHQuY2RuX2RwX2dldF9wb3J0X2xhbmVzKzB4NmMpOiB1bmRlZmlu ZWQgcmVmZXJlbmNlIHRvIGBleHRjb25fZ2V0X3Byb3BlcnR5Jwo+IGRyaXZlcnMvZ3B1L2RybS9y b2NrY2hpcC9jZG4tZHAtY29yZS5vOiBJbiBmdW5jdGlvbiBgY2RuX2RwX2NoZWNrX3NpbmtfY29u bmVjdGlvbic6Cj4gY2RuLWRwLWNvcmUuYzooLnRleHQuY2RuX2RwX2NoZWNrX3NpbmtfY29ubmVj dGlvbisweDgwKTogdW5kZWZpbmVkIHJlZmVyZW5jZSB0byBgZXh0Y29uX2dldF9zdGF0ZScKPiBk cml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvY2RuLWRwLWNvcmUubzogSW4gZnVuY3Rpb24gYGNkbl9k cF9lbmFibGUnOgo+IGNkbi1kcC1jb3JlLmM6KC50ZXh0LmNkbl9kcF9lbmFibGUrMHg3NDgpOiB1 bmRlZmluZWQgcmVmZXJlbmNlIHRvIGBleHRjb25fZ2V0X3Byb3BlcnR5Jwo+Cj4gVGhlIHByb2Js ZW0gaXMgdGhhdCB0aGF0IHRoZSBzdWItZHJpdmVycyBhcmUgbm93IGFsbCBsaW5rZWQgaW50byB0 aGUKPiBtYWluIHJvY2tjaGlwIGRybSBtb2R1bGUsIHdoaWNoIGJyZWFrcyBhbGwgdGhlIEtjb25m aWcgZGVwZW5kZW5jaWVzCj4gdGhhdCBhcmUgc3BlY2lmaWVkIGluIHRoZSBvcHRpb25zIGZvciB0 aG9zZSBzdWItZHJpdmVycy4KPgo+IFRoaXMgY2xhcmlmaWVzIHRoZSBkZXBlbmRlbmN5IHRvIGVu c3VyZSB0aGF0IHdlIGNhbiBvbmx5IHR1cm4gb24gdGhlIERQCj4gZHJpdmVyIHdoZW4gRVhUQ09O IGlzIHJlYWNoYWJsZS4gQXMgdGhlICdzZWxlY3QnIHN0YXRlbWVudHMgY2FuIG5vdwo+IGNhdXNl IGFkZGl0aW9uYWwgb3B0aW9ucyB0byBiZWNvbWUgYnVpbHQtaW4gd2hlbiB0aGV5IHNob3VsZCBi ZQo+IGxvYWRhYmxlIG1vZHVsZXMsIEknbSBtb3ZpbmcgdGhvc2UgaW50byB0aGUgbWFpbiBkcml2 ZXIgY29uZmlnIG9wdGlvbi4KPiBUaGUgZGVwZW5kZW5jeSBvbiBEUk1fUk9DS0NISVAgY2FuIGJl IHJlZHVjZWQgaW50byBhIHNpbmdsZSAnaWYnCj4gc3RhdGVtZW50IGhlcmUgZm9yIGJyZXZpdHks IGJ1dCB0aGlzIGhhcyBubyBmdW5jdGlvbmFsIGVmZmVjdC4KPgo+IEZpeGVzOiBiNjcwNTE1N2Iy ZGIgKCJkcm0vcm9ja2NoaXA6IGFkZCBleHRjb24gZGVwZW5kZW5jeSBmb3IgRFAiKQo+IEZpeGVz OiA4ODIwYjY4YmQzNzggKCJkcm0vcm9ja2NoaXA6IFJlZmFjdG9yIHRoZSBjb21wb25lbnQgbWF0 Y2ggbG9naWMuIikKPiBMaW5rOmh0dHBzOi8vcGF0Y2h3b3JrLmtlcm5lbC5vcmcvcGF0Y2gvOTY0 ODc2MS8KPiBBY2tlZC1ieTogR3VlbnRlciBSb2Vjazxncm9lY2tAY2hyb21pdW0ub3JnPgo+IFRl c3RlZC1ieTogSmVmZnkgQ2hlbjxqZWZmeS5jaGVuQHJvY2stY2hpcHMuY29tPgo+IFNpZ25lZC1v ZmYtYnk6IEFybmQgQmVyZ21hbm48YXJuZEBhcm5kYi5kZT4KClB1c2hlZCB0byBkcm0tbWlzYy1m aXhlcy4KClRoYW5rcy4KCi0tIArvvK1hcmsgWWFvCgoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: mark.yao@rock-chips.com (Mark yao) Date: Mon, 24 Jul 2017 09:58:18 +0800 Subject: [PATCH] [RESEND] drm/rockchip: fix Kconfig dependencies In-Reply-To: <20170721211214.3386387-1-arnd@arndb.de> References: <20170721211214.3386387-1-arnd@arndb.de> Message-ID: <5975543A.80407@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2017?07?22? 05:12, Arnd Bergmann wrote: > A bug that I had fixed earlier just came back, with CONFIG_EXTCON=m, > the rockchip drm driver will fail to link: > > drivers/gpu/drm/rockchip/cdn-dp-core.o: In function `cdn_dp_get_port_lanes': > cdn-dp-core.c:(.text.cdn_dp_get_port_lanes+0x30): undefined reference to `extcon_get_state' > cdn-dp-core.c:(.text.cdn_dp_get_port_lanes+0x6c): undefined reference to `extcon_get_property' > drivers/gpu/drm/rockchip/cdn-dp-core.o: In function `cdn_dp_check_sink_connection': > cdn-dp-core.c:(.text.cdn_dp_check_sink_connection+0x80): undefined reference to `extcon_get_state' > drivers/gpu/drm/rockchip/cdn-dp-core.o: In function `cdn_dp_enable': > cdn-dp-core.c:(.text.cdn_dp_enable+0x748): undefined reference to `extcon_get_property' > > The problem is that that the sub-drivers are now all linked into the > main rockchip drm module, which breaks all the Kconfig dependencies > that are specified in the options for those sub-drivers. > > This clarifies the dependency to ensure that we can only turn on the DP > driver when EXTCON is reachable. As the 'select' statements can now > cause additional options to become built-in when they should be > loadable modules, I'm moving those into the main driver config option. > The dependency on DRM_ROCKCHIP can be reduced into a single 'if' > statement here for brevity, but this has no functional effect. > > Fixes: b6705157b2db ("drm/rockchip: add extcon dependency for DP") > Fixes: 8820b68bd378 ("drm/rockchip: Refactor the component match logic.") > Link:https://patchwork.kernel.org/patch/9648761/ > Acked-by: Guenter Roeck > Tested-by: Jeffy Chen > Signed-off-by: Arnd Bergmann Pushed to drm-misc-fixes. Thanks. -- ?ark Yao From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752106AbdGXB67 (ORCPT ); Sun, 23 Jul 2017 21:58:59 -0400 Received: from regular1.263xmail.com ([211.150.99.140]:56247 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751782AbdGXB6v (ORCPT ); Sun, 23 Jul 2017 21:58:51 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: linux-kernel@vger.kernel.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH] [RESEND] drm/rockchip: fix Kconfig dependencies To: Arnd Bergmann , David Airlie , Heiko Stuebner References: <20170721211214.3386387-1-arnd@arndb.de> Cc: Guenter Roeck , Sean Paul , robdclark@gmail.com, Jeffy Chen , Stephen Boyd , Chris Zhong , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org From: Mark yao Message-ID: <5975543A.80407@rock-chips.com> Date: Mon, 24 Jul 2017 09:58:18 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20170721211214.3386387-1-arnd@arndb.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017年07月22日 05:12, Arnd Bergmann wrote: > A bug that I had fixed earlier just came back, with CONFIG_EXTCON=m, > the rockchip drm driver will fail to link: > > drivers/gpu/drm/rockchip/cdn-dp-core.o: In function `cdn_dp_get_port_lanes': > cdn-dp-core.c:(.text.cdn_dp_get_port_lanes+0x30): undefined reference to `extcon_get_state' > cdn-dp-core.c:(.text.cdn_dp_get_port_lanes+0x6c): undefined reference to `extcon_get_property' > drivers/gpu/drm/rockchip/cdn-dp-core.o: In function `cdn_dp_check_sink_connection': > cdn-dp-core.c:(.text.cdn_dp_check_sink_connection+0x80): undefined reference to `extcon_get_state' > drivers/gpu/drm/rockchip/cdn-dp-core.o: In function `cdn_dp_enable': > cdn-dp-core.c:(.text.cdn_dp_enable+0x748): undefined reference to `extcon_get_property' > > The problem is that that the sub-drivers are now all linked into the > main rockchip drm module, which breaks all the Kconfig dependencies > that are specified in the options for those sub-drivers. > > This clarifies the dependency to ensure that we can only turn on the DP > driver when EXTCON is reachable. As the 'select' statements can now > cause additional options to become built-in when they should be > loadable modules, I'm moving those into the main driver config option. > The dependency on DRM_ROCKCHIP can be reduced into a single 'if' > statement here for brevity, but this has no functional effect. > > Fixes: b6705157b2db ("drm/rockchip: add extcon dependency for DP") > Fixes: 8820b68bd378 ("drm/rockchip: Refactor the component match logic.") > Link:https://patchwork.kernel.org/patch/9648761/ > Acked-by: Guenter Roeck > Tested-by: Jeffy Chen > Signed-off-by: Arnd Bergmann Pushed to drm-misc-fixes. Thanks. -- Ｍark Yao