From: Bhushan Shah <bhushan.shah@machinesoul.in>
To: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
cros-qcom-dts-watchers@chromium.org,
Bharadwaj Raju <bharadwaj.raju@machinesoul.in>,
Alexandre Ferrieux <alexandre.ferrieux@orange.com>,
Luca Weiss <luca.weiss@fairphone.com>
Cc: ~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: kodiak: Add missing clock votes for lpass_tlmm
Date: Tue, 20 Jan 2026 16:23:09 +0530 [thread overview]
Message-ID: <5976946.DvuYhMxLoT@antlia> (raw)
In-Reply-To: <6749502.DvuYhMxLoT@antlia>
On Friday, 9 January 2026 21:08:32 IST Bhushan Shah wrote:
> On Friday, 9 January 2026 20:44:34 IST Luca Weiss wrote:
> > Without the correct clock votes set, we may be hitting a synchronous
> > external abort error when touching the lpi registers.
> >
> > Internal error: synchronous external abort: 0000000096000010 [#1] SMP
> > <...>
> >
> > Call trace:
> > lpi_gpio_read.isra.0+0x2c/0x58 (P)
> > pinmux_enable_setting+0x218/0x300
> > pinctrl_commit_state+0xb0/0x280
> > pinctrl_select_state+0x28/0x48
> > pinctrl_bind_pins+0x1f4/0x2a0
> > really_probe+0x64/0x3a8
> >
> > Add the clocks to fix that.
> >
> > Platforms with this SoC using AudioReach won't be impacted due to
> > qcs6490-audioreach.dtsi already setting clocks & clock-names for
> > q6prmcc. The sc7280-chrome-common.dtsi has also been adjusted to keep
> > the behavior the same as they also do not use Elite with q6afecc.
> >
> > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
>
> Tested-by: Bhushan Shah <bhushan.shah@machinesoul.in> # On fairphone-fp5
As a follow-up;
While this fixes original abort, it seems on some coldboots or as such(?); it fails
to vote the clocks and then eventually soundcard fails to probe, so there is still
some issue that needs to be solved.
[ 17.944296] Bluetooth: hci0: Frame reassembly failed (-84)
[ 20.961100] qcom-q6afe aprsvc:service:4:4: AFE failed to vote (3)
[ 20.961131] Failed to prepare clk 'core': -110
[ 20.961137] qcom-sc7280-lpass-lpi-pinctrl 33c0000.pinctrl: error -ETIMEDOUT: Can't enable clocks
[ 20.961144] qcom-sc7280-lpass-lpi-pinctrl 33c0000.pinctrl: probe with driver qcom-sc7280-lpass-lpi-pinctrl failed with error -110
So far I was not able to find a precise pattern to this, but doing bunch of coldboots
is most easiest way to reproduce I have found.
If anyone has any inputs on this, I would love to hear.
Best Regards,
Bhushan
next prev parent reply other threads:[~2026-01-20 10:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-09 15:14 [PATCH] arm64: dts: qcom: kodiak: Add missing clock votes for lpass_tlmm Luca Weiss
2026-01-09 15:38 ` Bhushan Shah
2026-01-20 10:53 ` Bhushan Shah [this message]
2026-04-21 15:52 ` Val Packett
2026-01-09 16:10 ` Dmitry Baryshkov
2026-01-10 19:11 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5976946.DvuYhMxLoT@antlia \
--to=bhushan.shah@machinesoul.in \
--cc=alexandre.ferrieux@orange.com \
--cc=andersson@kernel.org \
--cc=bharadwaj.raju@machinesoul.in \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.