From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: virtio-dev-return-2414-cohuck=redhat.com@lists.oasis-open.org Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [66.179.20.138]) by lists.oasis-open.org (Postfix) with ESMTP id 307E55818095 for ; Tue, 25 Jul 2017 02:29:24 -0700 (PDT) Message-ID: <59771010.6080108@intel.com> Date: Tue, 25 Jul 2017 17:32:00 +0800 From: Wei Wang MIME-Version: 1.0 References: <1499863221-16206-1-git-send-email-wei.w.wang@intel.com> <1499863221-16206-7-git-send-email-wei.w.wang@intel.com> <20170714123023.GA2624@dhcp22.suse.cz> <20170714181523-mutt-send-email-mst@kernel.org> <20170717152448.GN12888@dhcp22.suse.cz> <596D6E7E.4070700@intel.com> <20170719081311.GC26779@dhcp22.suse.cz> <596F4A0E.4010507@intel.com> <20170724090042.GF25221@dhcp22.suse.cz> In-Reply-To: <20170724090042.GF25221@dhcp22.suse.cz> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: [virtio-dev] Re: [PATCH v12 6/8] mm: support reporting free page blocks To: Michal Hocko Cc: "Michael S. Tsirkin" , linux-kernel@vger.kernel.org, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, linux-mm@kvack.org, david@redhat.com, cornelia.huck@de.ibm.com, akpm@linux-foundation.org, mgorman@techsingularity.net, aarcange@redhat.com, amit.shah@redhat.com, pbonzini@redhat.com, liliang.opensource@gmail.com, virtio-dev@lists.oasis-open.org, yang.zhang.wz@gmail.com, quan.xu@aliyun.com List-ID: On 07/24/2017 05:00 PM, Michal Hocko wrote: > On Wed 19-07-17 20:01:18, Wei Wang wrote: >> On 07/19/2017 04:13 PM, Michal Hocko wrote: > [... >>> All you should need is the check for the page reference count, no? I >>> assume you do some sort of pfn walk and so you should be able to get an >>> access to the struct page. >> Not necessarily - the guest struct page is not seen by the hypervisor. The >> hypervisor only gets those guest pfns which are hinted as unused. From the >> hypervisor (host) point of view, a guest physical address corresponds to a >> virtual address of a host process. So, once the hypervisor knows a guest >> physical page is unsued, it knows that the corresponding virtual memory of >> the process doesn't need to be transferred in the 1st round. > I am sorry, but I do not understand. Why cannot _guest_ simply check the > struct page ref count and send them to the hypervisor? Were you suggesting the following? 1) get a free page block from the page list using the API; 2) if page->ref_count == 0, send it to the hypervisor Btw, ref_count may also change at any time. > Is there any > documentation which describes the workflow or code which would use your > new API? > It's used in the balloon driver (patch 8). We don't have any docs yet, but I think the high level workflow is the two steps above. Best, Wei --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Wang Subject: Re: [PATCH v12 6/8] mm: support reporting free page blocks Date: Tue, 25 Jul 2017 17:32:00 +0800 Message-ID: <59771010.6080108@intel.com> References: <1499863221-16206-1-git-send-email-wei.w.wang@intel.com> <1499863221-16206-7-git-send-email-wei.w.wang@intel.com> <20170714123023.GA2624@dhcp22.suse.cz> <20170714181523-mutt-send-email-mst@kernel.org> <20170717152448.GN12888@dhcp22.suse.cz> <596D6E7E.4070700@intel.com> <20170719081311.GC26779@dhcp22.suse.cz> <596F4A0E.4010507@intel.com> <20170724090042.GF25221@dhcp22.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: "Michael S. Tsirkin" , linux-kernel@vger.kernel.org, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, linux-mm@kvack.org, david@redhat.com, cornelia.huck@de.ibm.com, akpm@linux-foundation.org, mgorman@techsingularity.net, aarcange@redhat.com, amit.shah@redhat.com, pbonzini@redhat.com, liliang.opensource@gmail.com, virtio-dev@lists.oasis-open.org, yang.zhang.wz@gmail.com, quan.xu@aliyun.com To: Michal Hocko Return-path: In-Reply-To: <20170724090042.GF25221@dhcp22.suse.cz> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 07/24/2017 05:00 PM, Michal Hocko wrote: > On Wed 19-07-17 20:01:18, Wei Wang wrote: >> On 07/19/2017 04:13 PM, Michal Hocko wrote: > [... >>> All you should need is the check for the page reference count, no? I >>> assume you do some sort of pfn walk and so you should be able to get an >>> access to the struct page. >> Not necessarily - the guest struct page is not seen by the hypervisor. The >> hypervisor only gets those guest pfns which are hinted as unused. From the >> hypervisor (host) point of view, a guest physical address corresponds to a >> virtual address of a host process. So, once the hypervisor knows a guest >> physical page is unsued, it knows that the corresponding virtual memory of >> the process doesn't need to be transferred in the 1st round. > I am sorry, but I do not understand. Why cannot _guest_ simply check the > struct page ref count and send them to the hypervisor? Were you suggesting the following? 1) get a free page block from the page list using the API; 2) if page->ref_count == 0, send it to the hypervisor Btw, ref_count may also change at any time. > Is there any > documentation which describes the workflow or code which would use your > new API? > It's used in the balloon driver (patch 8). We don't have any docs yet, but I think the high level workflow is the two steps above. Best, Wei From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f71.google.com (mail-pg0-f71.google.com [74.125.83.71]) by kanga.kvack.org (Postfix) with ESMTP id E86896B0292 for ; Tue, 25 Jul 2017 05:29:24 -0400 (EDT) Received: by mail-pg0-f71.google.com with SMTP id u199so80635710pgb.13 for ; Tue, 25 Jul 2017 02:29:24 -0700 (PDT) Received: from mga09.intel.com (mga09.intel.com. [134.134.136.24]) by mx.google.com with ESMTPS id f3si8275767plb.337.2017.07.25.02.29.23 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 25 Jul 2017 02:29:23 -0700 (PDT) Message-ID: <59771010.6080108@intel.com> Date: Tue, 25 Jul 2017 17:32:00 +0800 From: Wei Wang MIME-Version: 1.0 Subject: Re: [PATCH v12 6/8] mm: support reporting free page blocks References: <1499863221-16206-1-git-send-email-wei.w.wang@intel.com> <1499863221-16206-7-git-send-email-wei.w.wang@intel.com> <20170714123023.GA2624@dhcp22.suse.cz> <20170714181523-mutt-send-email-mst@kernel.org> <20170717152448.GN12888@dhcp22.suse.cz> <596D6E7E.4070700@intel.com> <20170719081311.GC26779@dhcp22.suse.cz> <596F4A0E.4010507@intel.com> <20170724090042.GF25221@dhcp22.suse.cz> In-Reply-To: <20170724090042.GF25221@dhcp22.suse.cz> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: "Michael S. Tsirkin" , linux-kernel@vger.kernel.org, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, linux-mm@kvack.org, david@redhat.com, cornelia.huck@de.ibm.com, akpm@linux-foundation.org, mgorman@techsingularity.net, aarcange@redhat.com, amit.shah@redhat.com, pbonzini@redhat.com, liliang.opensource@gmail.com, virtio-dev@lists.oasis-open.org, yang.zhang.wz@gmail.com, quan.xu@aliyun.com On 07/24/2017 05:00 PM, Michal Hocko wrote: > On Wed 19-07-17 20:01:18, Wei Wang wrote: >> On 07/19/2017 04:13 PM, Michal Hocko wrote: > [... >>> All you should need is the check for the page reference count, no? I >>> assume you do some sort of pfn walk and so you should be able to get an >>> access to the struct page. >> Not necessarily - the guest struct page is not seen by the hypervisor. The >> hypervisor only gets those guest pfns which are hinted as unused. From the >> hypervisor (host) point of view, a guest physical address corresponds to a >> virtual address of a host process. So, once the hypervisor knows a guest >> physical page is unsued, it knows that the corresponding virtual memory of >> the process doesn't need to be transferred in the 1st round. > I am sorry, but I do not understand. Why cannot _guest_ simply check the > struct page ref count and send them to the hypervisor? Were you suggesting the following? 1) get a free page block from the page list using the API; 2) if page->ref_count == 0, send it to the hypervisor Btw, ref_count may also change at any time. > Is there any > documentation which describes the workflow or code which would use your > new API? > It's used in the balloon driver (patch 8). We don't have any docs yet, but I think the high level workflow is the two steps above. Best, Wei -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41074) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZw9h-0005yH-VF for qemu-devel@nongnu.org; Tue, 25 Jul 2017 05:29:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dZw9c-0005kk-Uo for qemu-devel@nongnu.org; Tue, 25 Jul 2017 05:29:29 -0400 Received: from mga14.intel.com ([192.55.52.115]:60008) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dZw9c-0005k6-L6 for qemu-devel@nongnu.org; Tue, 25 Jul 2017 05:29:24 -0400 Message-ID: <59771010.6080108@intel.com> Date: Tue, 25 Jul 2017 17:32:00 +0800 From: Wei Wang MIME-Version: 1.0 References: <1499863221-16206-1-git-send-email-wei.w.wang@intel.com> <1499863221-16206-7-git-send-email-wei.w.wang@intel.com> <20170714123023.GA2624@dhcp22.suse.cz> <20170714181523-mutt-send-email-mst@kernel.org> <20170717152448.GN12888@dhcp22.suse.cz> <596D6E7E.4070700@intel.com> <20170719081311.GC26779@dhcp22.suse.cz> <596F4A0E.4010507@intel.com> <20170724090042.GF25221@dhcp22.suse.cz> In-Reply-To: <20170724090042.GF25221@dhcp22.suse.cz> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v12 6/8] mm: support reporting free page blocks List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michal Hocko Cc: "Michael S. Tsirkin" , linux-kernel@vger.kernel.org, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, linux-mm@kvack.org, david@redhat.com, cornelia.huck@de.ibm.com, akpm@linux-foundation.org, mgorman@techsingularity.net, aarcange@redhat.com, amit.shah@redhat.com, pbonzini@redhat.com, liliang.opensource@gmail.com, virtio-dev@lists.oasis-open.org, yang.zhang.wz@gmail.com, quan.xu@aliyun.com On 07/24/2017 05:00 PM, Michal Hocko wrote: > On Wed 19-07-17 20:01:18, Wei Wang wrote: >> On 07/19/2017 04:13 PM, Michal Hocko wrote: > [... >>> All you should need is the check for the page reference count, no? I >>> assume you do some sort of pfn walk and so you should be able to get an >>> access to the struct page. >> Not necessarily - the guest struct page is not seen by the hypervisor. The >> hypervisor only gets those guest pfns which are hinted as unused. From the >> hypervisor (host) point of view, a guest physical address corresponds to a >> virtual address of a host process. So, once the hypervisor knows a guest >> physical page is unsued, it knows that the corresponding virtual memory of >> the process doesn't need to be transferred in the 1st round. > I am sorry, but I do not understand. Why cannot _guest_ simply check the > struct page ref count and send them to the hypervisor? Were you suggesting the following? 1) get a free page block from the page list using the API; 2) if page->ref_count == 0, send it to the hypervisor Btw, ref_count may also change at any time. > Is there any > documentation which describes the workflow or code which would use your > new API? > It's used in the balloon driver (patch 8). We don't have any docs yet, but I think the high level workflow is the two steps above. Best, Wei