From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark yao Subject: Re: [PATCH v5 3/7] drm/rockchip: vop: move line_flag_num to interrupt registers Date: Wed, 26 Jul 2017 14:17:06 +0800 Message-ID: <597833E2.4070607@rock-chips.com> References: <1500518564-30371-1-git-send-email-mark.yao@rock-chips.com> <1500518613-30590-1-git-send-email-mark.yao@rock-chips.com> <1816316.NCRF09CkBJ@phil> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1816316.NCRF09CkBJ@phil> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Heiko Stuebner Cc: linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: linux-rockchip.vger.kernel.org T24gMjAxN+W5tDA35pyIMjbml6UgMDU6NTQsIEhlaWtvIFN0dWVibmVyIHdyb3RlOgo+IEhpIE1h cmssCj4KPiBBbSBEb25uZXJzdGFnLCAyMC4gSnVsaSAyMDE3LCAxMDo0MzozMiBDRVNUIHNjaHJp ZWIgTWFyayBZYW86Cj4+IEluIHRoZSBoYXJkd2FyZSBkZXNpZ24gcHJvY2VzcywgdGhlIGRlc2ln biBvZiBsaW5lIGZsYWdzCj4+IHJlZ2lzdGVyIGlzIGFzc29jaWF0ZWQgd2l0aCB0aGUgaW50ZXJy dXB0IHJlZ2lzdGVyLAo+PiBwbGFjaW5nIHRoZSBsaW5lIGZsYWdzIGluIHRoZSBpbnRlcnJ1cHQg ZGVmaW5pdGlvbiBpcwo+PiBtb3JlIHJlYXNvbmFibGUsIGFuZCBpdCB3b3VsZCBtYWtlIG11bHRp LXZvcCBkZWZpbmUgZWFzaWxpZXIuCj4+Cj4+IENoYW5nZXMgaW4gdjM6Cj4+IC0gRXhwbGFpbiBt b3JlIGluIGRldGFpbHMsIGludHJvZHVjZSB3aHkgd2UgbmVlZCB0aGlzIHBhdGNoCj4+Cj4+IFNp Z25lZC1vZmYtYnk6IE1hcmsgWWFvIDxtYXJrLnlhb0Byb2NrLWNoaXBzLmNvbT4KPj4gUmV2aWV3 ZWQtYnk6IFNlYW4gUGF1bCA8c2VhbnBhdWxAY2hyb21pdW0ub3JnPgo+PiAtLS0KPj4gICBkcml2 ZXJzL2dwdS9kcm0vcm9ja2NoaXAvcm9ja2NoaXBfZHJtX3ZvcC5jIHwgMiArLQo+PiAgIGRyaXZl cnMvZ3B1L2RybS9yb2NrY2hpcC9yb2NrY2hpcF9kcm1fdm9wLmggfCA0ICsrLS0KPj4gICBkcml2 ZXJzL2dwdS9kcm0vcm9ja2NoaXAvcm9ja2NoaXBfdm9wX3JlZy5jIHwgOCArKysrLS0tLQo+PiAg IDMgZmlsZXMgY2hhbmdlZCwgNyBpbnNlcnRpb25zKCspLCA3IGRlbGV0aW9ucygtKQo+Pgo+PiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL3JvY2tjaGlwX2RybV92b3AuYyBi L2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9yb2NrY2hpcF9kcm1fdm9wLmMKPj4gaW5kZXggNzg0 YTJiNy4uNGY2YzdiYyAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL3Jv Y2tjaGlwX2RybV92b3AuYwo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvcm9ja2No aXBfZHJtX3ZvcC5jCj4+IEBAIC05ODIsNyArOTgyLDcgQEAgc3RhdGljIHZvaWQgdm9wX2NydGNf ZW5hYmxlKHN0cnVjdCBkcm1fY3J0YyAqY3J0YykKPj4gICAJVk9QX0NUUkxfU0VUKHZvcCwgdmFj dF9zdF9lbmQsIHZhbCk7Cj4+ICAgCVZPUF9DVFJMX1NFVCh2b3AsIHZwb3N0X3N0X2VuZCwgdmFs KTsKPj4gICAKPj4gLQlWT1BfQ1RSTF9TRVQodm9wLCBsaW5lX2ZsYWdfbnVtWzBdLCB2YWN0X2Vu ZCk7Cj4+ICsJVk9QX0lOVFJfU0VUKHZvcCwgbGluZV9mbGFnX251bVswXSwgdmFjdF9lbmQpOwo+ IFdpdGggcGF0Y2hlcyBhcHBsaWVkIHVwIHRvIHRoaXMgb25lIEkgZW5kIHVwIHdpdGgKPgo+ICAg IENDIFtNXSAgZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL3JvY2tjaGlwX2RybV92b3Aubwo+IC4u L2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9yb2NrY2hpcF9kcm1fdm9wLmM6IEluIGZ1bmN0aW9u IOKAmHZvcF9jcnRjX2VuYWJsZeKAmToKPiAuLi9kcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvcm9j a2NoaXBfZHJtX3ZvcC5jOjk4NTo0NjogZXJyb3I6IG1hY3JvICJWT1BfSU5UUl9TRVQiIHJlcXVp cmVzIDQgYXJndW1lbnRzLCBidXQgb25seSAzIGdpdmVuCj4gICAgVk9QX0lOVFJfU0VUKHZvcCwg bGluZV9mbGFnX251bVswXSwgdmFjdF9lbmQpOwo+ICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgXgo+IC4uL2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9yb2Nr Y2hpcF9kcm1fdm9wLmM6OTg1OjI6IGVycm9yOiDigJhWT1BfSU5UUl9TRVTigJkgdW5kZWNsYXJl ZCAoZmlyc3QgdXNlIGluIHRoaXMgZnVuY3Rpb24pCj4gICAgVk9QX0lOVFJfU0VUKHZvcCwgbGlu ZV9mbGFnX251bVswXSwgdmFjdF9lbmQpOwo+ICAgIF5+fn5+fn5+fn5+fgo+IC4uL2RyaXZlcnMv Z3B1L2RybS9yb2NrY2hpcC9yb2NrY2hpcF9kcm1fdm9wLmM6OTg1OjI6IG5vdGU6IGVhY2ggdW5k ZWNsYXJlZCBpZGVudGlmaWVyIGlzIHJlcG9ydGVkIG9ubHkgb25jZSBmb3IgZWFjaCBmdW5jdGlv biBpdCBhcHBlYXJzIGluCj4KPiBJbiBwYXRjaDQgeW91IHJlcGxhY2UgdGhpcyBhZ2Fpbiwgd2l0 aAo+IC0JVk9QX0lOVFJfU0VUKHZvcCwgbGluZV9mbGFnX251bVswXSwgdmFjdF9lbmQpOwo+ICsJ Vk9QX1JFR19TRVQodm9wLCBpbnRyLCBsaW5lX2ZsYWdfbnVtWzBdLCB2YWN0X2VuZCk7Cj4KPiBi dXQgdGhpcyBpbnRlcm1lZGlhdGUgYnJlYWthZ2Ugc2hvdWxkIG5vdCBoYXBwZW4sIHRvIGtlZXAg YmlzZWN0YWJpbGl0eS4KPgo+Cj4gSGVpa28KPgo+Cj4KSGkgSGVpa28KClRoYW5rcyBmb3IgdGhl IHRlc3QsIHdpbGwgZml4IGl0IGF0IG5leHQgdmVyc2lvbi4KCi0tIArvvK1hcmsgWWFvCgoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1h aWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: mark.yao@rock-chips.com (Mark yao) Date: Wed, 26 Jul 2017 14:17:06 +0800 Subject: [PATCH v5 3/7] drm/rockchip: vop: move line_flag_num to interrupt registers In-Reply-To: <1816316.NCRF09CkBJ@phil> References: <1500518564-30371-1-git-send-email-mark.yao@rock-chips.com> <1500518613-30590-1-git-send-email-mark.yao@rock-chips.com> <1816316.NCRF09CkBJ@phil> Message-ID: <597833E2.4070607@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2017?07?26? 05:54, Heiko Stuebner wrote: > Hi Mark, > > Am Donnerstag, 20. Juli 2017, 10:43:32 CEST schrieb Mark Yao: >> In the hardware design process, the design of line flags >> register is associated with the interrupt register, >> placing the line flags in the interrupt definition is >> more reasonable, and it would make multi-vop define easilier. >> >> Changes in v3: >> - Explain more in details, introduce why we need this patch >> >> Signed-off-by: Mark Yao >> Reviewed-by: Sean Paul >> --- >> drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 2 +- >> drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 4 ++-- >> drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 8 ++++---- >> 3 files changed, 7 insertions(+), 7 deletions(-) >> >> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c >> index 784a2b7..4f6c7bc 100644 >> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c >> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c >> @@ -982,7 +982,7 @@ static void vop_crtc_enable(struct drm_crtc *crtc) >> VOP_CTRL_SET(vop, vact_st_end, val); >> VOP_CTRL_SET(vop, vpost_st_end, val); >> >> - VOP_CTRL_SET(vop, line_flag_num[0], vact_end); >> + VOP_INTR_SET(vop, line_flag_num[0], vact_end); > With patches applied up to this one I end up with > > CC [M] drivers/gpu/drm/rockchip/rockchip_drm_vop.o > ../drivers/gpu/drm/rockchip/rockchip_drm_vop.c: In function ?vop_crtc_enable?: > ../drivers/gpu/drm/rockchip/rockchip_drm_vop.c:985:46: error: macro "VOP_INTR_SET" requires 4 arguments, but only 3 given > VOP_INTR_SET(vop, line_flag_num[0], vact_end); > ^ > ../drivers/gpu/drm/rockchip/rockchip_drm_vop.c:985:2: error: ?VOP_INTR_SET? undeclared (first use in this function) > VOP_INTR_SET(vop, line_flag_num[0], vact_end); > ^~~~~~~~~~~~ > ../drivers/gpu/drm/rockchip/rockchip_drm_vop.c:985:2: note: each undeclared identifier is reported only once for each function it appears in > > In patch4 you replace this again, with > - VOP_INTR_SET(vop, line_flag_num[0], vact_end); > + VOP_REG_SET(vop, intr, line_flag_num[0], vact_end); > > but this intermediate breakage should not happen, to keep bisectability. > > > Heiko > > > Hi Heiko Thanks for the test, will fix it at next version. -- ?ark Yao From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751403AbdGZGRV (ORCPT ); Wed, 26 Jul 2017 02:17:21 -0400 Received: from regular1.263xmail.com ([211.150.99.133]:41773 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750883AbdGZGRU (ORCPT ); Wed, 26 Jul 2017 02:17:20 -0400 X-263anti-spam: KSV:0;BIG:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ADDR-CHECKED4: 1 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ANTISPAM-LEVEL: 2 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: linux-kernel@vger.kernel.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: <024da8ba2a27af614cb19f1d7b0ffddd> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v5 3/7] drm/rockchip: vop: move line_flag_num to interrupt registers To: Heiko Stuebner References: <1500518564-30371-1-git-send-email-mark.yao@rock-chips.com> <1500518613-30590-1-git-send-email-mark.yao@rock-chips.com> <1816316.NCRF09CkBJ@phil> Cc: David Airlie , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org From: Mark yao Message-ID: <597833E2.4070607@rock-chips.com> Date: Wed, 26 Jul 2017 14:17:06 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1816316.NCRF09CkBJ@phil> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017年07月26日 05:54, Heiko Stuebner wrote: > Hi Mark, > > Am Donnerstag, 20. Juli 2017, 10:43:32 CEST schrieb Mark Yao: >> In the hardware design process, the design of line flags >> register is associated with the interrupt register, >> placing the line flags in the interrupt definition is >> more reasonable, and it would make multi-vop define easilier. >> >> Changes in v3: >> - Explain more in details, introduce why we need this patch >> >> Signed-off-by: Mark Yao >> Reviewed-by: Sean Paul >> --- >> drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 2 +- >> drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 4 ++-- >> drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 8 ++++---- >> 3 files changed, 7 insertions(+), 7 deletions(-) >> >> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c >> index 784a2b7..4f6c7bc 100644 >> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c >> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c >> @@ -982,7 +982,7 @@ static void vop_crtc_enable(struct drm_crtc *crtc) >> VOP_CTRL_SET(vop, vact_st_end, val); >> VOP_CTRL_SET(vop, vpost_st_end, val); >> >> - VOP_CTRL_SET(vop, line_flag_num[0], vact_end); >> + VOP_INTR_SET(vop, line_flag_num[0], vact_end); > With patches applied up to this one I end up with > > CC [M] drivers/gpu/drm/rockchip/rockchip_drm_vop.o > ../drivers/gpu/drm/rockchip/rockchip_drm_vop.c: In function ‘vop_crtc_enable’: > ../drivers/gpu/drm/rockchip/rockchip_drm_vop.c:985:46: error: macro "VOP_INTR_SET" requires 4 arguments, but only 3 given > VOP_INTR_SET(vop, line_flag_num[0], vact_end); > ^ > ../drivers/gpu/drm/rockchip/rockchip_drm_vop.c:985:2: error: ‘VOP_INTR_SET’ undeclared (first use in this function) > VOP_INTR_SET(vop, line_flag_num[0], vact_end); > ^~~~~~~~~~~~ > ../drivers/gpu/drm/rockchip/rockchip_drm_vop.c:985:2: note: each undeclared identifier is reported only once for each function it appears in > > In patch4 you replace this again, with > - VOP_INTR_SET(vop, line_flag_num[0], vact_end); > + VOP_REG_SET(vop, intr, line_flag_num[0], vact_end); > > but this intermediate breakage should not happen, to keep bisectability. > > > Heiko > > > Hi Heiko Thanks for the test, will fix it at next version. -- Ｍark Yao