From mboxrd@z Thu Jan 1 00:00:00 1970 From: jeffy Subject: Re: [v6,1/7] drm/rockchip: vop: initialize registers directly Date: Thu, 27 Jul 2017 16:31:33 +0800 Message-ID: <5979A4E5.6090107@rock-chips.com> References: <1501049946-5877-1-git-send-email-mark.yao@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1501049946-5877-1-git-send-email-mark.yao@rock-chips.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Mark yao , David Airlie , Heiko Stuebner Cc: linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org List-Id: linux-rockchip.vger.kernel.org SGkgbWFyaywKCk9uIDA3LzI2LzIwMTcgMDI6MTkgUE0sIE1hcmsgeWFvIHdyb3RlOgo+IEF0IHBy ZXNlbnQgd2UgYXJlIHVzaW5nIGluaXRfdGFibGUgdG8gaW5pdGlhbGl6ZSBzb21lCj4gcmVnaXN0 ZXJzLCBidXQgdGhlIFJlZ2lzdGVyIGluaXQgdGFibGUgdXNlIHVuLWRvY3VtZW50IGRlZmluZSwK PiBpdCBpcyB1bnJlYWRhYmxlLCBhbmQgc29tZXRpbWVzIHdlIG9ubHkgd2FudCB0byB1cGRhdGUg dGlueQo+IGJpdHMsIGluaXQgdGFibGUgbWV0aG9kIGlzIG5vdCBmcmllbmRseSwgaXQncyBkaWZm Y3VsdCB0bwo+IHJldXNlIGZvciBkaWZmZXJlbmNlIGNoaXBzLgo+Cj4gVG8gbWFrZSBpdCBjbGVh biwgaW5pdGlhbGl6ZSByZWdpc3RlcnMgZGlyZWN0bHksIGFuZCBkcm9wcwo+IGluaXRfdGFibGUg bWVjaGFuaXNtIG91dC4KPgo+IFNpZ25lZC1vZmYtYnk6IE1hcmsgWWFvPG1hcmsueWFvQHJvY2st Y2hpcHMuY29tPgo+IFRlc3RlZC1ieTogSGVpa28gU3R1ZWJuZXI8aGVpa29Ac250ZWNoLmRlPgoK UmV2aWV3ZWQtYnk6IEplZmZ5IENoZW4gPGplZmZ5LmNoZW5Acm9jay1jaGlwcy5jb20+CgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFp bGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: jeffy.chen@rock-chips.com (jeffy) Date: Thu, 27 Jul 2017 16:31:33 +0800 Subject: [v6,1/7] drm/rockchip: vop: initialize registers directly In-Reply-To: <1501049946-5877-1-git-send-email-mark.yao@rock-chips.com> References: <1501049946-5877-1-git-send-email-mark.yao@rock-chips.com> Message-ID: <5979A4E5.6090107@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi mark, On 07/26/2017 02:19 PM, Mark yao wrote: > At present we are using init_table to initialize some > registers, but the Register init table use un-document define, > it is unreadable, and sometimes we only want to update tiny > bits, init table method is not friendly, it's diffcult to > reuse for difference chips. > > To make it clean, initialize registers directly, and drops > init_table mechanism out. > > Signed-off-by: Mark Yao > Tested-by: Heiko Stuebner Reviewed-by: Jeffy Chen From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751777AbdG0Ibk (ORCPT ); Thu, 27 Jul 2017 04:31:40 -0400 Received: from regular1.263xmail.com ([211.150.99.139]:36516 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751566AbdG0Ibi (ORCPT ); Thu, 27 Jul 2017 04:31:38 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: jeffy.chen@rock-chips.com X-FST-TO: mark.yao@rock-chips.com X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: jeffy.chen@rock-chips.com X-UNIQUE-TAG: <4c4f4b47d9154427d4f7b07dbcc092c0> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <5979A4E5.6090107@rock-chips.com> Date: Thu, 27 Jul 2017 16:31:33 +0800 From: jeffy User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:19.0) Gecko/20130126 Thunderbird/19.0 MIME-Version: 1.0 To: Mark yao , David Airlie , Heiko Stuebner CC: linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [v6,1/7] drm/rockchip: vop: initialize registers directly References: <1501049946-5877-1-git-send-email-mark.yao@rock-chips.com> In-Reply-To: <1501049946-5877-1-git-send-email-mark.yao@rock-chips.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi mark, On 07/26/2017 02:19 PM, Mark yao wrote: > At present we are using init_table to initialize some > registers, but the Register init table use un-document define, > it is unreadable, and sometimes we only want to update tiny > bits, init table method is not friendly, it's diffcult to > reuse for difference chips. > > To make it clean, initialize registers directly, and drops > init_table mechanism out. > > Signed-off-by: Mark Yao > Tested-by: Heiko Stuebner Reviewed-by: Jeffy Chen