From mboxrd@z Thu Jan 1 00:00:00 1970 From: jeffy Subject: Re: [v6,7/7] drm/rockchip: vop: rk3328: fix overlay abnormal Date: Thu, 27 Jul 2017 16:42:36 +0800 Message-ID: <5979A77C.6000304@rock-chips.com> References: <1501049980-6239-1-git-send-email-mark.yao@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1501049980-6239-1-git-send-email-mark.yao@rock-chips.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Mark yao , David Airlie , Heiko Stuebner Cc: linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org List-Id: linux-rockchip.vger.kernel.org SGkgbWFyaywKCk9uIDA3LzI2LzIwMTcgMDI6MTkgUE0sIE1hcmsgeWFvIHdyb3RlOgo+IEl0J3Mg YSBoYXJkd2FyZSBidWcsIGFsbCB3aW5kb3cncyBvdmVybGF5IGNoYW5uZWwgcmVzZXQKPiB2YWx1 ZSBpcyBzYW1lLCBoYXJkd2FyZSBvdmVybGF5IHdvdWxkIGJlIGRpZS4KPgo+IHNvIHdlIG11c3Qg aW5pdGlhbCBkaWZmZXJlbmNlIGlkIGZvciBlYWNoIG92ZXJsYXkgY2hhbm5lbC4KPgo+IFRoZSBD aGFubmVsIHJlZ2lzdGVyIGlzIHN1cHBvcnRlZCBvbiBhbGwgdm9wIHdpbGwgZnVsbCBkZXNpZ24u Cj4gRm9sbG93aW5nIGlzIHRoZSBkZXRhaWxzIGZvciB0aGlzIHJlZ2lzdGVyCj4gVk9QX1dJTjBf Q1RSTDIKPiAgICBiaXRbNzo0XSB3aW5fcmlkX3dpbjBfY2JyCj4gICAgICAgICBheGkgcmVhZCBp ZCBvZiB3aW4wIGNiciBjaGFubmVsCj4gICAgYml0WzM6MF0gd2luX3JpZF93aW4wX3lyZ2IKPiAg ICAgICAgIGF4aSByZWFkIGlkIG9mIHdpbjAgeXJnYiBjaGFubmVsCj4KPiBTaWduZWQtb2ZmLWJ5 OiBNYXJrIFlhbzxtYXJrLnlhb0Byb2NrLWNoaXBzLmNvbT4KClJldmlld2VkLWJ5OiBKZWZmeSBD aGVuIDxqZWZmeS5jaGVuQHJvY2stY2hpcHMuY29tPgoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: jeffy.chen@rock-chips.com (jeffy) Date: Thu, 27 Jul 2017 16:42:36 +0800 Subject: [v6,7/7] drm/rockchip: vop: rk3328: fix overlay abnormal In-Reply-To: <1501049980-6239-1-git-send-email-mark.yao@rock-chips.com> References: <1501049980-6239-1-git-send-email-mark.yao@rock-chips.com> Message-ID: <5979A77C.6000304@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi mark, On 07/26/2017 02:19 PM, Mark yao wrote: > It's a hardware bug, all window's overlay channel reset > value is same, hardware overlay would be die. > > so we must initial difference id for each overlay channel. > > The Channel register is supported on all vop will full design. > Following is the details for this register > VOP_WIN0_CTRL2 > bit[7:4] win_rid_win0_cbr > axi read id of win0 cbr channel > bit[3:0] win_rid_win0_yrgb > axi read id of win0 yrgb channel > > Signed-off-by: Mark Yao Reviewed-by: Jeffy Chen From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751598AbdG0Imm (ORCPT ); Thu, 27 Jul 2017 04:42:42 -0400 Received: from regular1.263xmail.com ([211.150.99.140]:57236 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750946AbdG0Imk (ORCPT ); Thu, 27 Jul 2017 04:42:40 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: jeffy.chen@rock-chips.com X-FST-TO: mark.yao@rock-chips.com X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: jeffy.chen@rock-chips.com X-UNIQUE-TAG: <5d876c8cf85aaa9fdbccced04f0cbf0b> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <5979A77C.6000304@rock-chips.com> Date: Thu, 27 Jul 2017 16:42:36 +0800 From: jeffy User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:19.0) Gecko/20130126 Thunderbird/19.0 MIME-Version: 1.0 To: Mark yao , David Airlie , Heiko Stuebner CC: linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [v6,7/7] drm/rockchip: vop: rk3328: fix overlay abnormal References: <1501049980-6239-1-git-send-email-mark.yao@rock-chips.com> In-Reply-To: <1501049980-6239-1-git-send-email-mark.yao@rock-chips.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi mark, On 07/26/2017 02:19 PM, Mark yao wrote: > It's a hardware bug, all window's overlay channel reset > value is same, hardware overlay would be die. > > so we must initial difference id for each overlay channel. > > The Channel register is supported on all vop will full design. > Following is the details for this register > VOP_WIN0_CTRL2 > bit[7:4] win_rid_win0_cbr > axi read id of win0 cbr channel > bit[3:0] win_rid_win0_yrgb > axi read id of win0 yrgb channel > > Signed-off-by: Mark Yao Reviewed-by: Jeffy Chen