From mboxrd@z Thu Jan 1 00:00:00 1970 From: jeffy Subject: Re: [v6, 2/7] drm/rockchip: vop: move write_relaxed flags to vop register Date: Thu, 27 Jul 2017 16:43:05 +0800 Message-ID: <5979A799.1050809@rock-chips.com> References: <1501049953-5946-1-git-send-email-mark.yao@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1501049953-5946-1-git-send-email-mark.yao@rock-chips.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Mark yao , David Airlie , Heiko Stuebner Cc: linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org List-Id: linux-rockchip.vger.kernel.org SGkgbWFyaywKCk9uIDA3LzI2LzIwMTcgMDI6MTkgUE0sIE1hcmsgeWFvIHdyb3RlOgo+IFNpbmNl IHRoZSBkcm0gYXRvbWljIGZyYW1ld29yaywgb25seSBhIHNtYWxsIHBhcnQgb2YgdGhlIHZvcAo+ IHJlZ2lzdGVyIG5lZWRzIHN5bmMgd3JpdGUsIEN1cnJlbnRseSBzZWVtcyBvbmx5IGZvbGxvd2lu ZyByZWdpc3RlcnMKPiBuZWVkIHN5bmMgd3JpdGU6Cj4gICAgIGNmZ19kb25lLCBzdGFuZGJ5IGFu ZCBpbnRlcnJ1cHQgcmVsYXRlZCByZWdpc3Rlci4KPgo+IEFsbCBjdHJsIHJlZ2lzdGVycyBhcmUg dXNpbmcgdGhlIHN5bmMgd3JpdGUgbWV0aG9kIHRoYXQgaXMKPiBpbmVmZmljaWVudCwgaGFyZGNv ZGUgdGhlIHdyaXRlX3JlbGF4ZWQgZmxhZ3MgdG8gdm9wIHJlZ2lzdGVycywKPiB0aGVuIGNhbiBv bmx5IGRvIHN5bmNocm9uaXplIHdyaXRlIGZvciB0aG9zZSBhY3R1YWwgbmVlZGVkIHJlZ2lzdGVy Lgo+Cj4gU2lnbmVkLW9mZi1ieTogTWFyayBZYW88bWFyay55YW9Acm9jay1jaGlwcy5jb20+Cj4g VGVzdGVkLWJ5OiBIZWlrbyBTdHVlYm5lcjxoZWlrb0BzbnRlY2guZGU+CgpSZXZpZXdlZC1ieTog SmVmZnkgQ2hlbiA8amVmZnkuY2hlbkByb2NrLWNoaXBzLmNvbT4KCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJp LWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: jeffy.chen@rock-chips.com (jeffy) Date: Thu, 27 Jul 2017 16:43:05 +0800 Subject: [v6, 2/7] drm/rockchip: vop: move write_relaxed flags to vop register In-Reply-To: <1501049953-5946-1-git-send-email-mark.yao@rock-chips.com> References: <1501049953-5946-1-git-send-email-mark.yao@rock-chips.com> Message-ID: <5979A799.1050809@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi mark, On 07/26/2017 02:19 PM, Mark yao wrote: > Since the drm atomic framework, only a small part of the vop > register needs sync write, Currently seems only following registers > need sync write: > cfg_done, standby and interrupt related register. > > All ctrl registers are using the sync write method that is > inefficient, hardcode the write_relaxed flags to vop registers, > then can only do synchronize write for those actual needed register. > > Signed-off-by: Mark Yao > Tested-by: Heiko Stuebner Reviewed-by: Jeffy Chen From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751671AbdG0InK (ORCPT ); Thu, 27 Jul 2017 04:43:10 -0400 Received: from regular1.263xmail.com ([211.150.99.139]:37837 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751452AbdG0InI (ORCPT ); Thu, 27 Jul 2017 04:43:08 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: jeffy.chen@rock-chips.com X-FST-TO: mark.yao@rock-chips.com X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: jeffy.chen@rock-chips.com X-UNIQUE-TAG: <001646b1e9492ff611e1add5e74d2968> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <5979A799.1050809@rock-chips.com> Date: Thu, 27 Jul 2017 16:43:05 +0800 From: jeffy User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:19.0) Gecko/20130126 Thunderbird/19.0 MIME-Version: 1.0 To: Mark yao , David Airlie , Heiko Stuebner CC: linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [v6,2/7] drm/rockchip: vop: move write_relaxed flags to vop register References: <1501049953-5946-1-git-send-email-mark.yao@rock-chips.com> In-Reply-To: <1501049953-5946-1-git-send-email-mark.yao@rock-chips.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi mark, On 07/26/2017 02:19 PM, Mark yao wrote: > Since the drm atomic framework, only a small part of the vop > register needs sync write, Currently seems only following registers > need sync write: > cfg_done, standby and interrupt related register. > > All ctrl registers are using the sync write method that is > inefficient, hardcode the write_relaxed flags to vop registers, > then can only do synchronize write for those actual needed register. > > Signed-off-by: Mark Yao > Tested-by: Heiko Stuebner Reviewed-by: Jeffy Chen