From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751569AbdG0I4J (ORCPT ); Thu, 27 Jul 2017 04:56:09 -0400 Received: from mga11.intel.com ([192.55.52.93]:34042 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750836AbdG0I4H (ORCPT ); Thu, 27 Jul 2017 04:56:07 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,419,1496127600"; d="scan'208";a="130060865" Subject: Re: [PATCH v2 5/5] usb: xhci: Handle USB transaction error on address command To: Felipe Balbi , Mathias Nyman References: <1501122098-10935-1-git-send-email-baolu.lu@linux.intel.com> <1501122098-10935-6-git-send-email-baolu.lu@linux.intel.com> <87vame2u0i.fsf@linux.intel.com> Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, zhengjun.xing@linux.intel.com From: Lu Baolu Message-ID: <5979AAA5.5090601@linux.intel.com> Date: Thu, 27 Jul 2017 16:56:05 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <87vame2u0i.fsf@linux.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 07/27/2017 03:55 PM, Felipe Balbi wrote: > Hi, > > Lu Baolu writes: >> Xhci driver handles USB transaction errors on transfer events, >> but transaction errors are possible on address device command >> completion events as well. >> >> The xHCI specification (section 4.6.5) says: A USB Transaction >> Error Completion Code for an Address Device Command may be due >> to a Stall response from a device. Software should issue a Disable >> Slot Command for the Device Slot then an Enable Slot Command to >> recover from this error. >> >> This patch handles USB transaction errors on address command >> completion events. The related discussion threads can be found >> through below links. >> >> http://marc.info/?l=linux-usb&m=149362010728921&w=2 >> http://marc.info/?l=linux-usb&m=149252752825755&w=2 >> >> Suggested-by: Mathias Nyman >> Signed-off-by: Lu Baolu >> --- >> drivers/usb/host/xhci.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c >> index d6b728d..95780f8 100644 >> --- a/drivers/usb/host/xhci.c >> +++ b/drivers/usb/host/xhci.c >> @@ -3822,6 +3822,11 @@ static int xhci_setup_device(struct usb_hcd *hcd, struct usb_device *udev, >> break; >> case COMP_USB_TRANSACTION_ERROR: >> dev_warn(&udev->dev, "Device not responding to setup %s.\n", act); >> + >> + ret = xhci_disable_slot(xhci, udev->slot_id); >> + if (!ret) >> + xhci_alloc_dev(hcd, udev); > aren't you leaking previously allocated virt_dev ? > When disable slot command completes, the command completion handler will release the previous allocated virt_dev. Best regards, Lu Baolu