Re: [PATCH v4 01/10] rtlwifi: Fill in_4way field by driver

[Arend van Spriel <arend.vanspriel@broadcom.com>]

On 7/27/2017 11:54 AM, Kalle Valo wrote:
> Larry Finger <Larry.Finger@lwfinger.net> writes:
>
>> From: Ping-Ke Shih <pkshih@realtek.com>
>>
>> Because it isn't always correct to use EAPOL to check 4-way,
>> we add a timer to handle exception.
>>
>> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
>> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
>> Cc: Yan-Hsuan Chuang <yhchuang@realtek.com>
>> Cc: Birming Chiu <birming@realtek.com>
>> Cc: Shaofu <shaofu@realtek.com>
>> Cc: Steven Ting <steventing@realtek.com>
>
> [...]
>
>> --- a/drivers/net/wireless/realtek/rtlwifi/base.c
>> +++ b/drivers/net/wireless/realtek/rtlwifi/base.c
>> @@ -1408,6 +1408,11 @@ u8 rtl_is_special_data(struct ieee80211_hw *hw, struct sk_buff *skb, u8 is_tx,
>>
>>   		return true;
>>   	} else if (ETH_P_PAE == ether_type) {
>> +		/* EAPOL is seens as in-4way */
>> +		rtlpriv->btcoexist.btc_info.in_4way = true;
>> +		rtlpriv->btcoexist.btc_info.in_4way_ts = jiffies;
>> +	rtlpriv->btcoexist.btc_info.in_4way_ts = jiffies;
>> +
>>   		RT_TRACE(rtlpriv, (COMP_SEND | COMP_RECV), DBG_DMESG,
>>   			 "802.1X %s EAPOL pkt!!\n", (is_tx) ? "Tx" : "Rx");
>
> The indentation looks wrong.

That wrongly indented line seems a bit redundant anyway :-p

Regards,
Arend