From: Menglong Dong <menglong.dong@linux.dev>
To: menglong8.dong@gmail.com, bot+bpf-ci@kernel.org
Cc: ast@kernel.org, daniel@iogearbox.net, john.fastabend@gmail.com,
andrii@kernel.org, martin.lau@linux.dev, eddyz87@gmail.com,
memxor@gmail.com, song@kernel.org, yonghong.song@linux.dev,
jolsa@kernel.org, shuah@kernel.org, emil@etsalapatis.com,
bpf@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, ast@kernel.org,
andrii@kernel.org, daniel@iogearbox.net, martin.lau@kernel.org,
eddyz87@gmail.com, yonghong.song@linux.dev, clm@meta.com,
ihor.solodrai@linux.dev
Subject: Re: [PATCH bpf-next 1/3] bpf: add missing fsession to the verifier log
Date: Wed, 08 Apr 2026 13:52:49 +0800 [thread overview]
Message-ID: <5980838.DvuYhMxLoT@7940hx> (raw)
In-Reply-To: <772063b0c36262d2bee020fb590eca02ef6bfbfbecebf3a88be540b373c6ed4d@mail.kernel.org>
On 2026/4/8 12:55 bot+bpf-ci@kernel.org write:
> > diff --git a/tools/testing/selftests/bpf/prog_tests/exceptions.c b/tools/testing/selftests/bpf/prog_tests/exceptions.c
> > index 84ab73e08b0e6..94a62fcd4543d 100644
> > --- a/tools/testing/selftests/bpf/prog_tests/exceptions.c
> > +++ b/tools/testing/selftests/bpf/prog_tests/exceptions.c
> > @@ -128,7 +128,7 @@ static void test_exceptions_success(void)
> > bpf_program__fd(skel->progs.exception_ext_mod_cb_runtime),
> > "exception_cb_mod"), "set_attach_target"))
> > goto done;
> > - }), "FENTRY/FEXIT programs cannot attach to exception callback", 0);
> > + }), "FENTRY/FEXIT/FSESSION programs cannot attach to exception callback", 0);
>
> These four selftest locations now expect the string
> "FENTRY/FEXIT/FSESSION programs cannot attach to exception callback",
> but the verifier message they match against was not updated. In
> bpf_check_attach_target() the format string still reads:
>
> prog_extension ? "Extension" : "FENTRY/FEXIT");
You are right, I missed this part. I'll update it in the V2.
Thanks!
Menglong Dong
>
> so the kernel produces "FENTRY/FEXIT programs cannot attach to
> exception callback". The RUN_EXT macro uses strstr() to match the
> expected string against the kernel log buffer, and since
> "FENTRY/FEXIT/FSESSION" is not a substring of "FENTRY/FEXIT programs",
> strstr() returns NULL and the ASSERT_OK_PTR fails.
>
> Should the verifier message also be updated to include FSESSION, to
> match the selftest expectation? As it stands these four subtests will
> fail.
>
> > [ ... ]
>
>
> ---
> AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
> See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md
>
> CI run summary: https://github.com/kernel-patches/bpf/actions/runs/24117471086
next prev parent reply other threads:[~2026-04-08 5:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-08 3:14 [PATCH bpf-next 0/3] bpf: add the missing fsession Menglong Dong
2026-04-08 3:14 ` [PATCH bpf-next 1/3] bpf: add missing fsession to the verifier log Menglong Dong
2026-04-08 4:55 ` bot+bpf-ci
2026-04-08 5:52 ` Menglong Dong [this message]
2026-04-08 9:52 ` Chengkaitao
2026-04-08 10:39 ` Menglong Dong
2026-04-08 3:14 ` [PATCH bpf-next 2/3] docs/bpf: add missing fsession attach type to docs Menglong Dong
2026-04-08 3:14 ` [PATCH bpf-next 3/3] bpftool: add missing fsession to the usage and docs of bpftool Menglong Dong
2026-04-08 4:27 ` [PATCH bpf-next 0/3] bpf: add the missing fsession Leon Hwang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5980838.DvuYhMxLoT@7940hx \
--to=menglong.dong@linux.dev \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bot+bpf-ci@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=clm@meta.com \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=emil@etsalapatis.com \
--cc=ihor.solodrai@linux.dev \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martin.lau@kernel.org \
--cc=martin.lau@linux.dev \
--cc=memxor@gmail.com \
--cc=menglong8.dong@gmail.com \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.