From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Souptick Joarder <jrdr.linux@gmail.com>
Cc: Kalle Valo <kvalo@codeaurora.org>,
Larry Finger <Larry.Finger@lwfinger.net>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v4] rtlwifi: Replace hardcode value with macro
Date: Wed, 02 Aug 2017 12:50:26 +0200 [thread overview]
Message-ID: <5981AE72.5050002@broadcom.com> (raw)
In-Reply-To: <CAFqt6zbiOEdOYzMa5a219=ROLv6BpJ9x0gdL3N61f+=_W8oK8w@mail.gmail.com>
On 8/2/2017 12:47 PM, Souptick Joarder wrote:
> Hi Kalle,
>
> On Wed, Aug 2, 2017 at 2:51 PM, Kalle Valo <kvalo@codeaurora.org> wrote:
>> Larry Finger <Larry.Finger@lwfinger.net> writes:
>>
>>> On 07/31/2017 06:14 AM, Souptick Joarder wrote:
>>>> In _rtl_init_mac80211(), hardcoded value for hw->max_listen_interval
>>>> and hw->max_rate_tries are replaced by macro.
>>>
>>> That is NOT what your patch does. It only removes a comment! Granted,
>>> that comment is useless and should come out, but your commit message
>>> must be a little more accurate.
>>
>> Actually the patch does not even apply, I suspect that Souptick
>> incorrectly used v3 of his patch as the baseline for v4. Instead this v4
>> should be folded with v3.
>
> Do you mean I should address your comment in v3 and send v3 again
> instead of v4 ?
Your v4 patch should apply on top of wireless-drivers-next/master as is.
Regards,
Arend
next prev parent reply other threads:[~2017-08-02 10:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-31 11:14 [PATCH v4] rtlwifi: Replace hardcode value with macro Souptick Joarder
2017-07-31 14:18 ` Larry Finger
2017-08-02 9:21 ` Kalle Valo
2017-08-02 10:47 ` Souptick Joarder
2017-08-02 10:50 ` Arend van Spriel [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-08-02 11:59 Souptick Joarder
2017-08-02 12:10 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5981AE72.5050002@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=Larry.Finger@lwfinger.net \
--cc=jrdr.linux@gmail.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.