From: Thomas Monjalon <thomas@monjalon.net>
To: David Marchand <david.marchand@redhat.com>,
Bruce Richardson <bruce.richardson@intel.com>
Cc: dev <dev@dpdk.org>, dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] eal: fix version macro
Date: Wed, 17 Mar 2021 16:39:55 +0100 [thread overview]
Message-ID: <59852780.U2hSXxEtjn@thomas> (raw)
In-Reply-To: <CAJFAV8yz=JRa802RhOf8LhsoKAnYdZUitm_LcXUnDpx=L7=k7A@mail.gmail.com>
17/03/2021 16:36, David Marchand:
> On Wed, Mar 17, 2021 at 10:31 AM Thomas Monjalon <thomas@monjalon.net> wrote:
> >
> > The macro RTE_VERSION is broken since updated with function calls.
> > It is a build-time version number, and must be built with macros.
> > For a run-time version number, there is the function rte_version().
> >
> > Fixes: 5b637a848195 ("eal: fix querying DPDK version at runtime")
> > Cc: stable@dpdk.org
> >
> > Reported-by: David Marchand <david.marchand@redhat.com>
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>
> Acked-by: David Marchand <david.marchand@redhat.com>
Applied quickly because the compilation of some apps are broken.
> Let's discuss the versioning of the new symbols in the other thread.
OK, in this thread:
https://inbox.dpdk.org/dev/20210317151535.1412311-1-thomas@monjalon.net/
prev parent reply other threads:[~2021-03-17 15:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 9:31 [dpdk-dev] [PATCH] eal: fix version macro Thomas Monjalon
2021-03-17 9:48 ` David Marchand
2021-03-17 10:01 ` Thomas Monjalon
2021-03-18 12:28 ` Bruce Richardson
2021-03-18 14:41 ` Thomas Monjalon
2021-03-18 15:45 ` Bruce Richardson
2021-03-17 15:36 ` David Marchand
2021-03-17 15:39 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59852780.U2hSXxEtjn@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.